Jeremy Cline f173b49
From a54988113985ca22e414e132054f234fc8a92604 Mon Sep 17 00:00:00 2001
Jeremy Cline f173b49
From: Gen Zhang <blackgod016574@gmail.com>
Jeremy Cline f173b49
Date: Wed, 29 May 2019 09:53:05 +0800
Jeremy Cline f173b49
Subject: wcd9335: fix a incorrect use of kstrndup()
Jeremy Cline f173b49
Jeremy Cline f173b49
In wcd9335_codec_enable_dec(), 'widget_name' is allocated by kstrndup().
Jeremy Cline f173b49
However, according to doc: "Note: Use kmemdup_nul() instead if the size
Jeremy Cline f173b49
is known exactly." So we should use kmemdup_nul() here instead of
Jeremy Cline f173b49
kstrndup().
Jeremy Cline f173b49
Jeremy Cline f173b49
Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
Jeremy Cline f173b49
Signed-off-by: Mark Brown <broonie@kernel.org>
Jeremy Cline f173b49
---
Jeremy Cline f173b49
 sound/soc/codecs/wcd9335.c | 2 +-
Jeremy Cline f173b49
 1 file changed, 1 insertion(+), 1 deletion(-)
Jeremy Cline f173b49
Jeremy Cline f173b49
diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
Jeremy Cline f173b49
index a04a7cedd99d..85737fe54474 100644
Jeremy Cline f173b49
--- a/sound/soc/codecs/wcd9335.c
Jeremy Cline f173b49
+++ b/sound/soc/codecs/wcd9335.c
Jeremy Cline f173b49
@@ -2734,7 +2734,7 @@ static int wcd9335_codec_enable_dec(struct snd_soc_dapm_widget *w,
Jeremy Cline f173b49
 	char *dec;
Jeremy Cline f173b49
 	u8 hpf_coff_freq;
Jeremy Cline f173b49
 
Jeremy Cline f173b49
-	widget_name = kstrndup(w->name, 15, GFP_KERNEL);
Jeremy Cline f173b49
+	widget_name = kmemdup_nul(w->name, 15, GFP_KERNEL);
Jeremy Cline f173b49
 	if (!widget_name)
Jeremy Cline f173b49
 		return -ENOMEM;
Jeremy Cline f173b49
 
Jeremy Cline f173b49
-- 
Jeremy Cline f173b49
cgit 1.2-0.3.lf.el7
Jeremy Cline f173b49