Blob Blame History Raw
From: Eric Sandeen <>
Newsgroups: gmane.comp.file-systems.ext4
Subject: [PATCH] jbd2: clear BH_Delay & BH_Unwritten in journal_unmap_buffer
Date: Tue, 07 Feb 2012 16:07:20 -0600
Lines: 42
Message-ID: <>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Trace: 1328656072 12026 (7 Feb 2012 23:07:52 GMT)
NNTP-Posting-Date: Tue, 7 Feb 2012 23:07:52 +0000 (UTC)
To: ext4 development <>
Original-X-From: Wed Feb 08 00:07:52 2012
Return-path: <>
Original-Received: from ([])
	by with esmtp (Exim 4.69)
	(envelope-from <>)
	id 1Ruu8d-0000lK-5P
	for; Wed, 08 Feb 2012 00:07:51 +0100
Original-Received: ( by via listexpand
	id S1756187Ab2BGXHt (ORCPT <rfc822;>);
	Tue, 7 Feb 2012 18:07:49 -0500
Original-Received: from ([]:19432 "EHLO"
	rhost-flags-OK-OK-OK-OK) by with ESMTP
	id S1753992Ab2BGXHs (ORCPT <rfc822;>);
	Tue, 7 Feb 2012 18:07:48 -0500
Original-Received: from ( [])
	by (8.14.4/8.14.4) with ESMTP id q17N7dj0027622
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <>; Tue, 7 Feb 2012 18:07:48 -0500
Original-Received: from ( [])
	by (8.13.8/8.13.8) with ESMTP id q17M7Kgt001990
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <>; Tue, 7 Feb 2012 17:07:21 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20120129 Thunderbird/10.0
X-Enigmail-Version: 1.3.5
X-Scanned-By: MIMEDefang 2.67 on
Precedence: bulk
List-ID: <>
Xref: gmane.comp.file-systems.ext4:30623
Archived-At: <>

journal_unmap_buffer()'s zap_buffer: code clears a lot of buffer head
state ala discard_buffer(), but does not touch _Delay or _Unwritten
as discard_buffer() does.

This can be problematic in some areas of the ext4 code which assume
that if they have found a buffer marked unwritten or delay, then it's
a live one.  Perhaps those spots should check whether it is mapped
as well, but if jbd2 is going to tear down a buffer, let's really
tear it down completely.

Without this I get some fsx failures on sub-page-block filesystems
up until v3.2, at which point 4e96b2dbbf1d7e81f22047a50f862555a6cb87cb
and 189e868fa8fdca702eb9db9d8afc46b5cb9144c9 make the failures go
away, because buried within that large change is some more flag
clearing.  I still think it's worth doing in jbd2, since
->invalidatepage leads here directly, and it's the right place
to clear away these flags.

Signed-off-by: Eric Sandeen <>

diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 35ae096..52653306 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -1949,6 +1949,8 @@ zap_buffer_unlocked:
+	clear_buffer_delay(bh);
+	clear_buffer_unwritten(bh);
 	bh->b_bdev = NULL;
 	return may_free;

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to
More majordomo info at