#30 devel: Don't run hardlink if rpm-ostree is in use
Opened 6 months ago by walters. Modified 3 months ago
rpms/ walters/kernel ostree-hardlink-more  into  master

file modified
+4 -1

@@ -1686,6 +1686,9 @@ 

  #

  # This macro defines a %%post script for a kernel*-devel package.

  #	%%kernel_devel_post [<subpackage>]

+ # Note we don't run hardlink if ostree is in use, as ostree is

+ # a far more sophisticated hardlink implementation.

+ # https://github.com/projectatomic/rpm-ostree/commit/58a79056a889be8814aa51f507b2c7a4dccee526

  #

  %define kernel_devel_post() \

  %{expand:%%post %{?1:%{1}-}devel}\

@@ -1693,7 +1696,7 @@ 

  then\

      . /etc/sysconfig/kernel || exit $?\

  fi\

- if [ "$HARDLINK" != "no" -a -x /usr/sbin/hardlink ]\

+ if [ "$HARDLINK" != "no" -a -x /usr/sbin/hardlink -a ! -e /run/ostree-booted ] \

  then\

      (cd /usr/src/kernels/%{KVERREL}%{?1:+%{1}} &&\

       /usr/bin/find . -type f | while read f; do\

OSTree is a far, far more sophisticated wrapper around the link()
system call than the hardlink package - it supports using
as a mechanism for transactional offline updates, fetching over
HTTP with GPG signatures and deltas, etc. rpm-ostree uses it
for everything.

Having the kernel-devel package run hardlink just adds
latency to rpm-ostree compose tree unnecessarily.