From: Sergei Zviagintsev Date: Wed, 17 Jun 2015 20:14:56 +0300 Subject: [PATCH] kdbus: kdbus_reply_find(): return on found entry Return found entry immediately instead of assigning it to additional variable and breaking the loop. It's simpler to read, the same way is used in kdbus_conn_has_name(), for example. Signed-off-by: Sergei Zviagintsev Reviewed-by: David Herrmann Reviewed-by: Djalal Harouni Signed-off-by: Greg Kroah-Hartman --- ipc/kdbus/reply.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/ipc/kdbus/reply.c b/ipc/kdbus/reply.c index 89d355b44f63..9d823ebee71f 100644 --- a/ipc/kdbus/reply.c +++ b/ipc/kdbus/reply.c @@ -171,17 +171,15 @@ struct kdbus_reply *kdbus_reply_find(struct kdbus_conn *replying, struct kdbus_conn *reply_dst, u64 cookie) { - struct kdbus_reply *r, *reply = NULL; + struct kdbus_reply *r; list_for_each_entry(r, &reply_dst->reply_list, entry) { if (r->cookie == cookie && - (!replying || r->reply_src == replying)) { - reply = r; - break; - } + (!replying || r->reply_src == replying)) + return r; } - return reply; + return NULL; } /**