PR#3: Enable package gating based on Fedora CI results - rpms/knot-resolver

rpms / knot-resolver

#3 Enable package gating based on Fedora CI results

Merged 3 years ago by tkrizek. Opened 3 years ago by jruzicka.

rpms/ jruzicka/knot-resolver enable-package-gating into master

Enable package gating based on Fedora CI results

Jakub Ružička • 3 years ago

87bf3cc

gating.yml

file added

+15

		`@@ -0,0 +1,15 @@`
		`+ --- !Policy`
		`+ product_versions:`
		`+ - fedora-*`
tkrizek commented 3 years ago Does this work for EPEL as well? I guess we could just try and see...
jruzicka commented 3 years ago Good question. I opened testing PR to fix tests on EPEL 8 and if that works, we can test the gating. Also I've seen this possibly related issue which doesn't answer the question in a satisfying manner but there's hope.
		`+ decision_context: bodhi_update_push_testing`
		`+ subject_type: koji_build`
		`+ rules:`
		`+ - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}`
		`+`
		`+ --- !Policy`
		`+ product_versions:`
		`+ - fedora-*`
		`+ decision_context: bodhi_update_push_stable`
		`+ subject_type: koji_build`
		`+ rules:`
		`+ - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}`

jruzicka commented 3 years ago

as described in https://docs.fedoraproject.org/en-US/ci/gating/

tkrizek commented 3 years ago

Yes, please!

Before we can go ahead with this, I think we first need to fix the tests. They're just an outdated attempt from a long time ago (in a galaxy far away...). Especially the socket activation is totally irrelevant now.

Ideally, the tests/tests.yml would be very similar to our upstream test suite: https://gitlab.nic.cz/knot/knot-resolver/-/blob/master/distro/tests/knot-resolver-pkgtest.yaml
without the repository configuration ofc. But the basic checks could be the same. I'm not sure how to keep these in sync, but even manually is a good start.

jruzicka commented 3 years ago

Oh yes, this is just a test of existing tests... metatest? :)

I'm looking at howto update the tests (from 2018) and the docs as well as all the packages I've looked into (for example this) use standard-test-basic role which runs individual tests as commands and when you want multiple you're supposed to drop a shell script into scripts/.

I could easily rewrite current ansible tests into small shell scripts as suggested to get basic functionality but I wonder about reuse of upstream tests you mentioned...

Edited 3 years ago by jruzicka

jruzicka commented 3 years ago

I proposed a simple fix for existing tests in PR #4 .

jruzicka commented 3 years ago

With PR #4 merged, let's see what [citest] does here and maybe we can try enabling.