c48fd0f
commit b6810da129512b6d0200580d78d22d38cc214e21
c48fd0f
Author: Lukas Slebodnik <lslebodn@redhat.com>
c48fd0f
Date:   Sat Jun 21 17:09:31 2014 +0200
c48fd0f
c48fd0f
    Fix error check in krb5_ldap_parse_principal_name
c48fd0f
    
c48fd0f
    Test the correct variable for NULL to detect a strdup failure.
c48fd0f
    
c48fd0f
    [ghudson@mit.edu: clarified commit message]
c48fd0f
c48fd0f
diff --git a/src/plugins/kdb/ldap/libkdb_ldap/ldap_principal.c b/src/plugins/kdb/ldap/libkdb_ldap/ldap_principal.c
c48fd0f
index 21695a9..44bf339 100644
c48fd0f
--- a/src/plugins/kdb/ldap/libkdb_ldap/ldap_principal.c
c48fd0f
+++ b/src/plugins/kdb/ldap/libkdb_ldap/ldap_principal.c
c48fd0f
@@ -412,7 +412,7 @@ krb5_ldap_parse_principal_name(char *i_princ_name, char **o_princ_name)
c48fd0f
     at_rlm_name = strrchr(i_princ_name, '@');
c48fd0f
     if (!at_rlm_name) {
c48fd0f
         *o_princ_name = strdup(i_princ_name);
c48fd0f
-        if (!o_princ_name)
c48fd0f
+        if (!*o_princ_name)
c48fd0f
             return ENOMEM;
c48fd0f
     } else {
c48fd0f
         k5_buf_init_dynamic(&buf;;