From b48378c92bc43cde9e744ab6c39ec6c38e7ab4fc Mon Sep 17 00:00:00 2001
From: Andrew Toskin <andrew@tosk.in>
Date: Dec 23 2019 22:56:42 +0000
Subject: Changes suggested by Robert-André Mauchin


* Python packages, even with compiled bytecode, should be noarch.
* Include the bundled rarfile library's license in License tag.
* Need hicolor-icon-theme package, so Lector can own its hicolor icons
subdirectory.
* Validate desktop files during %install (or %check).

---

diff --git a/lector.spec b/lector.spec
index 6d240da..0d307ad 100644
--- a/lector.spec
+++ b/lector.spec
@@ -1,10 +1,12 @@
-Name:     lector
-Summary:  ebook reader and collection manager
-URL:      https://github.com/BasioMeusPuga/Lector
-License:  GPLv3
-Version:  0.5.1
-Release:  1%{?dist}
-# BuildArch:  noarch
+Name:       lector
+Summary:    Ebook reader and collection manager
+URL:        https://github.com/BasioMeusPuga/Lector
+Version:    0.5.1
+Release:    1%{?dist}
+BuildArch:  noarch
+
+# Lector uses GPLv3, the bundled Rarfile library uses the MIT license.
+License: GPLv3 and MIT
 
 Source0: https://github.com/BasioMeusPuga/Lector/archive/%{version}/%{name}-%{version}.tar.gz
 
@@ -14,12 +16,13 @@ Source0: https://github.com/BasioMeusPuga/Lector/archive/%{version}/%{name}-%{ve
 #BuildRequires: ## TODO
 %endif
 BuildRequires: python3dist(beautifulsoup4) >= 4.6.0
-BuildRequires: pkgconfig(python3) >= 3.6
+BuildRequires: python3-devel >= 3.6
 BuildRequires: python3-poppler-qt5 >= 0.24.2
 BuildRequires: python3-PyQt5 >= 5.10
 BuildRequires: python3dist(setuptools)
 BuildRequires: pkgconfig(Qt)
 
+Requires: hicolor-icon-theme
 Requires: python3 >= 3.6
 Requires: python3dist(beautifulsoup4) >= 4.6.0
 ## TODO: Python DjVuLibre (for reading DjVu documents) isn't packaged at all yet for Fedora 30.
@@ -72,6 +75,7 @@ mv  ./lector/rarfile/LICENSE  ./LICENSE-rarfile
 
 %install
 %py3_install
+desktop-file-validate %{buildroot}/%{_datadir}/applications/lector.desktop
 # TODO: Not sure how to get %%find_lang to work with Qt linguist (which I assume is what this project uses).
 #%%find_lang Lector --with-qt