PR#1: Avoid including .gz compression in man page globs - rpms/libgxps

rpms / libgxps

#1 Avoid including .gz compression in man page globs

Closed 5 years ago by tomh. Opened 5 years ago by feborges.

rpms/ feborges/libgxps avoid-gz-f29 into master

Avoid including .gz compression in man page globs

Felipe Borges • 5 years ago

074f266

libgxps.spec

file modified

+1 -1

		`@@ -75,7 +75,7 @@`

		`%files tools`
		`%{_bindir}/xpsto*`
		`- %{_mandir}/man1/xpsto*.1.gz`
		`+ %{_mandir}/man1/xpsto.1`


		`%changelog`

feborges commented 5 years ago

The recommendation in the Fedora packaging guidelines is to have:

%{_mandir}/man1/<command>.1*

which is more robust against future changes to the RPM scripts to
use different compression.

For context: we are building Flatpaks from RPMs, and our infra fails in these errors. By introducing these small changes we introduce no regressions. I am proposing PRs for f29, f30, and master.

Pull-Request has been closed by feborges

5 years ago

tomh commented 5 years ago

I'm happy to apply it to master and maybe even F30 but I don't see any benefit to building new releases into F29 for such a trivial change that does affect the produce rpms in any way.

Also, you don't need to open a separate PR for each branch! That just creates more work for me!