#7 Soften KDE dependency
Merged 3 months ago by amigadave. Opened 4 months ago by yselkowitz.
rpms/ yselkowitz/libproxy rawhide  into  rawhide

file modified
+5 -2
@@ -3,7 +3,7 @@ 

  

  Name:           libproxy

  Version:        0.4.18

- Release:        5%{?dist}

+ Release:        6%{?dist}

  Summary:        A library handling all the details of proxy configuration

  

  License:        LGPLv2+
@@ -69,7 +69,7 @@ 

  %package        kde

  Summary:        Plugin for %{name} and kde

  Requires:       %{name}%{?_isa} = %{version}-%{release}

- Requires:       /usr/bin/kreadconfig5

+ Recommends:     /usr/bin/kreadconfig5

  

  %description    kde

  The %{name}-kde package contains the %{name} plugin for kde.
@@ -208,6 +208,9 @@ 

  

  

  %changelog

+ * Wed Feb 08 2023 Yaakov Selkowitz <yselkowi@redhat.com> - 0.4.18-6

+ - Soften KDE dependency

+ 

  * Thu Jan 19 2023 Fedora Release Engineering <releng@fedoraproject.org> - 0.4.18-5

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild

  

The KDE support has a built-in config parser if kreadconfig5 is not present, e.g. in a KDE/Qt 6 flatpak.

If this is merged after the imminent f38 branching, please merge it there too.

Can this be a Recommends instead?

From flatpak perspective, Recommends would be fine because only Requires get installed in flatpaks.

As much as I know, Suggests don't really do much in Fedora so switching to Suggests here would pretty much equal to just taking the line complete out.

(There is a case where suggests can help dnf decide which dependency to pull in, in case it has more than one to choose from but I don't think that's what the spec file here uses it for.)

From flatpak perspective, Recommends would be fine because only Requires get installed in flatpaks.

As much as I know, Suggests don't really do much in Fedora so switching to Suggests here would pretty much equal to just taking the line complete out.

(There is a case where suggests can help dnf decide which dependency to pull in, in case it has more than one to choose from but I don't think that's what the spec file here uses it for.)

Right, this is why I want it to be Recommends instead.

Ok, made it Recommends, although I wonder if a rich dependency makes more sense?

rebased onto c8c0c04

4 months ago

LGTM, @amigadave can you take a look and see if it's good to merge?

Pull-Request has been merged by amigadave

3 months ago

@amigadave please include this in F38 too for the benefit of the new KDE 6 flatpak runtime

@amigadave thanks for merging. This includes a revbump, and we need an actual build in f38 (and of course rawhide/f39) in order to use this in the runtimes. Could you do that or should I?

Metadata