|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
From e220ba8610f8315af473a230565daa978ca6a16c Mon Sep 17 00:00:00 2001
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
Date: Wed, 20 Jan 2016 15:17:09 +0000
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
Subject: [PATCH] Related: rhbz#1149116 collateEquals was set with
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
OString::boolean
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
but extracted with toInt32()
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
since
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
commit c76cd71fe9bdefaef3f33f8ca193c32e3ab112ed
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
fdo#41524: CUPS printing: use "collate" option when PDF is available
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
though actual reported problem works fine for me with default f23
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
configuration already, this looks suspicious however
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
Change-Id: I6fcb5df8039296c0e8b0fe931cb490396182de38
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
Reviewed-on: https://gerrit.libreoffice.org/21629
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
---
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
vcl/unx/generic/printer/jobdata.cxx | 2 +-
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
diff --git a/vcl/unx/generic/printer/jobdata.cxx b/vcl/unx/generic/printer/jobdata.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
index a9f7c30..309309e 100644
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
--- a/vcl/unx/generic/printer/jobdata.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
+++ b/vcl/unx/generic/printer/jobdata.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
@@ -251,7 +251,7 @@ bool JobData::constructFromStreamBuffer( void* pData, sal_uInt32 bytes, JobData&
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
}
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
else if (aLine.startsWith(collateEquals))
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
{
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
- rJobData.m_bCollate = aLine.copy(RTL_CONSTASCII_LENGTH(collateEquals)).toInt32();
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
+ rJobData.m_bCollate = aLine.copy(RTL_CONSTASCII_LENGTH(collateEquals)).toBoolean();
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
}
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
else if (aLine.startsWith(margindajustmentEquals))
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
{
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
--
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
2.5.0
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
46fb8c6 |
|