|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
From 920ad92631734fea28178577f7ad10579fd3ca05 Mon Sep 17 00:00:00 2001
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
Date: Thu, 18 Dec 2014 15:24:05 +0000
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
Subject: [PATCH] Resolves: rhbz#1175142 nStarts ends up as an invalid -1
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
Change-Id: Ic67c5562d0e9936cd6a524ecd4f798aaf885a6e8
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
(cherry picked from commit 1cd9420755dc5d5435bf564a992b727c455a3d73)
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
(cherry picked from commit 4e8ae0f8187a9d3fa77d737f5de248cfd9b0ed55)
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
---
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
vcl/source/control/combobox.cxx | 7 +++++--
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
1 file changed, 5 insertions(+), 2 deletions(-)
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
diff --git a/vcl/source/control/combobox.cxx b/vcl/source/control/combobox.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
index a5810f2..8620102 100644
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
--- a/vcl/source/control/combobox.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
+++ b/vcl/source/control/combobox.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
@@ -297,7 +297,7 @@ IMPL_LINK( ComboBox, ImplAutocompleteHdl, Edit*, pEdit )
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
{
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
OUString aFullText = pEdit->GetText();
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
OUString aStartText = aFullText.copy( 0, (sal_Int32)aSel.Max() );
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
- sal_Int32 nStart = mpImplLB->GetCurrentPos();
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
+ sal_Int32 nStart = mpImplLB->GetCurrentPos();
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
if ( nStart == LISTBOX_ENTRY_NOTFOUND )
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
nStart = 0;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
@@ -308,7 +308,10 @@ IMPL_LINK( ComboBox, ImplAutocompleteHdl, Edit*, pEdit )
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
else if ( eAction == AUTOCOMPLETE_TABBACKWARD )
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
{
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
bForward = false;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
- nStart = nStart ? nStart - 1 : mpImplLB->GetEntryList()->GetEntryCount()-1;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
+ if (nStart)
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
+ nStart = nStart - 1;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
+ else if (mpImplLB->GetEntryList()->GetEntryCount())
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
+ nStart = mpImplLB->GetEntryList()->GetEntryCount()-1;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
}
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
sal_Int32 nPos = LISTBOX_ENTRY_NOTFOUND;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
--
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
1.9.3
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
037943c |
|