|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
3a3da35 |
From 722d918c8f185daae2f3c01cc77d1b3badec936a Mon Sep 17 00:00:00 2001
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm@redhat.com>
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
Date: Wed, 16 Nov 2016 11:52:39 +0000
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
Subject: [PATCH] gtk: under wayland tracking the window position is worthless
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
which isn't news, but...
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
with focus follows mouse enabled, activate filter menu of a calc autofilter.
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
Move the mouse around and enter the menu, menu pops down because there are
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
configure and mouse events which indicate that the position of the main
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
application window has "moved"
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
when LibreOffice detects the window has moved, it closes the windows
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
popups, so the menu disappears.
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
Change-Id: I2d1aa4a51153002c925e2dde4402da2d84e52de5
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
---
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
vcl/source/app/settings.cxx | 2 +-
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
vcl/unx/gtk3/gtk3gtkframe.cxx | 10 ++++++++--
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx | 2 +-
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
3a3da35 |
3 files changed, 10 insertions(+), 4 deletions(-)
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
diff --git a/vcl/source/app/settings.cxx b/vcl/source/app/settings.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
3a3da35 |
index 9ef9fd2..d6f6300 100644
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
--- a/vcl/source/app/settings.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+++ b/vcl/source/app/settings.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
3a3da35 |
@@ -1935,7 +1935,7 @@ bool
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
StyleSettings::GetDockingFloatsSupported()
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
{
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
ImplSVData* pSVData = ImplGetSVData();
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
- return pSVData->maNWFData.mbDockingFloatsSupported;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+ return pSVData->maNWFData.mbCanDetermineWindowPosition;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
}
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
void
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
3a3da35 |
index 77735391..24ffcdd 100644
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
3a3da35 |
@@ -2772,7 +2772,9 @@ gboolean GtkSalFrame::signalMotion( GtkWidget*, GdkEventMotion* pEvent, gpointer
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
{
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
pThis->maGeometry.nX = frame_x;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
pThis->maGeometry.nY = frame_y;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
- pThis->CallCallbackExc(SalEvent::Move, nullptr);
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+ ImplSVData* pSVData = ImplGetSVData();
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+ if (pSVData->maNWFData.mbCanDetermineWindowPosition)
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+ pThis->CallCallbackExc(SalEvent::Move, nullptr);
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
}
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
if( ! aDel.isDeleted() )
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
@@ -2894,7 +2896,11 @@ gboolean GtkSalFrame::signalConfigure(GtkWidget*, GdkEventConfigure* pEvent, gpo
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
pThis->updateScreenNumber();
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
if (bMoved)
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
- pThis->CallCallbackExc(SalEvent::Move, nullptr);
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+ {
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+ ImplSVData* pSVData = ImplGetSVData();
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+ if (pSVData->maNWFData.mbCanDetermineWindowPosition)
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+ pThis->CallCallbackExc(SalEvent::Move, nullptr);
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+ }
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
return false;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
}
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
diff --git a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
3a3da35 |
index 091a615..55ebc71 100644
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
--- a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+++ b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
3a3da35 |
@@ -2330,7 +2330,7 @@ void GtkData::initNWF()
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
//and floating dockable toolbars
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
GdkDisplay *pDisplay = gdk_display_get_default();
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
if (GDK_IS_WAYLAND_DISPLAY(pDisplay))
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
- pSVData->maNWFData.mbDockingFloatsSupported = false;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
+ pSVData->maNWFData.mbCanDetermineWindowPosition = false;
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
#endif
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
}
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
--
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
2.9.3
|
|
![](https://seccdn.libravatar.org/avatar/4c471deb53ad44b176d1794c9545759c8f195b2b4acac0ed10a17e17c205a17f?s=16&d=retro) |
877b95c |
|