diff --git a/0001-impress-constantly-trying-to-create-an-internal-Side.patch b/0001-impress-constantly-trying-to-create-an-internal-Side.patch new file mode 100644 index 0000000..83b5373 --- /dev/null +++ b/0001-impress-constantly-trying-to-create-an-internal-Side.patch @@ -0,0 +1,60 @@ +From f090aa14bc07dccf58b47f466dda00ff2e302a10 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= +Date: Wed, 15 Nov 2017 15:01:33 +0000 +Subject: [PATCH] impress constantly trying to create an internal SidebarView +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +I think since the sidebar was integrated that this is dead +code belonging to the sidebars impress-only ancestor + +Nothing creates the SidebarView[1], so attempt fails, a failed attempt +is scheduled in to try again on a configuration update timer + +configuration update timer fails to load missing SidebarView +but broadcasts configuration update on each attemp + +when the presenter console gets a configuration update it +refreshes its ui by loading the current slide + +if the current slide has notes and those notes are long enough +to be scrolled and the user has scrolled to the end, then when the +slide is reloaded the notes are at the top again. + +So presenter console notes scroll to the top after 5 seconds because +the configuration update fired, because the previous configuration +update didn't work. + +This is old lady that swallowed a fly level stuff + +[1] and I think its a typo here anyway and msSidebarViewURL should have +been msSidebarPaneURL + +Change-Id: Ibfff16bb1092a49a8a54ca9697b5dc3819448af3 +Reviewed-on: https://gerrit.libreoffice.org/44766 +Tested-by: Jenkins +Reviewed-by: Caolán McNamara +Tested-by: Caolán McNamara +(cherry picked from commit ee82c5b96898bb73f5df6fdda7da1f04c3c375cc) +--- + sd/source/ui/framework/module/ImpressModule.cxx | 3 --- + 1 file changed, 3 deletions(-) + +diff --git a/sd/source/ui/framework/module/ImpressModule.cxx b/sd/source/ui/framework/module/ImpressModule.cxx +index 2c240d8..24e6a8c 100644 +--- a/sd/source/ui/framework/module/ImpressModule.cxx ++++ b/sd/source/ui/framework/module/ImpressModule.cxx +@@ -43,9 +43,6 @@ void ImpressModule::Initialize (Reference& rxController) + new SlideSorterModule( + rxController, + FrameworkHelper::msLeftImpressPaneURL); +- new ToolPanelModule( +- rxController, +- FrameworkHelper::msSidebarViewURL); + new ToolBarModule(rxController); + new ShellStackGuard(rxController); + } +-- +2.9.5 + diff --git a/libreoffice.spec b/libreoffice.spec index 310dd2a..ba87cbd 100644 --- a/libreoffice.spec +++ b/libreoffice.spec @@ -249,6 +249,7 @@ Patch4: 0002-consider-field-marks-as-text-for-auto-quotes.patch Patch5: 0001-gtk3-only-for-3.20.patch Patch6: 0001-Improve-resizing-chevrons-so-the-control-point-is-a-.patch Patch7: 0001-Resolves-tdf-42873-videos-in-presenter-console-mispl.patch +Patch8: 0001-impress-constantly-trying-to-create-an-internal-Side.patch %if 0%{?rhel} # not upstreamed