diff --git libselinux-2.3/Makefile libselinux-2.3/Makefile index 6142b60..bdf9de8 100644 --- libselinux-2.3/Makefile +++ libselinux-2.3/Makefile @@ -1,4 +1,4 @@ -SUBDIRS = src include utils man +SUBDIRS = src include utils man golang DISABLE_AVC ?= n DISABLE_SETRANS ?= n diff --git libselinux-2.3/golang/Makefile libselinux-2.3/golang/Makefile new file mode 100644 index 0000000..b75677b --- /dev/null +++ libselinux-2.3/golang/Makefile @@ -0,0 +1,22 @@ +# Installation directories. +PREFIX ?= $(DESTDIR)/usr +LIBDIR ?= $(DESTDIR)/usr/lib +GODIR ?= $(LIBDIR)/golang/src/pkg/github.com/selinux +all: + +install: + [ -d $(GODIR) ] || mkdir -p $(GODIR) + install -m 644 selinux.go $(GODIR) + +test: + @mkdir selinux + @cp selinux.go selinux + GOPATH=$(pwd) go run test.go + @rm -rf selinux + +clean: + @rm -f *~ + @rm -rf selinux +indent: + +relabel: diff --git libselinux-2.3/golang/selinux.go libselinux-2.3/golang/selinux.go new file mode 100644 index 0000000..34bf6bb --- /dev/null +++ libselinux-2.3/golang/selinux.go @@ -0,0 +1,412 @@ +package selinux + +/* + The selinux package is a go bindings to libselinux required to add selinux + support to docker. + + Author Dan Walsh + + Used some ideas/code from the go-ini packages https://github.com/vaughan0 + By Vaughan Newton +*/ + +// #cgo pkg-config: libselinux +// #include +// #include +import "C" +import ( + "bufio" + "crypto/rand" + "encoding/binary" + "fmt" + "io" + "os" + "path" + "path/filepath" + "regexp" + "strings" + "unsafe" +) + +var ( + assignRegex = regexp.MustCompile(`^([^=]+)=(.*)$`) + mcsList = make(map[string]bool) +) + +func Matchpathcon(path string, mode os.FileMode) (string, error) { + var con C.security_context_t + var scon string + rc, err := C.matchpathcon(C.CString(path), C.mode_t(mode), &con) + if rc == 0 { + scon = C.GoString(con) + C.free(unsafe.Pointer(con)) + } + return scon, err +} + +func Setfilecon(path, scon string) (int, error) { + rc, err := C.lsetfilecon(C.CString(path), C.CString(scon)) + return int(rc), err +} + +func Getfilecon(path string) (string, error) { + var scon C.security_context_t + var fcon string + rc, err := C.lgetfilecon(C.CString(path), &scon) + if rc >= 0 { + fcon = C.GoString(scon) + err = nil + } + return fcon, err +} + +func Setfscreatecon(scon string) (int, error) { + var ( + rc C.int + err error + ) + if scon != "" { + rc, err = C.setfscreatecon(C.CString(scon)) + } else { + rc, err = C.setfscreatecon(nil) + } + return int(rc), err +} + +func Getfscreatecon() (string, error) { + var scon C.security_context_t + var fcon string + rc, err := C.getfscreatecon(&scon) + if rc >= 0 { + fcon = C.GoString(scon) + err = nil + C.freecon(scon) + } + return fcon, err +} + +func Getcon() string { + var pcon C.security_context_t + C.getcon(&pcon) + scon := C.GoString(pcon) + C.freecon(pcon) + return scon +} + +func Getpidcon(pid int) (string, error) { + var pcon C.security_context_t + var scon string + rc, err := C.getpidcon(C.pid_t(pid), &pcon) + if rc >= 0 { + scon = C.GoString(pcon) + C.freecon(pcon) + err = nil + } + return scon, err +} + +func Getpeercon(socket int) (string, error) { + var pcon C.security_context_t + var scon string + rc, err := C.getpeercon(C.int(socket), &pcon) + if rc >= 0 { + scon = C.GoString(pcon) + C.freecon(pcon) + err = nil + } + return scon, err +} + +func Setexeccon(scon string) error { + var val *C.char + if !SelinuxEnabled() { + return nil + } + if scon != "" { + val = C.CString(scon) + } else { + val = nil + } + _, err := C.setexeccon(val) + return err +} + +type Context struct { + con []string +} + +func (c *Context) SetUser(user string) { + c.con[0] = user +} +func (c *Context) GetUser() string { + return c.con[0] +} +func (c *Context) SetRole(role string) { + c.con[1] = role +} +func (c *Context) GetRole() string { + return c.con[1] +} +func (c *Context) SetType(setype string) { + c.con[2] = setype +} +func (c *Context) GetType() string { + return c.con[2] +} +func (c *Context) SetLevel(mls string) { + c.con[3] = mls +} +func (c *Context) GetLevel() string { + return c.con[3] +} +func (c *Context) Get() string { + return strings.Join(c.con, ":") +} +func (c *Context) Set(scon string) { + c.con = strings.SplitN(scon, ":", 4) +} +func NewContext(scon string) Context { + var con Context + con.Set(scon) + return con +} + +func SelinuxEnabled() bool { + b := C.is_selinux_enabled() + if b > 0 { + return true + } + return false +} + +const ( + Enforcing = 1 + Permissive = 0 + Disabled = -1 +) + +func SelinuxGetEnforce() int { + return int(C.security_getenforce()) +} + +func SelinuxGetEnforceMode() int { + var enforce C.int + C.selinux_getenforcemode(&enforce) + return int(enforce) +} + +func mcsAdd(mcs string) { + mcsList[mcs] = true +} + +func mcsDelete(mcs string) { + mcsList[mcs] = false +} + +func mcsExists(mcs string) bool { + return mcsList[mcs] +} + +func IntToMcs(id int, catRange uint32) string { + if (id < 1) || (id > 523776) { + return "" + } + + SETSIZE := int(catRange) + TIER := SETSIZE + + ORD := id + for ORD > TIER { + ORD = ORD - TIER + TIER -= 1 + } + TIER = SETSIZE - TIER + ORD = ORD + TIER + return fmt.Sprintf("s0:c%d,c%d", TIER, ORD) +} + +func uniqMcs(catRange uint32) string { + var n uint32 + var c1, c2 uint32 + var mcs string + for { + binary.Read(rand.Reader, binary.LittleEndian, &n) + c1 = n % catRange + binary.Read(rand.Reader, binary.LittleEndian, &n) + c2 = n % catRange + if c1 == c2 { + continue + } else { + if c1 > c2 { + t := c1 + c1 = c2 + c2 = t + } + } + mcs = fmt.Sprintf("s0:c%d,c%d", c1, c2) + if mcsExists(mcs) { + continue + } + mcsAdd(mcs) + break + } + return mcs +} +func freeContext(processLabel string) { + var scon Context + scon = NewContext(processLabel) + mcsDelete(scon.GetLevel()) +} + +func GetLxcContexts() (processLabel string, fileLabel string) { + var val, key string + var bufin *bufio.Reader + if !SelinuxEnabled() { + return + } + lxcPath := C.GoString(C.selinux_lxc_contexts_path()) + fileLabel = "system_u:object_r:svirt_sandbox_file_t:s0" + processLabel = "system_u:system_r:svirt_lxc_net_t:s0" + + in, err := os.Open(lxcPath) + if err != nil { + goto exit + } + + defer in.Close() + bufin = bufio.NewReader(in) + + for done := false; !done; { + var line string + if line, err = bufin.ReadString('\n'); err != nil { + if err == io.EOF { + done = true + } else { + goto exit + } + } + line = strings.TrimSpace(line) + if len(line) == 0 { + // Skip blank lines + continue + } + if line[0] == ';' || line[0] == '#' { + // Skip comments + continue + } + if groups := assignRegex.FindStringSubmatch(line); groups != nil { + key, val = strings.TrimSpace(groups[1]), strings.TrimSpace(groups[2]) + if key == "process" { + processLabel = strings.Trim(val, "\"") + } + if key == "file" { + fileLabel = strings.Trim(val, "\"") + } + } + } +exit: + var scon Context + mcs := IntToMcs(os.Getpid(), 1024) + scon = NewContext(processLabel) + scon.SetLevel(mcs) + processLabel = scon.Get() + scon = NewContext(fileLabel) + scon.SetLevel(mcs) + fileLabel = scon.Get() + return processLabel, fileLabel +} + +func CopyLevel(src, dest string) (string, error) { + if !SelinuxEnabled() { + return "", nil + } + if src == "" { + return "", nil + } + rc, err := C.security_check_context(C.CString(src)) + if rc != 0 { + return "", err + } + rc, err = C.security_check_context(C.CString(dest)) + if rc != 0 { + return "", err + } + scon := NewContext(src) + tcon := NewContext(dest) + tcon.SetLevel(scon.GetLevel()) + return tcon.Get(), nil +} + +func RestoreCon(fpath string, recurse bool) error { + var flabel string + var err error + var fs os.FileInfo + + if !SelinuxEnabled() { + return nil + } + + if recurse { + var paths []string + var err error + + if paths, err = filepath.Glob(path.Join(fpath, "**", "*")); err != nil { + return fmt.Errorf("Unable to find directory %v: %v", fpath, err) + } + + for _, fpath := range paths { + if err = RestoreCon(fpath, false); err != nil { + return fmt.Errorf("Unable to restore selinux context for %v: %v", fpath, err) + } + } + return nil + } + if fs, err = os.Stat(fpath); err != nil { + return fmt.Errorf("Unable stat %v: %v", fpath, err) + } + + if flabel, err = Matchpathcon(fpath, fs.Mode()); flabel == "" { + return fmt.Errorf("Unable to get context for %v: %v", fpath, err) + } + + if rc, err := Setfilecon(fpath, flabel); rc != 0 { + return fmt.Errorf("Unable to set selinux context for %v: %v", fpath, err) + } + + return nil +} + +func Test() { + var plabel, flabel string + if !SelinuxEnabled() { + return + } + + plabel, flabel = GetLxcContexts() + fmt.Println(plabel) + fmt.Println(flabel) + freeContext(plabel) + plabel, flabel = GetLxcContexts() + fmt.Println(plabel) + fmt.Println(flabel) + freeContext(plabel) + if SelinuxEnabled() { + fmt.Println("Enabled") + } else { + fmt.Println("Disabled") + } + fmt.Println("getenforce ", SelinuxGetEnforce()) + fmt.Println("getenforcemode ", SelinuxGetEnforceMode()) + flabel, _ = Matchpathcon("/home/dwalsh/.emacs", 0) + fmt.Println(flabel) + pid := os.Getpid() + fmt.Printf("PID:%d MCS:%s\n", pid, IntToMcs(pid, 1023)) + fmt.Println(Getcon()) + fmt.Println(Getfilecon("/etc/passwd")) + fmt.Println(Getpidcon(1)) + Setfscreatecon("unconfined_u:unconfined_r:unconfined_t:s0") + fmt.Println(Getfscreatecon()) + Setfscreatecon("") + fmt.Println(Getfscreatecon()) + fmt.Println(Getpidcon(1)) +} diff --git libselinux-2.3/golang/test.go libselinux-2.3/golang/test.go new file mode 100644 index 0000000..fed6de8 --- /dev/null +++ libselinux-2.3/golang/test.go @@ -0,0 +1,9 @@ +package main + +import ( + "./selinux" +) + +func main() { + selinux.Test() +} diff --git libselinux-2.3/include/selinux/selinux.h libselinux-2.3/include/selinux/selinux.h index d0eb5c6..4beb170 100644 --- libselinux-2.3/include/selinux/selinux.h +++ libselinux-2.3/include/selinux/selinux.h @@ -543,6 +543,7 @@ extern const char *selinux_virtual_image_context_path(void); extern const char *selinux_lxc_contexts_path(void); extern const char *selinux_x_context_path(void); extern const char *selinux_sepgsql_context_path(void); +extern const char *selinux_openssh_contexts_path(void); extern const char *selinux_systemd_contexts_path(void); extern const char *selinux_contexts_path(void); extern const char *selinux_securetty_types_path(void); diff --git libselinux-2.3/man/man3/getfscreatecon.3 libselinux-2.3/man/man3/getfscreatecon.3 index e348d3b..8cc4df5 100644 --- libselinux-2.3/man/man3/getfscreatecon.3 +++ libselinux-2.3/man/man3/getfscreatecon.3 @@ -49,6 +49,11 @@ Signal handlers that perform a must take care to save, reset, and restore the fscreate context to avoid unexpected behavior. . + +.br +.B Note: +Contexts are thread specific. + .SH "RETURN VALUE" On error \-1 is returned. On success 0 is returned. diff --git libselinux-2.3/man/man3/getkeycreatecon.3 libselinux-2.3/man/man3/getkeycreatecon.3 index 4d70f10..b51008d 100644 --- libselinux-2.3/man/man3/getkeycreatecon.3 +++ libselinux-2.3/man/man3/getkeycreatecon.3 @@ -48,6 +48,10 @@ Signal handlers that perform a .BR setkeycreatecon () must take care to save, reset, and restore the keycreate context to avoid unexpected behavior. + +.br +.B Note: +Contexts are thread specific. . .SH "RETURN VALUE" On error \-1 is returned. diff --git libselinux-2.3/man/man3/getsockcreatecon.3 libselinux-2.3/man/man3/getsockcreatecon.3 index 4dd8f30..26086d9 100644 --- libselinux-2.3/man/man3/getsockcreatecon.3 +++ libselinux-2.3/man/man3/getsockcreatecon.3 @@ -49,6 +49,11 @@ Signal handlers that perform a must take care to save, reset, and restore the sockcreate context to avoid unexpected behavior. . + +.br +.B Note: +Contexts are thread specific. + .SH "RETURN VALUE" On error \-1 is returned. On success 0 is returned. diff --git libselinux-2.3/man/man3/matchpathcon.3 libselinux-2.3/man/man3/matchpathcon.3 index 1bc7ba1..177f15d 100644 --- libselinux-2.3/man/man3/matchpathcon.3 +++ libselinux-2.3/man/man3/matchpathcon.3 @@ -7,7 +7,7 @@ matchpathcon, matchpathcon_index \- get the default SELinux security context for .sp .BI "int matchpathcon_init(const char *" path ");" .sp -.BI "int matchpathcon_init_prefix(const char *" path ", const char *" subset ");" +.BI "int matchpathcon_init_prefix(const char *" path ", const char *" prefix ");" .sp .BI "int matchpathcon_fini(void);" .sp @@ -16,6 +16,24 @@ matchpathcon, matchpathcon_index \- get the default SELinux security context for .BI "int matchpathcon_index(const char *" name ", mode_t " mode ", char **" con ");" . .SH "DESCRIPTION" + +This family of functions is deprecated. For new code, please use +.BR selabel_open (3) +with the +.B SELABEL_CTX_FILE +backend in place of +.BR matchpathcon_init (), +use +.BR selabel_close (3) +in place of +.BR matchpathcon_fini (), +and use +.BR selabel_lookup (3) +in place of +.BR matchpathcon (). + +The remaining description below is for the legacy interface. + .BR matchpathcon_init () loads the file contexts configuration specified by .I path @@ -41,9 +59,16 @@ customizations. .BR matchpathcon_init_prefix () is the same as .BR matchpathcon_init () -but only loads entries with regular expressions that have stems prefixed -by -.I \%prefix. +but only loads entries with regular expressions whose first pathname +component is a prefix of +.I \%prefix +, e.g. pass "/dev" if you only intend to call +.BR matchpathcon () +with pathnames beginning with /dev. +However, this optimization is no longer necessary due to the use of +.I file_contexts.bin +files with precompiled regular expressions, so use of this interface +is deprecated. .BR matchpathcon_fini () frees the memory allocated by a prior call to @@ -54,7 +79,17 @@ calls, or to free memory when finished using .BR matchpathcon (). .BR matchpathcon () -matches the specified pathname and mode against the file contexts +matches the specified +.I pathname, +after transformation via +.BR realpath (3) +excepting any final symbolic link component if S_IFLNK was +specified as the +.I mode, +and +.I mode +against the +.I file contexts configuration and sets the security context .I con to refer to the diff --git libselinux-2.3/man/man5/selabel_file.5 libselinux-2.3/man/man5/selabel_file.5 index 79eca95..e738824 100644 --- libselinux-2.3/man/man5/selabel_file.5 +++ libselinux-2.3/man/man5/selabel_file.5 @@ -55,7 +55,9 @@ A non-null value for this option specifies a path to a file that will be opened A non-null value for this option indicates that any local customizations to the file contexts mapping should be ignored. .TP .B SELABEL_OPT_SUBSET -A non-null value for this option is interpreted as a path prefix, for example "/etc". Only file context specifications starting with the given prefix are loaded. This may increase lookup performance, however any attempt to look up a path not starting with the given prefix will fail. +A non-null value for this option is interpreted as a path prefix, for example "/etc". Only file context specifications with starting with a first component that prefix matches the given prefix are loaded. This may increase lookup performance, however any attempt to look up a path not starting with the given prefix may fail. This optimization is no longer required due to the use of +.I file_contexts.bin +files and is deprecated. .RE . .SH "FILES" @@ -206,7 +208,7 @@ component with \fI/var/www\fR, therefore the path used is: If contexts are to be validated, then the global option \fBSELABEL_OPT_VALIDATE\fR must be set before calling \fBselabel_open\fR(3). If this is not set, then it is possible for an invalid context to be returned. .IP "2." 4 If the size of file contexts series of files contain many entries, then \fBselabel_open\fR(3) may have a delay as it reads in the files, and if -requested validates the entries. If possible use the \fBSELABEL_OPT_SUBSET\fR option to reduce the number of entries processed. +requested validates the entries. .IP "3." 4 Depending on the version of SELinux it is possible that a \fIfile_contexts.template\fR file may also be present, however this is now deprecated. .br diff --git libselinux-2.3/man/man8/selinux.8 libselinux-2.3/man/man8/selinux.8 index e89b1ef..fd20363 100644 --- libselinux-2.3/man/man8/selinux.8 +++ libselinux-2.3/man/man8/selinux.8 @@ -74,7 +74,7 @@ The best way to relabel the file system is to create the flag file and reboot. .BR system\-config\-selinux , also has this capability. The -.BR restorcon / fixfiles +.BR restorecon / fixfiles commands are also available for relabeling files. . .SH AUTHOR @@ -91,11 +91,13 @@ This manual page was written by Dan Walsh . .BR sepolicy (8), .BR system-config-selinux (8), .BR togglesebool (8), -.BR restorecon (8), .BR fixfiles (8), +.BR restorecon (8), .BR setfiles (8), .BR semanage (8), -.BR sepolicy(8) +.BR sepolicy(8), +.BR seinfo(8), +.BR sesearch(8) Every confined service on the system has a man page in the following format: .br diff --git libselinux-2.3/src/Makefile libselinux-2.3/src/Makefile index 4d07ba6..0a34d9b 100644 --- libselinux-2.3/src/Makefile +++ libselinux-2.3/src/Makefile @@ -59,7 +59,7 @@ CFLAGS ?= -O -Wall -W -Wundef -Wformat-y2k -Wformat-security -Winit-self -Wmissi -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes \ -Wmissing-declarations -Wmissing-noreturn -Wmissing-format-attribute \ -Wredundant-decls -Wnested-externs -Winline -Winvalid-pch -Wvolatile-register-var \ - -Wdisabled-optimization -Wbuiltin-macro-redefined -Wmudflap -Wpacked-bitfield-compat \ + -Wdisabled-optimization -Wbuiltin-macro-redefined -Wpacked-bitfield-compat \ -Wsync-nand -Wattributes -Wcoverage-mismatch -Wmultichar -Wcpp \ -Wdeprecated-declarations -Wdiv-by-zero -Wdouble-promotion -Wendif-labels -Wextra \ -Wformat-contains-nul -Wformat-extra-args -Wformat-zero-length -Wformat=2 -Wmultichar \ diff --git libselinux-2.3/src/avc.c libselinux-2.3/src/avc.c index 2bd7d13..b1ec57f 100644 --- libselinux-2.3/src/avc.c +++ libselinux-2.3/src/avc.c @@ -288,7 +288,7 @@ void avc_av_stats(void) avc_release_lock(avc_lock); - avc_log(SELINUX_INFO, "%s: %d AV entries and %d/%d buckets used, " + avc_log(SELINUX_INFO, "%s: %u AV entries and %d/%d buckets used, " "longest chain length %d\n", avc_prefix, avc_cache.active_nodes, slots_used, AVC_CACHE_SLOTS, max_chain_len); @@ -471,7 +471,7 @@ static int avc_insert(security_id_t ssid, security_id_t tsid, if (ae->avd.seqno < avc_cache.latest_notif) { avc_log(SELINUX_WARNING, - "%s: seqno %d < latest_notif %d\n", avc_prefix, + "%s: seqno %u < latest_notif %u\n", avc_prefix, ae->avd.seqno, avc_cache.latest_notif); errno = EAGAIN; rc = -1; diff --git libselinux-2.3/src/avc_internal.c libselinux-2.3/src/avc_internal.c index f735e73..be94857 100644 --- libselinux-2.3/src/avc_internal.c +++ libselinux-2.3/src/avc_internal.c @@ -125,14 +125,14 @@ static int avc_netlink_receive(char *buf, unsigned buflen, int blocking) if (nladdrlen != sizeof nladdr) { avc_log(SELINUX_WARNING, - "%s: warning: netlink address truncated, len %d?\n", + "%s: warning: netlink address truncated, len %u?\n", avc_prefix, nladdrlen); return -1; } if (nladdr.nl_pid) { avc_log(SELINUX_WARNING, - "%s: warning: received spoofed netlink packet from: %d\n", + "%s: warning: received spoofed netlink packet from: %u\n", avc_prefix, nladdr.nl_pid); return -1; } @@ -197,7 +197,7 @@ static int avc_netlink_process(char *buf) case SELNL_MSG_POLICYLOAD:{ struct selnl_msg_policyload *msg = NLMSG_DATA(nlh); avc_log(SELINUX_INFO, - "%s: received policyload notice (seqno=%d)\n", + "%s: received policyload notice (seqno=%u)\n", avc_prefix, msg->seqno); rc = avc_ss_reset(msg->seqno); if (rc < 0) { diff --git libselinux-2.3/src/avc_sidtab.c libselinux-2.3/src/avc_sidtab.c index 52f21df..c775430 100644 --- libselinux-2.3/src/avc_sidtab.c +++ libselinux-2.3/src/avc_sidtab.c @@ -81,6 +81,11 @@ sidtab_context_to_sid(struct sidtab *s, int hvalue, rc = 0; struct sidtab_node *cur; + if (! ctx) { + errno=EINVAL; + return -1; + } + *sid = NULL; hvalue = sidtab_hash(ctx); @@ -124,7 +129,7 @@ void sidtab_sid_stats(struct sidtab *h, char *buf, int buflen) } snprintf(buf, buflen, - "%s: %d SID entries and %d/%d buckets used, longest " + "%s: %u SID entries and %d/%d buckets used, longest " "chain length %d\n", avc_prefix, h->nel, slots_used, SIDTAB_SIZE, max_chain_len); } diff --git libselinux-2.3/src/canonicalize_context.c libselinux-2.3/src/canonicalize_context.c index 7cf3139..364a746 100644 --- libselinux-2.3/src/canonicalize_context.c +++ libselinux-2.3/src/canonicalize_context.c @@ -17,6 +17,11 @@ int security_canonicalize_context_raw(const char * con, size_t size; int fd, ret; + if (! con) { + errno=EINVAL; + return -1; + } + if (!selinux_mnt) { errno = ENOENT; return -1; diff --git libselinux-2.3/src/check_context.c libselinux-2.3/src/check_context.c index 52063fa..234749c 100644 --- libselinux-2.3/src/check_context.c +++ libselinux-2.3/src/check_context.c @@ -14,6 +14,11 @@ int security_check_context_raw(const char * con) char path[PATH_MAX]; int fd, ret; + if (! con) { + errno=EINVAL; + return -1; + } + if (!selinux_mnt) { errno = ENOENT; return -1; diff --git libselinux-2.3/src/compute_av.c libselinux-2.3/src/compute_av.c index 937e5c3..35ace7f 100644 --- libselinux-2.3/src/compute_av.c +++ libselinux-2.3/src/compute_av.c @@ -26,6 +26,11 @@ int security_compute_av_flags_raw(const char * scon, return -1; } + if ((! scon) || (! tcon)) { + errno=EINVAL; + return -1; + } + snprintf(path, sizeof path, "%s/access", selinux_mnt); fd = open(path, O_RDWR); if (fd < 0) diff --git libselinux-2.3/src/compute_create.c libselinux-2.3/src/compute_create.c index 9559d42..14a65d1 100644 --- libselinux-2.3/src/compute_create.c +++ libselinux-2.3/src/compute_create.c @@ -64,6 +64,11 @@ int security_compute_create_name_raw(const char * scon, return -1; } + if ((! scon) || (! tcon)) { + errno=EINVAL; + return -1; + } + snprintf(path, sizeof path, "%s/create", selinux_mnt); fd = open(path, O_RDWR); if (fd < 0) diff --git libselinux-2.3/src/compute_member.c libselinux-2.3/src/compute_member.c index 1fc7e41..065d996 100644 --- libselinux-2.3/src/compute_member.c +++ libselinux-2.3/src/compute_member.c @@ -25,6 +25,11 @@ int security_compute_member_raw(const char * scon, return -1; } + if ((! scon) || (! tcon)) { + errno=EINVAL; + return -1; + } + snprintf(path, sizeof path, "%s/member", selinux_mnt); fd = open(path, O_RDWR); if (fd < 0) diff --git libselinux-2.3/src/compute_relabel.c libselinux-2.3/src/compute_relabel.c index 4615aee..cc77f36 100644 --- libselinux-2.3/src/compute_relabel.c +++ libselinux-2.3/src/compute_relabel.c @@ -25,6 +25,11 @@ int security_compute_relabel_raw(const char * scon, return -1; } + if ((! scon) || (! tcon)) { + errno=EINVAL; + return -1; + } + snprintf(path, sizeof path, "%s/relabel", selinux_mnt); fd = open(path, O_RDWR); if (fd < 0) diff --git libselinux-2.3/src/compute_user.c libselinux-2.3/src/compute_user.c index b37c5d3..7703c26 100644 --- libselinux-2.3/src/compute_user.c +++ libselinux-2.3/src/compute_user.c @@ -24,6 +24,11 @@ int security_compute_user_raw(const char * scon, return -1; } + if (! scon) { + errno=EINVAL; + return -1; + } + snprintf(path, sizeof path, "%s/user", selinux_mnt); fd = open(path, O_RDWR); if (fd < 0) diff --git libselinux-2.3/src/enabled.c libselinux-2.3/src/enabled.c index 5c252dd..bb659a9 100644 --- libselinux-2.3/src/enabled.c +++ libselinux-2.3/src/enabled.c @@ -11,26 +11,14 @@ int is_selinux_enabled(void) { - int enabled = 0; - char * con; - /* init_selinuxmnt() gets called before this function. We * will assume that if a selinux file system is mounted, then * selinux is enabled. */ - if (selinux_mnt) { - - /* Since a file system is mounted, we consider selinux - * enabled. If getcon_raw fails, selinux is still enabled. - * We only consider it disabled if no policy is loaded. */ - enabled = 1; - if (getcon_raw(&con) == 0) { - if (!strcmp(con, "kernel")) - enabled = 0; - freecon(con); - } - } - - return enabled; +#ifdef ANDROID + return (selinux_mnt ? 1 : 0); +#else + return (selinux_mnt && has_selinux_config); +#endif } hidden_def(is_selinux_enabled) diff --git libselinux-2.3/src/file_path_suffixes.h libselinux-2.3/src/file_path_suffixes.h index 3c92424..d1f9b48 100644 --- libselinux-2.3/src/file_path_suffixes.h +++ libselinux-2.3/src/file_path_suffixes.h @@ -23,6 +23,7 @@ S_(BINPOLICY, "/policy/policy") S_(VIRTUAL_DOMAIN, "/contexts/virtual_domain_context") S_(VIRTUAL_IMAGE, "/contexts/virtual_image_context") S_(LXC_CONTEXTS, "/contexts/lxc_contexts") + S_(OPENSSH_CONTEXTS, "/contexts/openssh_contexts") S_(SYSTEMD_CONTEXTS, "/contexts/systemd_contexts") S_(FILE_CONTEXT_SUBS, "/contexts/files/file_contexts.subs") S_(FILE_CONTEXT_SUBS_DIST, "/contexts/files/file_contexts.subs_dist") diff --git libselinux-2.3/src/fsetfilecon.c libselinux-2.3/src/fsetfilecon.c index 52707d0..0cbe12d 100644 --- libselinux-2.3/src/fsetfilecon.c +++ libselinux-2.3/src/fsetfilecon.c @@ -9,8 +9,12 @@ int fsetfilecon_raw(int fd, const char * context) { - int rc = fsetxattr(fd, XATTR_NAME_SELINUX, context, strlen(context) + 1, - 0); + int rc; + if (! context) { + errno=EINVAL; + return -1; + } + rc = fsetxattr(fd, XATTR_NAME_SELINUX, context, strlen(context) + 1, 0); if (rc < 0 && errno == ENOTSUP) { char * ccontext = NULL; int err = errno; diff --git libselinux-2.3/src/init.c libselinux-2.3/src/init.c index 6d1ef33..3c687a2 100644 --- libselinux-2.3/src/init.c +++ libselinux-2.3/src/init.c @@ -21,6 +21,8 @@ char *selinux_mnt = NULL; int selinux_page_size = 0; int obj_class_compat = 1; +int has_selinux_config = 0; + /* Verify the mount point for selinux file system has a selinuxfs. If the file system: * Exist, @@ -151,6 +153,9 @@ static void init_lib(void) { selinux_page_size = sysconf(_SC_PAGE_SIZE); init_selinuxmnt(); +#ifndef ANDROID + has_selinux_config = (access(SELINUXCONFIG, F_OK) == 0); +#endif } static void fini_lib(void) __attribute__ ((destructor)); diff --git libselinux-2.3/src/label_android_property.c libselinux-2.3/src/label_android_property.c index b00eb07..5e1b76e 100644 --- libselinux-2.3/src/label_android_property.c +++ libselinux-2.3/src/label_android_property.c @@ -101,7 +101,7 @@ static int process_line(struct selabel_handle *rec, items = sscanf(line_buf, "%255s %255s", prop, context); if (items != 2) { selinux_log(SELINUX_WARNING, - "%s: line %d is missing fields, skipping\n", path, + "%s: line %u is missing fields, skipping\n", path, lineno); return 0; } @@ -111,7 +111,7 @@ static int process_line(struct selabel_handle *rec, spec_arr[nspec].property_key = strdup(prop); if (!spec_arr[nspec].property_key) { selinux_log(SELINUX_WARNING, - "%s: out of memory at line %d on prop %s\n", + "%s: out of memory at line %u on prop %s\n", path, lineno, prop); return -1; @@ -120,7 +120,7 @@ static int process_line(struct selabel_handle *rec, spec_arr[nspec].lr.ctx_raw = strdup(context); if (!spec_arr[nspec].lr.ctx_raw) { selinux_log(SELINUX_WARNING, - "%s: out of memory at line %d on context %s\n", + "%s: out of memory at line %u on context %s\n", path, lineno, context); return -1; } diff --git libselinux-2.3/src/label_db.c libselinux-2.3/src/label_db.c index ab0696a..00503a5 100644 --- libselinux-2.3/src/label_db.c +++ libselinux-2.3/src/label_db.c @@ -105,12 +105,12 @@ process_line(const char *path, char *line_buf, unsigned int line_num, * */ type = key = context = temp = NULL; - items = sscanf(line_buf, "%as %as %as %as", + items = sscanf(line_buf, "%ms %ms %ms %ms", &type, &key, &context, &temp); if (items != 3) { if (items > 0) selinux_log(SELINUX_WARNING, - "%s: line %d has invalid format, skipped", + "%s: line %u has invalid format, skipped", path, line_num); goto skip; } @@ -142,7 +142,7 @@ process_line(const char *path, char *line_buf, unsigned int line_num, spec->type = SELABEL_DB_LANGUAGE; else { selinux_log(SELINUX_WARNING, - "%s: line %d has invalid object type %s\n", + "%s: line %u has invalid object type %s\n", path, line_num, type); goto skip; } diff --git libselinux-2.3/src/label_file.c libselinux-2.3/src/label_file.c index 615aea9..c01991c 100644 --- libselinux-2.3/src/label_file.c +++ libselinux-2.3/src/label_file.c @@ -170,10 +170,10 @@ static int process_line(struct selabel_handle *rec, /* Skip comment lines and empty lines. */ if (*buf_p == '#' || *buf_p == 0) return 0; - items = sscanf(line_buf, "%as %as %as", ®ex, &type, &context); + items = sscanf(line_buf, "%ms %ms %ms", ®ex, &type, &context); if (items < 2) { COMPAT_LOG(SELINUX_WARNING, - "%s: line %d is missing fields, skipping\n", path, + "%s: line %u is missing fields, skipping\n", path, lineno); if (items == 1) free(regex); @@ -204,7 +204,7 @@ static int process_line(struct selabel_handle *rec, spec_arr[nspec].stem_id = find_stem_from_spec(data, regex); spec_arr[nspec].regex_str = regex; if (rec->validating && compile_regex(data, &spec_arr[nspec], &errbuf)) { - COMPAT_LOG(SELINUX_WARNING, "%s: line %d has invalid regex %s: %s\n", + COMPAT_LOG(SELINUX_WARNING, "%s: line %u has invalid regex %s: %s\n", path, lineno, regex, (errbuf ? errbuf : "out of memory")); } @@ -214,7 +214,7 @@ static int process_line(struct selabel_handle *rec, if (type) { mode_t mode = string_to_mode(type); if (mode == -1) { - COMPAT_LOG(SELINUX_WARNING, "%s: line %d has invalid file type %s\n", + COMPAT_LOG(SELINUX_WARNING, "%s: line %u has invalid file type %s\n", path, lineno, type); mode = 0; } diff --git libselinux-2.3/src/label_media.c libselinux-2.3/src/label_media.c index 227785f..a09486b 100644 --- libselinux-2.3/src/label_media.c +++ libselinux-2.3/src/label_media.c @@ -44,10 +44,10 @@ static int process_line(const char *path, char *line_buf, int pass, /* Skip comment lines and empty lines. */ if (*buf_p == '#' || *buf_p == 0) return 0; - items = sscanf(line_buf, "%as %as ", &key, &context); + items = sscanf(line_buf, "%ms %ms ", &key, &context); if (items < 2) { selinux_log(SELINUX_WARNING, - "%s: line %d is missing fields, skipping\n", path, + "%s: line %u is missing fields, skipping\n", path, lineno); if (items == 1) free(key); diff --git libselinux-2.3/src/label_x.c libselinux-2.3/src/label_x.c index 896ef02..8435b76 100644 --- libselinux-2.3/src/label_x.c +++ libselinux-2.3/src/label_x.c @@ -46,10 +46,10 @@ static int process_line(const char *path, char *line_buf, int pass, /* Skip comment lines and empty lines. */ if (*buf_p == '#' || *buf_p == 0) return 0; - items = sscanf(line_buf, "%as %as %as ", &type, &key, &context); + items = sscanf(line_buf, "%ms %ms %ms ", &type, &key, &context); if (items < 3) { selinux_log(SELINUX_WARNING, - "%s: line %d is missing fields, skipping\n", path, + "%s: line %u is missing fields, skipping\n", path, lineno); if (items > 0) free(type); @@ -76,7 +76,7 @@ static int process_line(const char *path, char *line_buf, int pass, data->spec_arr[data->nspec].type = SELABEL_X_POLYSELN; else { selinux_log(SELINUX_WARNING, - "%s: line %d has invalid object type %s\n", + "%s: line %u has invalid object type %s\n", path, lineno, type); return 0; } diff --git libselinux-2.3/src/lsetfilecon.c libselinux-2.3/src/lsetfilecon.c index 1d3b28a..ea6d70b 100644 --- libselinux-2.3/src/lsetfilecon.c +++ libselinux-2.3/src/lsetfilecon.c @@ -9,8 +9,13 @@ int lsetfilecon_raw(const char *path, const char * context) { - int rc = lsetxattr(path, XATTR_NAME_SELINUX, context, strlen(context) + 1, - 0); + int rc; + if (! context) { + errno=EINVAL; + return -1; + } + + rc = lsetxattr(path, XATTR_NAME_SELINUX, context, strlen(context) + 1, 0); if (rc < 0 && errno == ENOTSUP) { char * ccontext = NULL; int err = errno; diff --git libselinux-2.3/src/matchpathcon.c libselinux-2.3/src/matchpathcon.c index 3b96b1d..3868711 100644 --- libselinux-2.3/src/matchpathcon.c +++ libselinux-2.3/src/matchpathcon.c @@ -2,6 +2,7 @@ #include #include #include +#include #include "selinux_internal.h" #include "label_internal.h" #include "callbacks.h" @@ -62,7 +63,7 @@ static void { va_list ap; va_start(ap, fmt); - vfprintf(stderr, fmt, ap); + vsyslog(LOG_ERR, fmt, ap); va_end(ap); } @@ -541,7 +542,7 @@ int compat_validate(struct selabel_handle *rec, if (rc < 0) { if (lineno) { COMPAT_LOG(SELINUX_WARNING, - "%s: line %d has invalid context %s\n", + "%s: line %u has invalid context %s\n", path, lineno, *ctx); } else { COMPAT_LOG(SELINUX_WARNING, diff --git libselinux-2.3/src/selinux_config.c libselinux-2.3/src/selinux_config.c index 30e9dc7..bec5f3b 100644 --- libselinux-2.3/src/selinux_config.c +++ libselinux-2.3/src/selinux_config.c @@ -13,8 +13,6 @@ #include "selinux_internal.h" #include "get_default_type_internal.h" -#define SELINUXDIR "/etc/selinux/" -#define SELINUXCONFIG SELINUXDIR "config" #define SELINUXDEFAULT "targeted" #define SELINUXTYPETAG "SELINUXTYPE=" #define SELINUXTAG "SELINUX=" @@ -50,8 +48,9 @@ #define FILE_CONTEXT_SUBS_DIST 25 #define LXC_CONTEXTS 26 #define BOOLEAN_SUBS 27 -#define SYSTEMD_CONTEXTS 28 -#define NEL 29 +#define OPENSSH_CONTEXTS 28 +#define SYSTEMD_CONTEXTS 29 +#define NEL 30 /* Part of one-time lazy init */ static pthread_once_t once = PTHREAD_ONCE_INIT; @@ -493,6 +492,13 @@ const char *selinux_lxc_contexts_path(void) hidden_def(selinux_lxc_contexts_path) +const char *selinux_openssh_contexts_path(void) +{ + return get_path(OPENSSH_CONTEXTS); +} + +hidden_def(selinux_openssh_contexts_path) + const char *selinux_systemd_contexts_path(void) { return get_path(SYSTEMD_CONTEXTS); diff --git libselinux-2.3/src/selinux_internal.h libselinux-2.3/src/selinux_internal.h index afb2170..9b1ca4d 100644 --- libselinux-2.3/src/selinux_internal.h +++ libselinux-2.3/src/selinux_internal.h @@ -82,6 +82,7 @@ hidden_proto(selinux_mkload_policy) hidden_proto(selinux_customizable_types_path) hidden_proto(selinux_media_context_path) hidden_proto(selinux_x_context_path) + hidden_proto(selinux_openssh_contexts_path) hidden_proto(selinux_sepgsql_context_path) hidden_proto(selinux_systemd_contexts_path) hidden_proto(selinux_path) @@ -137,3 +138,8 @@ extern int selinux_page_size hidden; if (pthread_setspecific != NULL) \ pthread_setspecific(KEY, VALUE); \ } while (0) + +#define SELINUXDIR "/etc/selinux/" +#define SELINUXCONFIG SELINUXDIR "config" + +extern int has_selinux_config hidden; diff --git libselinux-2.3/src/selinuxswig_python.i libselinux-2.3/src/selinuxswig_python.i index ae72246..c9a2341 100644 --- libselinux-2.3/src/selinuxswig_python.i +++ libselinux-2.3/src/selinuxswig_python.i @@ -31,9 +31,9 @@ def restorecon(path, recursive=False): lsetfilecon(path, context) if recursive: - os.path.walk(path, lambda arg, dirname, fnames: - map(restorecon, [os.path.join(dirname, fname) - for fname in fnames]), None) + for root, dirs, files in os.walk(path): + for name in files + dirs: + restorecon(os.path.join(root, name)) def chcon(path, context, recursive=False): """ Set the SELinux context on a given path """ diff --git libselinux-2.3/src/setfilecon.c libselinux-2.3/src/setfilecon.c index d05969c..3f0200e 100644 --- libselinux-2.3/src/setfilecon.c +++ libselinux-2.3/src/setfilecon.c @@ -9,8 +9,12 @@ int setfilecon_raw(const char *path, const char * context) { - int rc = setxattr(path, XATTR_NAME_SELINUX, context, strlen(context) + 1, - 0); + int rc; + if (! context) { + errno=EINVAL; + return -1; + } + rc = setxattr(path, XATTR_NAME_SELINUX, context, strlen(context) + 1, 0); if (rc < 0 && errno == ENOTSUP) { char * ccontext = NULL; int err = errno; diff --git libselinux-2.3/utils/Makefile libselinux-2.3/utils/Makefile index f469924..5499538 100644 --- libselinux-2.3/utils/Makefile +++ libselinux-2.3/utils/Makefile @@ -11,7 +11,7 @@ CFLAGS ?= -O -Wall -W -Wundef -Wformat-y2k -Wformat-security -Winit-self -Wmissi -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes \ -Wmissing-declarations -Wmissing-noreturn -Wmissing-format-attribute \ -Wredundant-decls -Wnested-externs -Winline -Winvalid-pch -Wvolatile-register-var \ - -Wdisabled-optimization -Wbuiltin-macro-redefined -Wmudflap -Wpacked-bitfield-compat \ + -Wdisabled-optimization -Wbuiltin-macro-redefined -Wpacked-bitfield-compat \ -Wsync-nand -Wattributes -Wcoverage-mismatch -Wmultichar -Wcpp \ -Wdeprecated-declarations -Wdiv-by-zero -Wdouble-promotion -Wendif-labels -Wextra \ -Wformat-contains-nul -Wformat-extra-args -Wformat-zero-length -Wformat=2 -Wmultichar \ diff --git libselinux-2.3/utils/sefcontext_compile.c libselinux-2.3/utils/sefcontext_compile.c index 0adc968..fa392d1 100644 --- libselinux-2.3/utils/sefcontext_compile.c +++ libselinux-2.3/utils/sefcontext_compile.c @@ -4,6 +4,9 @@ #include #include #include +#include +#include +#include #include @@ -70,7 +73,7 @@ static int process_file(struct saved_data *data, const char *filename) spec->lr.ctx_raw = context; spec->mode = string_to_mode(mode); if (spec->mode == -1) { - fprintf(stderr, "%s: line %d has invalid file type %s\n", + fprintf(stderr, "%s: line %u has invalid file type %s\n", regex, line_num + 1, mode); spec->mode = 0; } @@ -323,6 +326,7 @@ int main(int argc, char *argv[]) int rc; char *tmp= NULL; int fd; + struct stat buf; if (argc != 2) { fprintf(stderr, "usage: %s input_file\n", argv[0]); @@ -333,6 +337,11 @@ int main(int argc, char *argv[]) path = argv[1]; + if (stat(path, &buf) < 0) { + fprintf(stderr, "Can not stat: %s: %m\n", argv[0]); + exit(EXIT_FAILURE); + } + rc = process_file(&data, path); if (rc < 0) return rc; @@ -352,6 +361,12 @@ int main(int argc, char *argv[]) if (fd < 0) goto err; + rc = fchmod(fd, buf.st_mode); + if (rc < 0) { + perror("fchmod failed to set permission on compiled regexs"); + goto err; + } + rc = write_binary_file(&data, fd); if (rc < 0) diff --git libselinux-2.3/utils/togglesebool.c libselinux-2.3/utils/togglesebool.c index ad0d2a2..309f83b 100644 --- libselinux-2.3/utils/togglesebool.c +++ libselinux-2.3/utils/togglesebool.c @@ -86,7 +86,7 @@ int main(int argc, char **argv) argv[i], pwd->pw_name); else syslog(LOG_NOTICE, - "The %s policy boolean was toggled by uid:%d", + "The %s policy boolean was toggled by uid:%u", argv[i], getuid()); }