diff --git a/Makefile b/Makefile index 6142b60..bdf9de8 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -SUBDIRS = src include utils man +SUBDIRS = src include utils man golang DISABLE_AVC ?= n DISABLE_SETRANS ?= n diff --git a/golang/Makefile b/golang/Makefile new file mode 100644 index 0000000..b75677b --- /dev/null +++ b/golang/Makefile @@ -0,0 +1,22 @@ +# Installation directories. +PREFIX ?= $(DESTDIR)/usr +LIBDIR ?= $(DESTDIR)/usr/lib +GODIR ?= $(LIBDIR)/golang/src/pkg/github.com/selinux +all: + +install: + [ -d $(GODIR) ] || mkdir -p $(GODIR) + install -m 644 selinux.go $(GODIR) + +test: + @mkdir selinux + @cp selinux.go selinux + GOPATH=$(pwd) go run test.go + @rm -rf selinux + +clean: + @rm -f *~ + @rm -rf selinux +indent: + +relabel: diff --git a/golang/selinux.go b/golang/selinux.go new file mode 100644 index 0000000..34bf6bb --- /dev/null +++ b/golang/selinux.go @@ -0,0 +1,412 @@ +package selinux + +/* + The selinux package is a go bindings to libselinux required to add selinux + support to docker. + + Author Dan Walsh + + Used some ideas/code from the go-ini packages https://github.com/vaughan0 + By Vaughan Newton +*/ + +// #cgo pkg-config: libselinux +// #include +// #include +import "C" +import ( + "bufio" + "crypto/rand" + "encoding/binary" + "fmt" + "io" + "os" + "path" + "path/filepath" + "regexp" + "strings" + "unsafe" +) + +var ( + assignRegex = regexp.MustCompile(`^([^=]+)=(.*)$`) + mcsList = make(map[string]bool) +) + +func Matchpathcon(path string, mode os.FileMode) (string, error) { + var con C.security_context_t + var scon string + rc, err := C.matchpathcon(C.CString(path), C.mode_t(mode), &con) + if rc == 0 { + scon = C.GoString(con) + C.free(unsafe.Pointer(con)) + } + return scon, err +} + +func Setfilecon(path, scon string) (int, error) { + rc, err := C.lsetfilecon(C.CString(path), C.CString(scon)) + return int(rc), err +} + +func Getfilecon(path string) (string, error) { + var scon C.security_context_t + var fcon string + rc, err := C.lgetfilecon(C.CString(path), &scon) + if rc >= 0 { + fcon = C.GoString(scon) + err = nil + } + return fcon, err +} + +func Setfscreatecon(scon string) (int, error) { + var ( + rc C.int + err error + ) + if scon != "" { + rc, err = C.setfscreatecon(C.CString(scon)) + } else { + rc, err = C.setfscreatecon(nil) + } + return int(rc), err +} + +func Getfscreatecon() (string, error) { + var scon C.security_context_t + var fcon string + rc, err := C.getfscreatecon(&scon) + if rc >= 0 { + fcon = C.GoString(scon) + err = nil + C.freecon(scon) + } + return fcon, err +} + +func Getcon() string { + var pcon C.security_context_t + C.getcon(&pcon) + scon := C.GoString(pcon) + C.freecon(pcon) + return scon +} + +func Getpidcon(pid int) (string, error) { + var pcon C.security_context_t + var scon string + rc, err := C.getpidcon(C.pid_t(pid), &pcon) + if rc >= 0 { + scon = C.GoString(pcon) + C.freecon(pcon) + err = nil + } + return scon, err +} + +func Getpeercon(socket int) (string, error) { + var pcon C.security_context_t + var scon string + rc, err := C.getpeercon(C.int(socket), &pcon) + if rc >= 0 { + scon = C.GoString(pcon) + C.freecon(pcon) + err = nil + } + return scon, err +} + +func Setexeccon(scon string) error { + var val *C.char + if !SelinuxEnabled() { + return nil + } + if scon != "" { + val = C.CString(scon) + } else { + val = nil + } + _, err := C.setexeccon(val) + return err +} + +type Context struct { + con []string +} + +func (c *Context) SetUser(user string) { + c.con[0] = user +} +func (c *Context) GetUser() string { + return c.con[0] +} +func (c *Context) SetRole(role string) { + c.con[1] = role +} +func (c *Context) GetRole() string { + return c.con[1] +} +func (c *Context) SetType(setype string) { + c.con[2] = setype +} +func (c *Context) GetType() string { + return c.con[2] +} +func (c *Context) SetLevel(mls string) { + c.con[3] = mls +} +func (c *Context) GetLevel() string { + return c.con[3] +} +func (c *Context) Get() string { + return strings.Join(c.con, ":") +} +func (c *Context) Set(scon string) { + c.con = strings.SplitN(scon, ":", 4) +} +func NewContext(scon string) Context { + var con Context + con.Set(scon) + return con +} + +func SelinuxEnabled() bool { + b := C.is_selinux_enabled() + if b > 0 { + return true + } + return false +} + +const ( + Enforcing = 1 + Permissive = 0 + Disabled = -1 +) + +func SelinuxGetEnforce() int { + return int(C.security_getenforce()) +} + +func SelinuxGetEnforceMode() int { + var enforce C.int + C.selinux_getenforcemode(&enforce) + return int(enforce) +} + +func mcsAdd(mcs string) { + mcsList[mcs] = true +} + +func mcsDelete(mcs string) { + mcsList[mcs] = false +} + +func mcsExists(mcs string) bool { + return mcsList[mcs] +} + +func IntToMcs(id int, catRange uint32) string { + if (id < 1) || (id > 523776) { + return "" + } + + SETSIZE := int(catRange) + TIER := SETSIZE + + ORD := id + for ORD > TIER { + ORD = ORD - TIER + TIER -= 1 + } + TIER = SETSIZE - TIER + ORD = ORD + TIER + return fmt.Sprintf("s0:c%d,c%d", TIER, ORD) +} + +func uniqMcs(catRange uint32) string { + var n uint32 + var c1, c2 uint32 + var mcs string + for { + binary.Read(rand.Reader, binary.LittleEndian, &n) + c1 = n % catRange + binary.Read(rand.Reader, binary.LittleEndian, &n) + c2 = n % catRange + if c1 == c2 { + continue + } else { + if c1 > c2 { + t := c1 + c1 = c2 + c2 = t + } + } + mcs = fmt.Sprintf("s0:c%d,c%d", c1, c2) + if mcsExists(mcs) { + continue + } + mcsAdd(mcs) + break + } + return mcs +} +func freeContext(processLabel string) { + var scon Context + scon = NewContext(processLabel) + mcsDelete(scon.GetLevel()) +} + +func GetLxcContexts() (processLabel string, fileLabel string) { + var val, key string + var bufin *bufio.Reader + if !SelinuxEnabled() { + return + } + lxcPath := C.GoString(C.selinux_lxc_contexts_path()) + fileLabel = "system_u:object_r:svirt_sandbox_file_t:s0" + processLabel = "system_u:system_r:svirt_lxc_net_t:s0" + + in, err := os.Open(lxcPath) + if err != nil { + goto exit + } + + defer in.Close() + bufin = bufio.NewReader(in) + + for done := false; !done; { + var line string + if line, err = bufin.ReadString('\n'); err != nil { + if err == io.EOF { + done = true + } else { + goto exit + } + } + line = strings.TrimSpace(line) + if len(line) == 0 { + // Skip blank lines + continue + } + if line[0] == ';' || line[0] == '#' { + // Skip comments + continue + } + if groups := assignRegex.FindStringSubmatch(line); groups != nil { + key, val = strings.TrimSpace(groups[1]), strings.TrimSpace(groups[2]) + if key == "process" { + processLabel = strings.Trim(val, "\"") + } + if key == "file" { + fileLabel = strings.Trim(val, "\"") + } + } + } +exit: + var scon Context + mcs := IntToMcs(os.Getpid(), 1024) + scon = NewContext(processLabel) + scon.SetLevel(mcs) + processLabel = scon.Get() + scon = NewContext(fileLabel) + scon.SetLevel(mcs) + fileLabel = scon.Get() + return processLabel, fileLabel +} + +func CopyLevel(src, dest string) (string, error) { + if !SelinuxEnabled() { + return "", nil + } + if src == "" { + return "", nil + } + rc, err := C.security_check_context(C.CString(src)) + if rc != 0 { + return "", err + } + rc, err = C.security_check_context(C.CString(dest)) + if rc != 0 { + return "", err + } + scon := NewContext(src) + tcon := NewContext(dest) + tcon.SetLevel(scon.GetLevel()) + return tcon.Get(), nil +} + +func RestoreCon(fpath string, recurse bool) error { + var flabel string + var err error + var fs os.FileInfo + + if !SelinuxEnabled() { + return nil + } + + if recurse { + var paths []string + var err error + + if paths, err = filepath.Glob(path.Join(fpath, "**", "*")); err != nil { + return fmt.Errorf("Unable to find directory %v: %v", fpath, err) + } + + for _, fpath := range paths { + if err = RestoreCon(fpath, false); err != nil { + return fmt.Errorf("Unable to restore selinux context for %v: %v", fpath, err) + } + } + return nil + } + if fs, err = os.Stat(fpath); err != nil { + return fmt.Errorf("Unable stat %v: %v", fpath, err) + } + + if flabel, err = Matchpathcon(fpath, fs.Mode()); flabel == "" { + return fmt.Errorf("Unable to get context for %v: %v", fpath, err) + } + + if rc, err := Setfilecon(fpath, flabel); rc != 0 { + return fmt.Errorf("Unable to set selinux context for %v: %v", fpath, err) + } + + return nil +} + +func Test() { + var plabel, flabel string + if !SelinuxEnabled() { + return + } + + plabel, flabel = GetLxcContexts() + fmt.Println(plabel) + fmt.Println(flabel) + freeContext(plabel) + plabel, flabel = GetLxcContexts() + fmt.Println(plabel) + fmt.Println(flabel) + freeContext(plabel) + if SelinuxEnabled() { + fmt.Println("Enabled") + } else { + fmt.Println("Disabled") + } + fmt.Println("getenforce ", SelinuxGetEnforce()) + fmt.Println("getenforcemode ", SelinuxGetEnforceMode()) + flabel, _ = Matchpathcon("/home/dwalsh/.emacs", 0) + fmt.Println(flabel) + pid := os.Getpid() + fmt.Printf("PID:%d MCS:%s\n", pid, IntToMcs(pid, 1023)) + fmt.Println(Getcon()) + fmt.Println(Getfilecon("/etc/passwd")) + fmt.Println(Getpidcon(1)) + Setfscreatecon("unconfined_u:unconfined_r:unconfined_t:s0") + fmt.Println(Getfscreatecon()) + Setfscreatecon("") + fmt.Println(Getfscreatecon()) + fmt.Println(Getpidcon(1)) +} diff --git a/golang/test.go b/golang/test.go new file mode 100644 index 0000000..fed6de8 --- /dev/null +++ b/golang/test.go @@ -0,0 +1,9 @@ +package main + +import ( + "./selinux" +) + +func main() { + selinux.Test() +} diff --git a/include/selinux/selinux.h b/include/selinux/selinux.h index d0eb5c6..4beb170 100644 --- a/include/selinux/selinux.h +++ b/include/selinux/selinux.h @@ -543,6 +543,7 @@ extern const char *selinux_virtual_image_context_path(void); extern const char *selinux_lxc_contexts_path(void); extern const char *selinux_x_context_path(void); extern const char *selinux_sepgsql_context_path(void); +extern const char *selinux_openssh_contexts_path(void); extern const char *selinux_systemd_contexts_path(void); extern const char *selinux_contexts_path(void); extern const char *selinux_securetty_types_path(void); diff --git a/man/man3/getfscreatecon.3 b/man/man3/getfscreatecon.3 index e348d3b..8cc4df5 100644 --- a/man/man3/getfscreatecon.3 +++ b/man/man3/getfscreatecon.3 @@ -49,6 +49,11 @@ Signal handlers that perform a must take care to save, reset, and restore the fscreate context to avoid unexpected behavior. . + +.br +.B Note: +Contexts are thread specific. + .SH "RETURN VALUE" On error \-1 is returned. On success 0 is returned. diff --git a/man/man3/getkeycreatecon.3 b/man/man3/getkeycreatecon.3 index 4d70f10..b51008d 100644 --- a/man/man3/getkeycreatecon.3 +++ b/man/man3/getkeycreatecon.3 @@ -48,6 +48,10 @@ Signal handlers that perform a .BR setkeycreatecon () must take care to save, reset, and restore the keycreate context to avoid unexpected behavior. + +.br +.B Note: +Contexts are thread specific. . .SH "RETURN VALUE" On error \-1 is returned. diff --git a/man/man3/getsockcreatecon.3 b/man/man3/getsockcreatecon.3 index 4dd8f30..26086d9 100644 --- a/man/man3/getsockcreatecon.3 +++ b/man/man3/getsockcreatecon.3 @@ -49,6 +49,11 @@ Signal handlers that perform a must take care to save, reset, and restore the sockcreate context to avoid unexpected behavior. . + +.br +.B Note: +Contexts are thread specific. + .SH "RETURN VALUE" On error \-1 is returned. On success 0 is returned. diff --git a/man/man8/selinux.8 b/man/man8/selinux.8 index e89b1ef..fd20363 100644 --- a/man/man8/selinux.8 +++ b/man/man8/selinux.8 @@ -74,7 +74,7 @@ The best way to relabel the file system is to create the flag file and reboot. .BR system\-config\-selinux , also has this capability. The -.BR restorcon / fixfiles +.BR restorecon / fixfiles commands are also available for relabeling files. . .SH AUTHOR @@ -91,11 +91,13 @@ This manual page was written by Dan Walsh . .BR sepolicy (8), .BR system-config-selinux (8), .BR togglesebool (8), -.BR restorecon (8), .BR fixfiles (8), +.BR restorecon (8), .BR setfiles (8), .BR semanage (8), -.BR sepolicy(8) +.BR sepolicy(8), +.BR seinfo(8), +.BR sesearch(8) Every confined service on the system has a man page in the following format: .br diff --git a/src/Makefile b/src/Makefile index 4d07ba6..62c8dad 100644 --- a/src/Makefile +++ b/src/Makefile @@ -111,7 +111,7 @@ $(LIBA): $(OBJS) $(RANLIB) $@ $(LIBSO): $(LOBJS) - $(CC) $(CFLAGS) -shared -o $@ $^ -lpcre -ldl $(LDFLAGS) -L$(LIBDIR) -Wl,-soname,$(LIBSO),-z,defs,-z,relro + $(CC) $(CFLAGS) -shared -o $@ $^ -lpcre -llzma -ldl $(LDFLAGS) -L$(LIBDIR) -Wl,-soname,$(LIBSO),-z,defs,-z,relro ln -sf $@ $(TARGET) $(LIBPC): $(LIBPC).in ../VERSION diff --git a/src/avc_sidtab.c b/src/avc_sidtab.c index 52f21df..66ad9e1 100644 --- a/src/avc_sidtab.c +++ b/src/avc_sidtab.c @@ -81,6 +81,11 @@ sidtab_context_to_sid(struct sidtab *s, int hvalue, rc = 0; struct sidtab_node *cur; + if (! ctx) { + errno=EINVAL; + return -1; + } + *sid = NULL; hvalue = sidtab_hash(ctx); diff --git a/src/canonicalize_context.c b/src/canonicalize_context.c index 7cf3139..364a746 100644 --- a/src/canonicalize_context.c +++ b/src/canonicalize_context.c @@ -17,6 +17,11 @@ int security_canonicalize_context_raw(const char * con, size_t size; int fd, ret; + if (! con) { + errno=EINVAL; + return -1; + } + if (!selinux_mnt) { errno = ENOENT; return -1; diff --git a/src/check_context.c b/src/check_context.c index 52063fa..234749c 100644 --- a/src/check_context.c +++ b/src/check_context.c @@ -14,6 +14,11 @@ int security_check_context_raw(const char * con) char path[PATH_MAX]; int fd, ret; + if (! con) { + errno=EINVAL; + return -1; + } + if (!selinux_mnt) { errno = ENOENT; return -1; diff --git a/src/compute_av.c b/src/compute_av.c index 937e5c3..35ace7f 100644 --- a/src/compute_av.c +++ b/src/compute_av.c @@ -26,6 +26,11 @@ int security_compute_av_flags_raw(const char * scon, return -1; } + if ((! scon) || (! tcon)) { + errno=EINVAL; + return -1; + } + snprintf(path, sizeof path, "%s/access", selinux_mnt); fd = open(path, O_RDWR); if (fd < 0) diff --git a/src/compute_create.c b/src/compute_create.c index 9559d42..14a65d1 100644 --- a/src/compute_create.c +++ b/src/compute_create.c @@ -64,6 +64,11 @@ int security_compute_create_name_raw(const char * scon, return -1; } + if ((! scon) || (! tcon)) { + errno=EINVAL; + return -1; + } + snprintf(path, sizeof path, "%s/create", selinux_mnt); fd = open(path, O_RDWR); if (fd < 0) diff --git a/src/compute_member.c b/src/compute_member.c index 1fc7e41..065d996 100644 --- a/src/compute_member.c +++ b/src/compute_member.c @@ -25,6 +25,11 @@ int security_compute_member_raw(const char * scon, return -1; } + if ((! scon) || (! tcon)) { + errno=EINVAL; + return -1; + } + snprintf(path, sizeof path, "%s/member", selinux_mnt); fd = open(path, O_RDWR); if (fd < 0) diff --git a/src/compute_relabel.c b/src/compute_relabel.c index 4615aee..cc77f36 100644 --- a/src/compute_relabel.c +++ b/src/compute_relabel.c @@ -25,6 +25,11 @@ int security_compute_relabel_raw(const char * scon, return -1; } + if ((! scon) || (! tcon)) { + errno=EINVAL; + return -1; + } + snprintf(path, sizeof path, "%s/relabel", selinux_mnt); fd = open(path, O_RDWR); if (fd < 0) diff --git a/src/compute_user.c b/src/compute_user.c index b37c5d3..7703c26 100644 --- a/src/compute_user.c +++ b/src/compute_user.c @@ -24,6 +24,11 @@ int security_compute_user_raw(const char * scon, return -1; } + if (! scon) { + errno=EINVAL; + return -1; + } + snprintf(path, sizeof path, "%s/user", selinux_mnt); fd = open(path, O_RDWR); if (fd < 0) diff --git a/src/file_path_suffixes.h b/src/file_path_suffixes.h index 3c92424..d1f9b48 100644 --- a/src/file_path_suffixes.h +++ b/src/file_path_suffixes.h @@ -23,6 +23,7 @@ S_(BINPOLICY, "/policy/policy") S_(VIRTUAL_DOMAIN, "/contexts/virtual_domain_context") S_(VIRTUAL_IMAGE, "/contexts/virtual_image_context") S_(LXC_CONTEXTS, "/contexts/lxc_contexts") + S_(OPENSSH_CONTEXTS, "/contexts/openssh_contexts") S_(SYSTEMD_CONTEXTS, "/contexts/systemd_contexts") S_(FILE_CONTEXT_SUBS, "/contexts/files/file_contexts.subs") S_(FILE_CONTEXT_SUBS_DIST, "/contexts/files/file_contexts.subs_dist") diff --git a/src/fsetfilecon.c b/src/fsetfilecon.c index 52707d0..0cbe12d 100644 --- a/src/fsetfilecon.c +++ b/src/fsetfilecon.c @@ -9,8 +9,12 @@ int fsetfilecon_raw(int fd, const char * context) { - int rc = fsetxattr(fd, XATTR_NAME_SELINUX, context, strlen(context) + 1, - 0); + int rc; + if (! context) { + errno=EINVAL; + return -1; + } + rc = fsetxattr(fd, XATTR_NAME_SELINUX, context, strlen(context) + 1, 0); if (rc < 0 && errno == ENOTSUP) { char * ccontext = NULL; int err = errno; diff --git a/src/load_policy.c b/src/load_policy.c index e419f1a..275672d 100644 --- a/src/load_policy.c +++ b/src/load_policy.c @@ -16,6 +16,82 @@ #include #include "policy.h" #include +#include + +static char *lzmaread(int fd, size_t *rsize) { + int capacity = 64*1024; + char *buf = NULL; + int tmpsize = 8 * 1024; + unsigned char tmp[tmpsize]; + unsigned char tmp_out[tmpsize]; + size_t size = 0; + lzma_stream strm = LZMA_STREAM_INIT; + lzma_action action = LZMA_RUN; + lzma_ret ret; + + FILE *stream = fdopen (fd, "r"); + if (!stream) { + return NULL; + } + ret = lzma_stream_decoder(&strm, UINT64_MAX, + LZMA_CONCATENATED); + + strm.avail_in = 0; + strm.next_out = tmp_out; + strm.avail_out = tmpsize; + + buf = (char *) malloc (capacity); + if (!buf) + goto err; + + while (1) { + if (strm.avail_in == 0) { + strm.next_in = tmp; + strm.avail_in = fread(tmp, 1, tmpsize, stream); + + if (ferror(stream)) { + // POSIX says that fread() sets errno if + // an error occurred. ferror() doesn't + // touch errno. + goto err; + } + if (feof(stream)) action = LZMA_FINISH; + } + + ret = lzma_code(&strm, action); + + // Write and check write error before checking decoder error. + // This way as much data as possible gets written to output + // even if decoder detected an error. + if (strm.avail_out == 0 || ret != LZMA_OK) { + const size_t num = tmpsize - strm.avail_out; + if (num > capacity) { + buf = (char*) realloc (buf, size*2); + capacity = size; + } + memcpy (buf+size, tmp_out, num); + capacity -= num; + size += num; + strm.next_out = tmp_out; + strm.avail_out = tmpsize; + } + if (ret != LZMA_OK) { + if (ret == LZMA_STREAM_END) { + break; + } else { + goto err; + } + } + } + *rsize = size; + + goto exit; +err: + free(buf); buf = NULL; +exit: + lzma_end(&strm); + return buf; +} int security_load_policy(void *data, size_t len) { @@ -55,7 +131,7 @@ int selinux_mkload_policy(int preservebools) struct stat sb; struct utsname uts; size_t size; - void *map, *data; + void *map = NULL, *data=NULL; int fd, rc = -1, prot; sepol_policydb_t *policydb; sepol_policy_file_t *pf; @@ -181,24 +257,28 @@ checkbool: goto dlclose; } - if (fstat(fd, &sb) < 0) { - fprintf(stderr, - "SELinux: Could not stat policy file %s: %s\n", - path, strerror(errno)); - goto close; - } - - prot = PROT_READ; - if (setlocaldefs || preservebools) - prot |= PROT_WRITE; + data = lzmaread(fd,&size); - size = sb.st_size; - data = map = mmap(NULL, size, prot, MAP_PRIVATE, fd, 0); - if (map == MAP_FAILED) { - fprintf(stderr, - "SELinux: Could not map policy file %s: %s\n", + if (!data) { + if (fstat(fd, &sb) < 0) { + fprintf(stderr, + "SELinux: Could not stat policy file %s: %s\n", path, strerror(errno)); - goto close; + goto close; + } + + prot = PROT_READ; + if (setlocaldefs || preservebools) + prot |= PROT_WRITE; + + size = sb.st_size; + data = map = mmap(NULL, size, prot, MAP_PRIVATE, fd, 0); + if (map == MAP_FAILED) { + fprintf(stderr, + "SELinux: Could not map policy file %s: %s\n", + path, strerror(errno)); + goto close; + } } if (vers > kernvers && usesepol) { @@ -210,6 +290,8 @@ checkbool: goto unmap; } policy_file_set_mem(pf, data, size); + if (!map) + free(data); if (policydb_read(policydb, pf)) { policy_file_free(pf); policydb_free(policydb); @@ -223,7 +305,8 @@ checkbool: path); policy_file_free(pf); policydb_free(policydb); - munmap(map, sb.st_size); + if (map) + munmap(map, sb.st_size); close(fd); vers--; goto search; @@ -275,7 +358,7 @@ checkbool: #endif } - + rc = security_load_policy(data, size); if (rc) @@ -286,7 +369,8 @@ checkbool: unmap: if (data != map) free(data); - munmap(map, sb.st_size); + if (map) + munmap(map, sb.st_size); close: close(fd); dlclose: diff --git a/src/lsetfilecon.c b/src/lsetfilecon.c index 1d3b28a..ea6d70b 100644 --- a/src/lsetfilecon.c +++ b/src/lsetfilecon.c @@ -9,8 +9,13 @@ int lsetfilecon_raw(const char *path, const char * context) { - int rc = lsetxattr(path, XATTR_NAME_SELINUX, context, strlen(context) + 1, - 0); + int rc; + if (! context) { + errno=EINVAL; + return -1; + } + + rc = lsetxattr(path, XATTR_NAME_SELINUX, context, strlen(context) + 1, 0); if (rc < 0 && errno == ENOTSUP) { char * ccontext = NULL; int err = errno; diff --git a/src/matchpathcon.c b/src/matchpathcon.c index 3b96b1d..d5c90f6 100644 --- a/src/matchpathcon.c +++ b/src/matchpathcon.c @@ -2,6 +2,7 @@ #include #include #include +#include #include "selinux_internal.h" #include "label_internal.h" #include "callbacks.h" @@ -62,7 +63,7 @@ static void { va_list ap; va_start(ap, fmt); - vfprintf(stderr, fmt, ap); + vsyslog(LOG_ERR, fmt, ap); va_end(ap); } diff --git a/src/selinux_config.c b/src/selinux_config.c index 30e9dc7..1bfe500 100644 --- a/src/selinux_config.c +++ b/src/selinux_config.c @@ -50,8 +50,9 @@ #define FILE_CONTEXT_SUBS_DIST 25 #define LXC_CONTEXTS 26 #define BOOLEAN_SUBS 27 -#define SYSTEMD_CONTEXTS 28 -#define NEL 29 +#define OPENSSH_CONTEXTS 28 +#define SYSTEMD_CONTEXTS 29 +#define NEL 30 /* Part of one-time lazy init */ static pthread_once_t once = PTHREAD_ONCE_INIT; @@ -493,6 +494,13 @@ const char *selinux_lxc_contexts_path(void) hidden_def(selinux_lxc_contexts_path) +const char *selinux_openssh_contexts_path(void) +{ + return get_path(OPENSSH_CONTEXTS); +} + +hidden_def(selinux_openssh_contexts_path) + const char *selinux_systemd_contexts_path(void) { return get_path(SYSTEMD_CONTEXTS); diff --git a/src/selinux_internal.h b/src/selinux_internal.h index afb2170..fe8eb67 100644 --- a/src/selinux_internal.h +++ b/src/selinux_internal.h @@ -82,6 +82,7 @@ hidden_proto(selinux_mkload_policy) hidden_proto(selinux_customizable_types_path) hidden_proto(selinux_media_context_path) hidden_proto(selinux_x_context_path) + hidden_proto(selinux_openssh_contexts_path) hidden_proto(selinux_sepgsql_context_path) hidden_proto(selinux_systemd_contexts_path) hidden_proto(selinux_path) diff --git a/src/setfilecon.c b/src/setfilecon.c index d05969c..3f0200e 100644 --- a/src/setfilecon.c +++ b/src/setfilecon.c @@ -9,8 +9,12 @@ int setfilecon_raw(const char *path, const char * context) { - int rc = setxattr(path, XATTR_NAME_SELINUX, context, strlen(context) + 1, - 0); + int rc; + if (! context) { + errno=EINVAL; + return -1; + } + rc = setxattr(path, XATTR_NAME_SELINUX, context, strlen(context) + 1, 0); if (rc < 0 && errno == ENOTSUP) { char * ccontext = NULL; int err = errno; diff --git a/utils/sefcontext_compile.c b/utils/sefcontext_compile.c index 0adc968..9618989 100644 --- a/utils/sefcontext_compile.c +++ b/utils/sefcontext_compile.c @@ -4,6 +4,9 @@ #include #include #include +#include +#include +#include #include @@ -323,6 +326,7 @@ int main(int argc, char *argv[]) int rc; char *tmp= NULL; int fd; + struct stat buf; if (argc != 2) { fprintf(stderr, "usage: %s input_file\n", argv[0]); @@ -333,6 +337,11 @@ int main(int argc, char *argv[]) path = argv[1]; + if (stat(path, &buf) < 0) { + fprintf(stderr, "Can not stat: %s: %m\n", argv[0]); + exit(EXIT_FAILURE); + } + rc = process_file(&data, path); if (rc < 0) return rc; @@ -352,6 +361,12 @@ int main(int argc, char *argv[]) if (fd < 0) goto err; + rc = fchmod(fd, buf.st_mode); + if (rc < 0) { + perror("fchmod failed to set permission on compiled regexs"); + goto err; + } + rc = write_binary_file(&data, fd); if (rc < 0)