1f266e3
From 8a453a7b0f1e667b7369eb73b00843a8decdecc9 Mon Sep 17 00:00:00 2001
1f266e3
From: Daniel Stenberg <daniel@haxx.se>
1f266e3
Date: Thu, 11 Feb 2016 13:52:20 +0100
1f266e3
Subject: [PATCH] diffie_hellman_sha256: convert bytes to bits
1f266e3
1f266e3
As otherwise we get far too small numbers.
1f266e3
1f266e3
CVE-2016-0787
1f266e3
---
1f266e3
 src/kex.c | 2 +-
1f266e3
 1 file changed, 1 insertion(+), 1 deletion(-)
1f266e3
1f266e3
diff --git a/src/kex.c b/src/kex.c
1f266e3
index 6349457..e89b36c 100644
1f266e3
--- a/src/kex.c
1f266e3
+++ b/src/kex.c
1f266e3
@@ -751,11 +751,11 @@ static int diffie_hellman_sha256(LIBSSH2_SESSION *session,
1f266e3
 
1f266e3
         /* Zero the whole thing out */
1f266e3
         memset(&exchange_state->req_state, 0, sizeof(packet_require_state_t));
1f266e3
 
1f266e3
         /* Generate x and e */
1f266e3
-        _libssh2_bn_rand(exchange_state->x, group_order, 0, -1);
1f266e3
+        _libssh2_bn_rand(exchange_state->x, group_order * 8 - 1, 0, -1);
1f266e3
         _libssh2_bn_mod_exp(exchange_state->e, g, exchange_state->x, p,
1f266e3
                             exchange_state->ctx);
1f266e3
 
1f266e3
         /* Send KEX init */
1f266e3
         /* packet_type(1) + String Length(4) + leading 0(1) */
1f266e3
-- 
1f266e3
2.7.0
1f266e3