PR#15: ANNOUNCED: Update to 9.0.1 - rpms/llhttp

rpms / llhttp

#15 ANNOUNCED: Update to 9.0.1

Merged 9 months ago by music. Opened 9 months ago by music.

rpms/ music/llhttp v9 into rawhide

Update to 9.0.1 (close RHBZ#2228290)

Benjamin A. Beasley • 9 months ago

e00ee12

Update to 9.0.0

Benjamin A. Beasley • 9 months ago

97b2a08

.gitignore

file modified

		`@@ -10,3 +10,7 @@`
		`/llhttp-8.1.0-nm-dev.tgz`
		`/llhttp-8.1.1.tar.gz`
		`/llhttp-8.1.1-nm-dev.tgz`
		`+ /llhttp-9.0.0.tar.gz`
		`+ /llhttp-9.0.0-nm-dev.tgz`
		`+ /llhttp-9.0.1.tar.gz`
		`+ /llhttp-9.0.1-nm-dev.tgz`

230.patch

file removed

-24

		`@@ -1,24 +0,0 @@`
		`- From 553ae7d1bda0b97a43af6b57ea2fd7ce04b6630d Mon Sep 17 00:00:00 2001`
		`- From: "Benjamin A. Beasley" <code@musicinmybrain.net>`
		`- Date: Tue, 27 Jun 2023 18:27:17 -0400`
		`- Subject: [PATCH] Do not assume a particular sed implementation`
		`-`
		`- Make the release target in the Makefile more portable.`
		`- ---`
		`- Makefile \| 3 +--`
		`- 1 file changed, 1 insertion(+), 2 deletions(-)`
		`-`
		`- diff --git a/Makefile b/Makefile`
		`- index 5b941b3..d9c6d35 100644`
		`- --- a/Makefile`
		`- +++ b/Makefile`
		`- @@ -52,8 +52,7 @@ release: clean generate`
		`- cp -rf src/native/*.c release/src/`
		`- cp -rf src/llhttp.gyp release/`
		`- cp -rf src/common.gypi release/`
		`- - cp -rf CMakeLists.txt release/`
		`- - sed -i '' s/_RELEASE_/$(RELEASE)/ release/CMakeLists.txt`
		`- + sed s/_RELEASE_/$(RELEASE)/ CMakeLists.txt > release/CMakeLists.txt`
		`- cp -rf libllhttp.pc.in release/`
		`- cp -rf README.md release/`
		`- cp -rf LICENSE-MIT release/`

llhttp.spec

file modified

+2 -9

		`@@ -26,8 +26,8 @@`
		`# additional source even if we do not do the re-generation ourselves.`

		`Name: llhttp`
		`- Version: 8.1.1`
		`- %global so_version 8.1`
		`+ Version: 9.0.1`
		`+ %global so_version 9.0`
		`Release: %autorelease`
		`Summary: Port of http_parser to llparse`

		`@@ -54,10 +54,6 @@`
		`Source3: check-null-licenses`
		`Source4: audited-null-licenses.toml`

		`- # Do not assume a particular sed implementation`
		`- # https://github.com/nodejs/llhttp/pull/230`
		`- Patch: %{url}/pull/230.patch`
		`-`
		`# The compiled RPM does not depend on NodeJS at all, but we cannot build it`
		`# on architectures without NodeJS.`
		`ExclusiveArch: %{nodejs_arches}`
		`@@ -81,9 +77,6 @@`
		`generate the output C source file, which could be compiled and linked with the`
		`embedder's program (like Node.js).`

		`- This copy of the library is compiled with LLHTTP_STRICT_MODE set to 0`
		`- (disabled), which is the default.`
		`-`

		`%package devel`
		`Summary: Development files for llhttp`

sources

file modified

+2 -2

		`@@ -1,2 +1,2 @@`
		`- SHA512 (llhttp-8.1.1.tar.gz) = 18530d1fcfde13ba634b367852e53bf7a2dc0eb130f07fbbb5b5e02b3d4ff0ab0cd7c5a0adef8a7a0e93a0104a2544ce11d3631792539c48e1a918c5d40f7f3c`
		`- SHA512 (llhttp-8.1.1-nm-dev.tgz) = 5348f09a4d8a7b7ecb5d4204d47b1f6c36ed7d131cd89f84feef475cba74fc651bf63bc10293fb5481c19c88e07e3ae2e44881ffda19606876e1f38de32ae80f`
		`+ SHA512 (llhttp-9.0.1.tar.gz) = 715860493a40ba2a9b0bf1cc50d810798c6091ca2291dd68ec162a632b6663f46e612e721a9b99611940566de57e2461ad1d5055958c371c95bdadac69bc5cd6`
		`+ SHA512 (llhttp-9.0.1-nm-dev.tgz) = f7a1f100aeca040a3f6954b555fec3518e6adcfca2258c80182306b4c68c8f71e252dca1a6a75be0cfefb17bcd8de0bffed0d9aabb1156d7de6dcf2efbb98747`

music commented 9 months ago

The SONAME version is updated from 8.1 to 9.0. The compile-time LLHTTP_STRICT_MODE option is replaced with three new runtime flags.

music commented 9 months ago

The python-aiohttp tests would have two regressions with this:

=================================== FAILURES ===================================
_______________ test_url_parse_non_strict_mode[c-parser-pyloop] ________________

parser = <aiohttp._http_parser.HttpRequestParser object at 0x7f2d4fed6ce0>

    def test_url_parse_non_strict_mode(parser) -> None:
        payload = "GET /test/тест HTTP/1.1\r\n\r\n".encode()
>       messages, upgrade, tail = parser.feed_data(payload)

parser     = <aiohttp._http_parser.HttpRequestParser object at 0x7f2d4fed6ce0>
payload    = b'GET /test/\xd1\x82\xd0\xb5\xd1\x81\xd1\x82 HTTP/1.1\r\n\r\n'

tests/test_http_parser.py:846:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

>   raise ex
E   aiohttp.http_exceptions.InvalidURLError: 400, message:
E     Invalid char in url path:
E
E       b'GET /test/\xd1\x82\xd0\xb5\xd1\x81\xd1\x82 HTTP/1.1\r'
E                   ^


aiohttp/_http_parser.pyx:557: InvalidURLError
_____________________ test_parse_uri_utf8[c-parser-pyloop] _____________________

parser = <aiohttp._http_parser.HttpRequestParser object at 0x7f2d4fed6ce0>

    def test_parse_uri_utf8(parser) -> None:
        text = ("GET /путь?ключ=знач#фраг HTTP/1.1\r\n\r\n").encode()
>       messages, upgrade, tail = parser.feed_data(text)

parser     = <aiohttp._http_parser.HttpRequestParser object at 0x7f2d4fed6ce0>
text       = b'GET /\xd0\xbf\xd1\x83\xd1\x82\xd1\x8c?\xd0\xba\xd0\xbb\xd1\x8e\xd1\x87=\xd0\xb7\xd0\xbd\xd0\xb0\xd1\x87#\xd1\x84\xd1\x80\xd0\xb0\xd0\xb3 HTTP/1.1\r\n\r\n'

tests/test_http_parser.py:882:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

>   raise ex
E   aiohttp.http_exceptions.InvalidURLError: 400, message:
E     Invalid char in url path:
E
E       b'GET /\xd0\xbf\xd1\x83\xd1\x82\xd1\x8c?\xd0\xba\xd0\xbb\xd1\x8e\xd1\x87=\xd0\xb7\xd0\xbd\xd0\xb0\xd1\x87#\xd1\x84\xd1\x80\xd0\xb0\xd0\xb3 HTTP/1.1\r'
E              ^


aiohttp/_http_parser.pyx:557: InvalidURLError

FAILED tests/test_http_parser.py::test_url_parse_non_strict_mode[c-parser-pyloop]
FAILED tests/test_http_parser.py::test_parse_uri_utf8[c-parser-pyloop] - aioh...

music commented 9 months ago

https://github.com/aio-libs/aiohttp/issues/7459

music commented 9 months ago

[citest]