PR#119: Add a few rpmlint exceptions - rpms/llvm

rpms / llvm

#119 Add a few rpmlint exceptions

Merged 2 years ago by sergesanspaille. Opened 2 years ago by tbaeder.

rpms/ tbaeder/llvm rpmlint into rawhide

Add a few rpmlint exceptions

Timm Bäder • 2 years ago

3ac3f3b

llvm.rpmlintrc

file modified

+16

		`@@ -1,2 +1,18 @@`
		`# This library has no dependencies.`
		`addFilter("llvm-libs.x86_64: E: shared-lib-without-dependency-information /usr/lib64/libRemarks.so.[0-9]+")`
		`+ addFilter("llvm-googletest.x86_64: W: devel-file-in-non-devel-package")`
		`+`
		`+ # same for llvm-test utilities`
		`+ addFilter("llvm-test.x86_64: W: no-manual-page-for-binary")`
		`+`
		`+ # Don't warn about libs in llvm-libs`
		`+ addFilter("llvm-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/lib")`
		`+ # These is ok in the llvm gold plugin`
		`+ addFilter("llvm-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/LLVMgold.so")`
		`+ addFilter("llvm-libs.x86_64: W: no-soname /usr/lib64/LLVMgold.so")`
		`+`
		`+ # These are without documentation`
		`+ addFilter("llvm-googletest.x86_64: W: no-documentation")`
		`+ addFilter("llvm-libs.x86_64: W: no-documentation")`
		`+ addFilter("llvm-static.x86_64: W: no-documentation")`
		`+ addFilter("llvm-test.x86_64: W: no-documentation")`

llvm.spec

file modified

+1 -1

		`@@ -221,7 +221,7 @@`
		`%endif`

		`# force off shared libs as cmake macros turns it on.`
		`- %cmake -G Ninja \`
		`+ %cmake -G Ninja \`
tstellar commented 2 years ago This change is unrelated.
		`-DBUILD_SHARED_LIBS:BOOL=OFF \`
		`-DLLVM_PARALLEL_LINK_JOBS=1 \`
		`-DCMAKE_BUILD_TYPE=RelWithDebInfo \`

tbaeder commented 2 years ago

This just gets rid of a few warnings from rpmlint, so the output is more easily readable by humans.

tstellar commented on line 6 of llvm.spec 2 years ago

This change is unrelated.

zuul commented 2 years ago

Build succeeded.

check-for-arches : SUCCESS in 2m 40s
rpm-scratch-build : SUCCESS in 2h 08m 57s
rpm-scratch-build-s390x : SUCCESS in 2h 05m 58s (non-voting)
rpm-scratch-build-ppc64le : SUCCESS in 2h 29m 05s (non-voting)
rpm-scratch-build-i686 : SUCCESS in 1h 42m 46s (non-voting)
rpm-scratch-build-armv7hl : SUCCESS in 2h 50m 43s (non-voting)
rpm-scratch-build-aarch64 : TIMED_OUT in 6h 00m 53s (non-voting)
rpm-linter : SUCCESS in 5m 11s
rpm-rpminspect : SUCCESS in 14m 58s (non-voting)
check-for-tests : SUCCESS in 56s
check-for-fmf-tests : SUCCESS in 54s
rpm-install-test : SUCCESS in 2m 51s
rpm-test : SKIPPED
rpm-tmt-test : SUCCESS in 10m 10s

tbaeder commented 2 years ago

This change is unrelated.

This gets rid of a mixed-spaces-and-tabs warning. I'm not sure why pagure displays it like this but it looks fine in git diff and in my editor (with tabwidth 8)

sergesanspaille commented on line 7 of llvm.rpmlintrc 2 years ago

I'd like us to contribute to such manpages upstream, at some point. Silenting the warning will make us forget it ;-)

tstellar commented 2 years ago

This change is unrelated.

This gets rid of a mixed-spaces-and-tabs warning. I'm not sure why pagure displays it like this but it looks fine in git diff and in my editor (with tabwidth 8)

OK, I did not realize that. Then this looks fine to me (except for Serge's comment).

rebased onto f2c09334ca6a5893988611dcf34bc51c5096793c

2 years ago

rebased onto 3ac3f3b

2 years ago

sergesanspaille commented 2 years ago

For the record: I've been checking the use of ::exit(O) in the gold plugin, and there presence is reasonable, it's a defect of the plugin-api error code that doesn't support requesting shutdown

zuul commented 2 years ago

Build succeeded.