#131 Fix rpm build warning/error: absolute symlink
Merged 8 months ago by sergesanspaille. Opened 8 months ago by kkleine.
rpms/ kkleine/llvm fix-absolute-symlink-llvmgold  into  rawhide

file modified
+1 -1
@@ -350,7 +350,7 @@ 

  %if %{with gold}

  # Add symlink to lto plugin in the binutils plugin directory.

  %{__mkdir_p} %{buildroot}%{_libdir}/bfd-plugins/

- ln -s %{_libdir}/LLVMgold.so %{buildroot}%{_libdir}/bfd-plugins/

+ ln -s -t %{buildroot}%{_libdir}/bfd-plugins/ ../LLVMgold.so

  %endif

  

  %else

I noticed that warnings and errors show up in the RPM build errors:
output. When I produced an error I did see this warning about absolute
symlink showing up:

absolute symlink: /usr/lib64/bfd-plugins/LLVMgold.so -> /usr/lib64/LLVMgold.so

The upstream RPM fix to log warnings and errors separately is here:

https://github.com/rpm-software-management/rpm/pull/1590

Thanks to @sergesanspaille for the help.

Metadata Update from @kkleine:
- Request assigned

8 months ago

LGTM, let's wait for the CI (it should work even though we have a rc pending because LLVM is at the root of the dependency tree)

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

tmt tests fail due to

- nothing provides clang-resource-filesystem = 13.0.1~rc2 needed by libomp-devel-13.0.1~rc2-2.fc36.x86_64
  - nothing provides clang-resource-filesystem = 13.0.1~rc2 needed by libomp-devel-13.0.1~rc2-2.fc36.i686

that's due to rc not being merged yet. Otherwise looks good.

rebased onto 5d9e2b6

8 months ago

Pull-Request has been merged by sergesanspaille

8 months ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

Metadata