#20 Add provides for the major version of sub-packages
Merged 2 months ago by tstellar. Opened 2 months ago by tstellar.
rpms/ tstellar/llvm llvm-major-provides  into  master

file modified
+10 -1

@@ -40,7 +40,7 @@ 

  

  Name:		%{pkg_name}

  Version:	%{maj_ver}.%{min_ver}.%{patch_ver}

- Release:	7%{?rc_ver:.rc%{rc_ver}}%{?dist}

+ Release:	8%{?rc_ver:.rc%{rc_ver}}%{?dist}

  Summary:	The Low Level Virtual Machine

  

  License:	NCSA

@@ -78,6 +78,8 @@ 

  

  Requires:	%{name}-libs%{?_isa} = %{version}-%{release}

  

+ Provides:	llvm(major) = %{maj_ver}

+ 

  %description

  LLVM is a compiler infrastructure designed for compile-time, link-time,

  runtime, and idle-time optimization of programs from arbitrary programming

@@ -94,6 +96,8 @@ 

  Requires(post):	%{_sbindir}/alternatives

  Requires(postun):	%{_sbindir}/alternatives

  

+ Provides:	llvm-devel(major) = %{maj_ver}

+ 

  %description devel

  This package contains library and header files needed to develop new native

  programs that use the LLVM infrastructure.

@@ -133,6 +137,8 @@ 

  Requires:	gcc

  Requires:	findutils

  

+ Provides:	llvm-test(major) = %{maj_ver}

+ 

  %description test

  LLVM regression tests.

  

@@ -463,6 +469,9 @@ 

  %endif

  

  %changelog

+ * Wed Jul 17 2019 Tom Stellard <tstellar@redhat.com> - 8.0.0-8

+ - Add provides for the major version of sub-packages

+ 

  * Fri May 17 2019 sguelton@redhat.com - 8.0.0-7

  - Fix conflicts between llvm-static = 8 and llvm-dev < 8 around LLVMStaticExports.cmake

  

no initial comment

LGTM, can you tell me about the motivations?

This is so packages go do things like:

Requires: llvm-test(major) = 8

And not have dependencies broken when llvm is upgraded from 8.0.0 to 8.0.1. I'm going to use this in the new lld-test package I proposed in https://src.fedoraproject.org/rpms/lld/pull-request/7.

ok. Do we have any ABI guarentee during minor release in LLVM?

Yeah X.Y.1 has to be ABI compatible with X.Y.0.

Pull-Request has been merged by tstellar

2 months ago