#6 Disable bootstrap mode forgotten on 5.4 rebase
Merged 4 months ago by spot. Opened 4 months ago by pmatilai.
rpms/ pmatilai/lua rawhide  into  rawhide

file modified
+5 -2
@@ -4,7 +4,7 @@ 

  # If you are incrementing major_version, enable bootstrapping and adjust accordingly.

  # Version should be the latest prior build. If you don't do this, RPM will break and

  # everything will grind to a halt.

- %global bootstrap 1

+ %global bootstrap 0

  %global bootstrap_major_version 5.3

  %global bootstrap_version %{bootstrap_major_version}.6

  
@@ -14,7 +14,7 @@ 

  

  Name:           lua

  Version:        %{major_version}.4

- Release:        4%{?dist}

+ Release:        5%{?dist}

  Summary:        Powerful light-weight programming language

  License:        MIT

  URL:            https://www.lua.org/
@@ -222,6 +222,9 @@ 

  %{_libdir}/*.a

  

  %changelog

+ * Mon Oct 17 2022 Panu Matilainen <pmatilai@redhat.com> - 5.4.4-5

+ - Disable bootstrap mode forgotten on 5.4 rebase

+ 

  * Thu Jul 21 2022 Fedora Release Engineering <releng@fedoraproject.org> - 5.4.4-4

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild

  

Bootstrap was (necessarily) enabled when rebasing to 5.4 in commit
627e03f, but forgotten to disable
once done. We don't want to ship an insecure liblua version even if
nothing actually links to it...

Sounds reasonable, but:

$ repoquery -q --repo=rawhide --whatrequires 'liblua-5.3.so()(64bit)'
megaglest-0:3.13.0-13.fc37.x86_64

$ repoquery -q --repo=fedora --releasever=37 --whatrequires 'liblua-5.3.so()(64bit)'
cegui-0:0.8.7-25.fc37.x86_64
cegui-devel-0:0.8.7-25.fc37.x86_64
megaglest-0:3.13.0-13.fc37.x86_64

Eww, ugh. So those need to be rebuilt...

megaglest needs to be fixed. It was weighting 5.3 over all other versions of lua, thus, when it found that, it used it. I also had to fix it so it would run at all on Wayland. :/ FIxes going into rawhide now.

cegui is dead in rawhide, so I think we can land this change once megaglest is rebuilt in rawhide.

Also, FWIW, I don't think this was a case of "spot forgot to turn off lua 5.3" and more of exactly this problem, in that there were things depending on 5.3. :D

Pull-Request has been merged by spot

4 months ago

Ack, it just looked like it was forgotten because there's no related rationale anywhere to be found, but then I get that you only realized the 5.3 dependencies after rebasing. Still, a after-the-fact comment to the lua spec would've cleared it up.

No big deal in Fedora, only we just discovered the unwanted bootstrap mode has been inherited to all sorts of other places too :laughing: which is not your fault but the ones who reviewed the import...

This has just leaked into stable Fedoras.

Metadata