#4 Go back to using the latest readline
Closed 2 years ago by mcsontos. Opened 4 years ago by yaneti.
rpms/ yaneti/lvm2 readline-back  into  rawhide

file modified
+1 -6
@@ -74,7 +74,7 @@ 

  BuildRequires: libselinux-devel >= %{libselinux_version}, libsepol-devel

  BuildRequires: libblkid-devel >= %{util_linux_version}

  BuildRequires: ncurses-devel

- BuildRequires: compat-readline5-devel

+ BuildRequires: readline-devel

  BuildRequires: libaio-devel

  %if %{enable_cluster}

  BuildRequires: corosynclib-devel >= %{corosync_version}
@@ -171,11 +171,6 @@ 

  %global configure_writecache --with-writecache=internal

  %endif

  

- # NOTE: Using CFLAGS and LDFLAGS would override the fedora default flags, thus

- # using paths here...

- export CPATH="%{_includedir}/readline5"

- export LIBRARY_PATH="%{_libdir}/readline5"

- 

  %configure --with-default-dm-run-dir=%{_default_dm_run_dir} --with-default-run-dir=%{_default_run_dir} --with-default-pid-dir=%{_default_pid_dir} --with-default-locking-dir=%{_default_locking_dir} --with-usrlibdir=%{_libdir} --enable-fsadm --enable-write_install --with-user= --with-group= --with-device-uid=0 --with-device-gid=6 --with-device-mode=0660 --enable-pkgconfig --enable-cmdlib --enable-dmeventd --enable-blkid_wiping %{?configure_cluster} %{?configure_cmirror} %{?configure_udev} %{?configure_thin} %{?configure_cache} %{?configure_lvmpolld} %{?configure_lockd_dlm} %{?configure_lockd_sanlock} %{?configure_lvmdbusd} %{?configure_dmfilemapd} %{?configure_writecache} %{?configure_vdo} --disable-silent-rules

  

  make %{?_smp_mflags}

no initial comment

Not quite sure about this. This is addressing Bug 511847. Newer readline is GPLv3, while lvm2 GPLv2. Are you a heavy lvm shell user?

Well, that was not at all clear from the changelog and looked like an accident
If you intend to keep it that way please make sure to include some comment about it in the spec file.

I am not sure about the legalities here. It would be ince to have a fedora-legal reference..

Sure, I will in the next build coming soon.

I'm kinda missing input from legal team about this license incompatibility. @spot would you like to comment please?

lvm2 now uses libedit aka editline, so no more relying on legacy compat library.

Pull-Request has been closed by mcsontos

2 years ago