#3 Update to 1.4.1
Merged 3 years ago by fnux. Opened 3 years ago by returntrip.
rpms/ returntrip/mako master  into  master

file modified
+1
@@ -1,3 +1,4 @@ 

  /v1.2.tar.gz

  /v1.3.tar.gz

  /v1.4.tar.gz

+ /v.1.4.1.tar.gz

file modified
+7 -2
@@ -1,6 +1,6 @@ 

  Name:       mako

- Version:    1.4

- Release:    2%{?dist}

+ Version:    1.4.1

+ Release:    1%{?dist}

  Summary:    Lightweight Wayland notification daemon

  Provides:   desktop-notification-daemon

  
@@ -26,6 +26,7 @@ 

  BuildRequires:  systemd-devel

  BuildRequires:  scdoc

  Requires:       dbus

+ Recommends:     jq

  %{?systemd_requires}

  

  %description
@@ -57,6 +58,7 @@ 

  %{_bindir}/mako

  %{_bindir}/makoctl

  %{_mandir}/man1/mako.1*

+ %{_mandir}/man5/mako.5*

  %{_mandir}/man1/makoctl.1*

  %{_userunitdir}/%{name}.service

  %{_datadir}/dbus-1/services/fr.emersion.mako.service
@@ -65,6 +67,9 @@ 

  %{_datadir}/zsh/site-functions/_mako*

  

  %changelog

+ * Tue May 19 2020 Stefano Figura <stefano@figura.im> - 1.4.1-1

+ - Upstream 1.4.1 release

+ 

  * Wed Jan 29 2020 Fedora Release Engineering <releng@fedoraproject.org> - 1.4-2

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild

  

file modified
+1 -1
@@ -1,1 +1,1 @@ 

- SHA512 (v1.4.tar.gz) = 6059103e3a0c0cca5b0f717fbd7522f9a13f3dd3d65fe674e65cc175122a3372041bee2050d253ccb47a2adaa1dfa3180a19276bcdcb20c1e00813d75e1b3683

+ SHA512 (v1.4.1.tar.gz) = 25b0f59645c1815d8bdba42cedd6f56163ff663cd801a534c4c725c99e9a8cc28aef1d2c899d30cca06f0c6ddfa4a8e6efa01e5e98091347bcfc80d596f16d43

I have only one doubt about this PR. I get two warnings when linting. Otherwise the package gets built and can be installed and run on Fedora 32.

fedpkg --release f32 lint
/var/home/returntrip/rpmbuild/BUILD/mako/mako.spec:5: W: unversioned-explicit-provides desktop-notification-daemon
mako.src:5: W: unversioned-explicit-provides desktop-notification-daemon
4 packages and 1 specfiles checked; 0 errors, 2 warnings.

This should not be a strong Requires, as jq is optional, use Recommends: instead.

rebased onto fd595b5

3 years ago

This should not be a strong Requires, as jq is optional, use Recommends: instead.

Thanks for the review! I have changed the spec file as suggested.

Thanks for the patch! Merging.

Pull-Request has been merged by fnux

3 years ago

@fnux It seems the build was failing due to the scdoc version: https://koji.fedoraproject.org/koji/buildinfo?buildID=1510346. Could you please push again? Thanks.