|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
From ad1e669b96a5d251c36384e89d535b9c712a6246 Mon Sep 17 00:00:00 2001
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
From: Marian Koncek <mkoncek@redhat.com>
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
Date: Thu, 5 Sep 2019 15:21:04 +0200
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
Subject: [PATCH 3/3] Remove dependency on powermock
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
---
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
.../StringSearchModelInterpolatorTest.java | 59 -------------------
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
1 file changed, 59 deletions(-)
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
diff --git a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
index b2612e540..20b7162e2 100644
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
--- a/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
+++ b/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/StringSearchModelInterpolatorTest.java
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
@@ -35,8 +35,6 @@
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
import static org.hamcrest.CoreMatchers.anyOf;
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
import static org.hamcrest.CoreMatchers.is;
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
import static org.junit.Assert.assertThat;
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-import static org.powermock.reflect.Whitebox.getField;
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-import static org.powermock.reflect.Whitebox.getInternalState;
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
/**
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
* @author jdcasey
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
@@ -344,63 +342,6 @@ public void testInterpolateObjectWithPomFile() throws Exception {
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
is(System.getProperty("user.dir") + File.separator + '.' + File.separator + "target"))));
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
}
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- public void testNotInterpolateObjectWithFile() throws Exception {
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
- Model model = new Model();
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- File baseDir = new File(System.getProperty("user.dir"));
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
- Properties p = new Properties();
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- ObjectWithNotInterpolatedFile obj = new ObjectWithNotInterpolatedFile(baseDir);
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
- StringSearchModelInterpolator interpolator = (StringSearchModelInterpolator) createInterpolator();
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- ModelBuildingRequest config = createModelBuildingRequest(p);
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
- SimpleProblemCollector collector = new SimpleProblemCollector();
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- interpolator.interpolateObject(obj, model, new File("."), config, collector);
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- assertProblemFree(collector);
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
- //noinspection unchecked
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- Map<Class<?>, ?> cache = (Map<Class<?>, ?>)
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- getField(StringSearchModelInterpolator.class, "CACHED_ENTRIES").get(null);
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- Object objCacheItem = cache.get(Object.class);
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- Object fileCacheItem = cache.get(File.class);
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- assertNotNull(objCacheItem);
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- assertNotNull(fileCacheItem);
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- assertThat(((Object[]) getInternalState(objCacheItem, "fields")).length, is(0));
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- assertThat(((Object[]) getInternalState(fileCacheItem, "fields")).length, is(0));
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
- }
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- public void testNotInterpolateFile() throws Exception {
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
- Model model = new Model();
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- File baseDir = new File(System.getProperty("user.dir"));
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
- Properties p = new Properties();
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
- StringSearchModelInterpolator interpolator = (StringSearchModelInterpolator) createInterpolator();
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- ModelBuildingRequest config = createModelBuildingRequest(p);
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
- SimpleProblemCollector collector = new SimpleProblemCollector();
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- interpolator.interpolateObject(baseDir, model, new File("."), config, collector);
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- assertProblemFree(collector);
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
- //noinspection unchecked
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- Map<Class<?>, ?> cache = (Map<Class<?>, ?>)
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- getField(StringSearchModelInterpolator.class, "CACHED_ENTRIES").get(null);
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- Object fileCacheItem = cache.get(File.class);
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- assertNotNull(fileCacheItem);
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
- assertThat(((Object[]) getInternalState(fileCacheItem, "fields")).length, is(0));
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
- }
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
-
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
public void testConcurrentInterpolation() throws Exception {
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
final Model model = new Model();
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
--
|
|
![](https://seccdn.libravatar.org/avatar/4a11670336054c6170cf84f382105c5185fc50a752919d2398b4281650c77e1e?s=16&d=retro) |
9baf7da |
2.39.2
|
|
![](https://seccdn.libravatar.org/avatar/e962bab8e9bfd6ccd5edc1af3729a59f46b3c4641845df430240ce2a52a18843?s=16&d=retro) |
0cc0d7a |
|