PR#26: build with -release 8 to avoid OpenJDK API incompatibility issues - rpms/maven

rpms / maven

#26 build with -release 8 to avoid OpenJDK API incompatibility issues

Closed 2 years ago by decathorpe. Opened 2 years ago by decathorpe.

Unknown source master into master

build with -release 8 to avoid OpenJDK API incompatibility issues

Fabio Valentini • 2 years ago

eae616c

maven.spec

file modified

+5 -2

		`@@ -7,7 +7,7 @@`
		`Name: maven`
		`Epoch: 1`
		`Version: 3.6.3`
		`- Release: 6%{?dist}`
		`+ Release: 7%{?dist}`
		`Summary: Java project management and project comprehension tool`
		`# maven itself is ASL 2.0`
		`# bundled slf4j is MIT`
		`@@ -213,7 +213,7 @@`


		`%build`
		`- %mvn_build -- -Dproject.build.sourceEncoding=UTF-8`
		`+ %mvn_build -- -Dproject.build.sourceEncoding=UTF-8 -Dmaven.compiler.release=8`

		`mkdir m2home`
		`(cd m2home`
		`@@ -293,6 +293,9 @@`


		`%changelog`
		`+ * Thu Oct 15 2020 Fabio Valentini <decathorpe@gmail.com> - 1:3.6.3-7`
		`+ - Build with -release 8 to avoid OpenJDK API incompatibility issues.`
		`+`
		`* Wed Sep 30 2020 Christopher Tubbs <ctubbsii@fedoraproject.org> - 1:3.6.3-6`
		`- Remove unneeded commons-logging from runtime class path (rhbz#1883751)`
		`- Also remove redundant commons-codec`

decathorpe commented 2 years ago

Hopefully fixes https://bugzilla.redhat.com/show_bug.cgi?id=1885300

decathorpe commented 2 years ago

This is not an issue in maven, but somewhere in its dependencies.
maven already compiles with source/target 1.7.

Pull-Request has been closed by decathorpe

2 years ago

ctubbsii commented 2 years ago

While Maven already builds with source/target 1.7, it should probably also have the maven.compiler.release property set to 1.7 as well, in order to ensure strict compiler compliance when building with newer JDKs. It may not fix the above bug. But, nevertheless should be done anyway.