#1 Fix flatpak build
Merged a year ago by kalev. Opened a year ago by yselkowitz.
rpms/ yselkowitz/media-player-info rawhide  into  rawhide

file modified
+3 -1
@@ -11,7 +11,9 @@ 

  BuildRequires: make

  BuildRequires:  pkgconfig(udev)

  BuildRequires:  python3

+ %if %{undefined flatpak}

  Requires:       udev

+ %endif



  media-player-info is a repository of data files describing media player
@@ -37,7 +39,7 @@ 


  %license COPYING


- /usr/share/media-player-info

+ %{_datadir}/media-player-info




udev nowadays is provided by systemd-udev, meaning that its either already installed as part of a booting system, but flatpaks use the host rather than their own instance. Flatpak builds also install into the /app prefix.

Please also merge into f38 branch, but no revbump or new build are needed.

Hm, I think udev might be required because of /usr/lib/udev directory ownership. Maybe it would be better to do a if !flatpak conditional here instead, so that the directory ownership doesn't regress for non-flatpak builds?

Nowadays udev is provided by systemd-udev, so would there be a bootable system without it?

In any case, I changed that to a conditional.

rebased onto 89fe44a

a year ago

Thanks! Yes, not sure if it's really needed. Another option would be to get something in the flatpak runtime to virtual provide udev and systemd-udev just to satisfy packages like this.

Anyway, let's merge this :) Looks good to me!

Pull-Request has been merged by kalev

a year ago