PR#1: Fix flatpak build - rpms/media-player-info

rpms / media-player-info

#1 Fix flatpak build

Merged a year ago by kalev. Opened a year ago by yselkowitz.

rpms/ yselkowitz/media-player-info rawhide into rawhide

Fix flatpak build

Yaakov Selkowitz • a year ago

89fe44a

media-player-info.spec

file modified

+3 -1

		`@@ -11,7 +11,9 @@`
		`BuildRequires: make`
		`BuildRequires: pkgconfig(udev)`
		`BuildRequires: python3`
		`+ %if %{undefined flatpak}`
		`Requires: udev`
		`+ %endif`

		`%description`
		`media-player-info is a repository of data files describing media player`
		`@@ -37,7 +39,7 @@`
		`%files`
		`%license COPYING`
		`%doc README NEWS AUTHORS`
		`- /usr/share/media-player-info`
		`+ %{_datadir}/media-player-info`
		`/usr/lib/udev/rules.d/*`
		`/usr/lib/udev/hwdb.d/20-usb-media-players.hwdb`

yselkowitz commented a year ago

udev nowadays is provided by systemd-udev, meaning that its either already installed as part of a booting system, but flatpaks use the host rather than their own instance. Flatpak builds also install into the /app prefix.

Please also merge into f38 branch, but no revbump or new build are needed.

kalev commented a year ago

Hm, I think udev might be required because of /usr/lib/udev directory ownership. Maybe it would be better to do a if !flatpak conditional here instead, so that the directory ownership doesn't regress for non-flatpak builds?

yselkowitz commented a year ago

Nowadays udev is provided by systemd-udev, so would there be a bootable system without it?

In any case, I changed that to a conditional.

rebased onto 89fe44a

a year ago

kalev commented a year ago

Thanks! Yes, not sure if it's really needed. Another option would be to get something in the flatpak runtime to virtual provide udev and systemd-udev just to satisfy packages like this.

Anyway, let's merge this :) Looks good to me!