#9 Use make macros
Opened a year ago by tstellar. Modified 8 months ago
rpms/ tstellar/mercurial make-macros  into  rawhide

file modified
+6 -2
@@ -1,7 +1,7 @@ 

  Summary: Mercurial -- a distributed SCM

  Name: mercurial

  Version: 5.4

- Release: 1%{?dist}

+ Release: 2%{?dist}

  

  # Release: 1.rc1%%{?dist}

  
@@ -190,7 +190,7 @@ 

  popd

  

  pushd contrib/chg

- make install DESTDIR=%{buildroot} PREFIX=%{_usr} MANDIR=%{_mandir}/man1

+ %make_install PREFIX=%{_usr} MANDIR=%{_mandir}/man1

  popd

  

  
@@ -322,6 +322,10 @@ 

  

  

  %changelog

+ * Mon Jul 13 2020 Tom Stellard <tstellar@redhat.com> - 5.4-2

+ - Use make macros

+ - https://fedoraproject.org/wiki/Changes/UseMakeBuildInstallMacro

+ 

  * Wed Jun  3 2020 Neal Becker <ndbecker2@gmail.com> - 5.4-1

  - Update to 5.4

  

This pull request was create automatically for the f33 change:
https://fedoraproject.org/wiki/Changes/UseMakeBuildInstallMacro

Please review the patch and if you approve the changes, merge it after the simple-koji-ci test passes.

This pull request will be automatically merged in 1 week if there are not objections.

https://docs.fedoraproject.org/en-US/packaging-guidelines still only mentions %make_install as being equal to make install. While the latter arguably is more explicit and readable. This change thus seems quite random. The opposite change would be equally good.

But I'm all for making the change if the guidelines have a clear preference for %make_install .