PR#1: Install zlib1.dll with executable permission - rpms/mingw-zlib

rpms / mingw-zlib

#1 Install zlib1.dll with executable permission

Opened 4 years ago by c72578. Modified 4 years ago

rpms/ c72578/mingw-zlib 2018-01-03_fix_zlib1.dll_permissions into rawhide

Install zlib1.dll with executable permission

Wolfgang Stöggl • 4 years ago

639280f

mingw-zlib.spec

file modified

+6 -3

		`@@ -2,7 +2,7 @@`

		`Name: mingw-zlib`
		`Version: 1.2.8`
		`- Release: 7%{?dist}`
		`+ Release: 8%{?dist}`
		`Summary: MinGW Windows zlib compression library`

		`License: zlib`
		`@@ -113,8 +113,8 @@`
		`%mingw_make_install DESTDIR=$RPM_BUILD_ROOT`

		`# Manually install the correct zlib.dll`
		`- install -m 0644 build_win32/.libs/zlib1.dll $RPM_BUILD_ROOT%{mingw32_bindir}/`
		`- install -m 0644 build_win64/.libs/zlib1.dll $RPM_BUILD_ROOT%{mingw64_bindir}/`
		`+ install -m 0655 build_win32/.libs/zlib1.dll $RPM_BUILD_ROOT%{mingw32_bindir}/`
		`+ install -m 0655 build_win64/.libs/zlib1.dll $RPM_BUILD_ROOT%{mingw64_bindir}/`

		`# Install the pkgconfig file`
		`install -m 0644 build_win32/zlib.pc $RPM_BUILD_ROOT%{mingw32_libdir}/pkgconfig/`
		`@@ -170,6 +170,9 @@`


		`%changelog`
		`+ * Wed Jan 03 2018 Wolfgang Stöggl <c72578@yahoo.de> - 1.2.8-8`
		`+ - Install zlib1.dll with executable permission (0655)`
		`+`
		`* Wed Jul 26 2017 Fedora Release Engineering <releng@fedoraproject.org> - 1.2.8-7`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild`

no initial comment

sailer commented 4 years ago

Why is this needed?

c72578 commented 4 years ago

The mingw dll files have the executable permission set in general.

ls /usr/i686-w64-mingw32/sys-root/mingw/bin/*.dll

...
-rwxr-xr-x. 1 root root 461781 Jul 27 14:49 /usr/i686-w64-mingw32/sys-root/mingw/bin/libpixman-1-0.dll
-rwxr-xr-x. 1 root root 210681 Jul 27 14:32 /usr/i686-w64-mingw32/sys-root/mingw/bin/libpng16-16.dll
-rwxr-xr-x. 1 root root 119369 Aug 22 15:45 /usr/i686-w64-mingw32/sys-root/mingw/bin/libssp-0.dll
-rwxr-xr-x. 1 root root 12055545 Aug 22 15:45 /usr/i686-w64-mingw32/sys-root/mingw/bin/libstdc++-6.dll
-rwxr-xr-x. 1 root root 19901 Jul 27 14:59 /usr/i686-w64-mingw32/sys-root/mingw/bin/libtermcap-0.dll
-rwxr-xr-x. 1 root root 53245 Jul 27 14:56 /usr/i686-w64-mingw32/sys-root/mingw/bin/libwinpthread-1.dll
-rwxr-xr-x. 1 root root 1172144 Jul 27 14:45 /usr/i686-w64-mingw32/sys-root/mingw/bin/libxml2-2.dll
-rw-r--r--. 1 root root 84940 Jul 27 15:01 /usr/i686-w64-mingw32/sys-root/mingw/bin/zlib1.dll

zlib1.dll is the only one here with 0644, the others are 0655

sailer commented 4 years ago

But it doesn't make sense, it's not host executable code

c72578 commented 4 years ago

Default behavior when building executables is that the executable permission is set. Independent if the executables are compiled for the host system or cross-compiled.

This is another example, from the mingw-zlib package:
libminizip-1.dll
which has the executable permission set. And the executable permission is not changed during rpm installation.