PR#4: Update to latest upstream release - Docker CE 19.03.2 - rpms/moby-engine

rpms / moby-engine

#4 Update to latest upstream release - Docker CE 19.03.2

Closed 3 years ago by jaruga. Opened 3 years ago by jaruga.

rpms/ jaruga/moby-engine feature/update-to-docker-ce-19.03.2 into master

Update to latest upstream release - Docker CE 19.03.2

Jun Aruga • 3 years ago

8703903

moby-engine.spec

file modified

+6 -3

		`@@ -15,7 +15,7 @@`

		`# moby / docker-ce / cli`
		`%global git_moby https://github.com/%{service_name}/%{service_name}-ce`
		`- %global commit_moby 0dd43dd87fd530113bf44c9bba9ad8b20ce4637f`
		`+ %global commit_moby 6a30dfca03664a0b6bf0646a7d389ee7d0318e6e`
		`%global shortcommit_moby %(c=%{commit_moby}; echo ${c:0:7})`

		`# docker-proxy / libnetwork`
		`@@ -29,8 +29,8 @@`
		`%global shortcommit_tini %(c=%{commit_tini}; echo ${c:0:7})`

		`Name: %{newname}-engine`
		`- Version: 18.09.8`
		`- Release: 2.ce.git%{shortcommit_moby}%{?dist}`
		`+ Version: 19.03.2`
		`+ Release: 1.ce.git%{shortcommit_moby}%{?dist}`
		`Summary: The open-source application container engine`
		`License: ASL 2.0`
		`# no golang / go-md2man for ppc64`
		`@@ -300,6 +300,9 @@`
		`%{_datadir}/nano/Dockerfile.nanorc`

		`%changelog`
		`+ * Mon Sep 30 2019 Jun Aruga <jaruga@redhat.com> - 19.03.2-1.ce.git6a30dfc`
		`+ - Update to latest upstream release - Docker CE 19.03.2`
		`+`
		`* Thu Jul 25 2019 Fedora Release Engineering <releng@fedoraproject.org> - 18.09.8-2.ce.git0dd43dd`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild`

jaruga commented 3 years ago

This PR is to update the latest stable version Docker CE 19.03.2.
See https://github.com/docker/docker-ce/releases

The modification is only moby-engine.spec file.
You can download wget https://github.com/docker/docker-ce/archive/6a30dfca03664a0b6bf0646a7d389ee7d0318e6e.tar.gz (Source0) on local to create the SRPM file.

I did following tests.

Koji scratch build ok: https://koji.fedoraproject.org/koji/taskinfo?taskID=37968375
rpmlint: one error. But it not a issue of this PR.

moby-engine.x86_64: E: statically-linked-binary /usr/libexec/docker/docker-init
The package installs a statically linked binary or object file.  Usually this
is a packaging bug. If not, contact your rpmlint distributor about this so
that this error gets included in the exception file for rpmlint and will not
be flagged as a packaging bug in the future (or add it to your local
configuration if you installed rpmlint from the source tarball).

Installation test on mock environment: ok

jaruga commented 3 years ago

Hello, ping.

jgillich commented 3 years ago

I tested your PR and it worked fine, but I ran into some (upstream) bugs, so I updated it to 19.0.5.

I'm having some issues with pagure, first I couldn't push (TIL new users don't get ssh git access), now I can't create a PR because the repo selection never loads. And I also forgot to carry over your initial commit. @jaruga Could you maybe just update this PR?

Here are my changes: https://src.fedoraproject.org/fork/jgillich/rpms/moby-engine/c/9aac0f2eba20f8a2cbdf3006ad93289c909a2503?branch=feature%2Fupdate-to-docker-ce-19.03.5

jaruga commented 3 years ago

Hi @jgillich , thank you for testing.

I think I am okay that I just close this PR, because of my branch: feature/update-to-docker-ce-19.03.2, that including version name: 19.03.2. 19.03.2 is not the latest version any more.

Seeing your commit https://src.fedoraproject.org/fork/jgillich/rpms/moby-engine/c/9aac0f2eba20f8a2cbdf3006ad93289c909a2503?branch=feature%2Fupdate-to-docker-ce-19.03.5 , it includes Mon Sep 30 2019 Jun Aruga <jaruga@redhat.com> - 19.03.2-1.ce.git6a30dfc in the changelog.
But you can just remove my changelog, and send your PR to upgrade to 19.0.5.

Thank you.

Pull-Request has been closed by jaruga

3 years ago

jgillich commented 3 years ago

Alright, I've submitted #5. Thanks!