PR#6: Remove fixed storage-driver - rpms/moby-engine

rpms / moby-engine

#6 Remove fixed storage-driver

Merged 3 years ago by olem. Opened 3 years ago by fgimenez.

rpms/ fgimenez/moby-engine remove-fixed-storage-driver into rawhide

Remove fixed storage-driver

Federico Gimenez • 3 years ago

11b75b6

docker.sysconfig

file modified

-1

		`@@ -3,7 +3,6 @@`
		`# Modify these options if you want to change the way the docker daemon runs`
		`OPTIONS="--selinux-enabled \`
		`--log-driver=journald \`
		`- --storage-driver=overlay2 \`
		`--live-restore \`
		`--default-ulimit nofile=1024:1024 \`
		`--init-path /usr/libexec/docker/docker-init \`

fgimenez commented 3 years ago

Instead of configuring the docker daemon to use a fixed storage-driver remove the setting and let it decide which one to use.

Trying to use the moby-engine package on a Fedora33 I was getting the error described here https://github.com/kubernetes-sigs/kind/issues/1988 because of the default btrfs filesystem, removing the storage-driver setting from docker's sysconfig fixes it.

olem commented 3 years ago

Thank you, I'll test it.

olem commented 3 years ago

Hi @fgimenez,

Sorry for the long delay. Actually, I added --storage-driver=overlay2 to fix an issue #1832301 which occurred when upgrading moby-engine from a very old version that used devicemapper.

I agree that it is best to not specify the storage driver, so I'll merge this PR. However, do you have an idea on how to fix the case of an update as mentioned in #1832301 ?

Pull-Request has been merged by olem

3 years ago

fgimenez commented 3 years ago

I agree that it is best to not specify the storage driver, so I'll merge this PR.

Awesome, thanks a lot!

However, do you have an idea on how to fix the case of an update as mentioned in #1832301 ?

Nope sorry, in this case I would add clear documentation about how to solve the issue when upgrading from a previous installation or any other situation in which the storage backend can inadvertently change, does that make sense?