#1 Update to new stable release 1.1.1 from new upstream
Opened a year ago by genodeftest. Modified 2 months ago
rpms/ genodeftest/moodbar master  into  master

Drop ldconfig scriptlets
Christian Stadelmann • 2 months ago  

@@ -1,13 +0,0 @@ 

- diff -urNad moodbar-0.1.2~/analyzer/main.c moodbar-0.1.2/analyzer/main.c

- --- moodbar-0.1.2~/analyzer/main.c	2006-10-12 01:43:30.000000000 -0400

- +++ moodbar-0.1.2/analyzer/main.c	2007-04-01 13:20:33.000000000 -0400

- @@ -262,6 +262,9 @@

-    GOptionContext *ctx;

-    GError *err = NULL;

-  

- +  // must be called before any other glib function is called

- +  if (!g_thread_supported ()) g_thread_init(NULL);

- +

-    ctx = g_option_context_new ("[INFILE] - Run moodbar analyzer");

-    g_option_context_add_group (ctx, gst_init_get_option_group ());

-    g_option_context_add_main_entries (ctx, entries, NULL);

file modified
+36 -22

@@ -1,49 +1,63 @@ 

  Name:           moodbar

- Version:        0.1.2

- Release:        21%{?dist}

- Summary:        Identifies the "mood" of your music files

+ Version:        1.1.1

+ Release:        1%{?dist}

+ Summary:        Audio timeline visualization

  

- License:        GPLv2+

- URL:            http://amarok.kde.org/wiki/Moodbar

- Source0:        http://pwsp.net/~qbob/moodbar-%{version}.tar.gz

+ License:        GPLv3

+ URL:            https://github.com/exaile/moodbar

+ Source0:        https://github.com/exaile/moodbar/releases/download/v%{version}/moodbar-%{version}.tar.xz

  

- # Fix a Glib crash, patch from Debian

- Patch0:         moodbar-0.1.2-glib.patch

+ BuildRequires:  meson

+ BuildRequires:  gcc-c++

  

+ BuildRequires:  pkgconfig(gstreamer-1.0)

+ BuildRequires:  pkgconfig(gstreamer-audio-1.0)

+ BuildRequires:  pkgconfig(fftw3)

+ BuildRequires:  pkgconfig(glib-2.0)

+ BuildRequires:  pkgconfig(gio-2.0)

  

- BuildRequires:  gcc

- BuildRequires:  gstreamer-devel, fftw-devel

+ # Requirements for testing the package

+ BuildRequires:  python3

+ BuildRequires:  python3-numpy

+ BuildRequires:  gstreamer1

  

  %description

- Moodbar is a program that takes a music file and generates a .mood file

- identifying the "mood" of the music.

- Amarok can then use it to figure out when something interesting happens

- in the song.

+ Moodbar is a music visualization method that assigns colors to different parts

+ of a track and presents them as a timeline.

+ Applied to a music player, the main goal is to help the user navigate within a

+ particular track.

+ For example, if the user wants to skip to the first chorus of a song, a good

+ moodbar implementation should be able to provide a hint of where this might

+ occur in the timeline.

  

  %prep

  %setup -q

- %patch0 -p1 -b .glib

  

  

  %build

- %configure --disable-static

- make %{?_smp_mflags}

+ %meson

+ %meson_build

  

  

  %install

- rm -rf $RPM_BUILD_ROOT

- make install INSTALL="%{__install} -p" DESTDIR=$RPM_BUILD_ROOT

- rm -f $RPM_BUILD_ROOT%{_libdir}/gstreamer-*/libmoodbar.la

+ %meson_install

  

  

+ %check

+ %meson_test

+ 

  

  %files

- %doc AUTHORS COPYING ChangeLog NEWS README TODO

  %{_bindir}/%{name}

- %{_libdir}/gstreamer-*/libmoodbar.so

  

  

  %changelog

+ * Sat Jun 22 2019 Christian Stadelmann <genodeftest@fedoraproject.org> - 1.1.1-1

+ - Update to new stable release with new upstream URL at the Exaile project

+ - Drop old patch, update license, update description

+ - Run tests

+ - Drop ldconfig scriptlets (thanks to leigh123linux)

+ 

  * Fri Feb 01 2019 Fedora Release Engineering <releng@fedoraproject.org> - 0.1.2-21

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild

  

  • Update to new stable release with new upstream URL at the Exaile project
  • Drop old patch, update license, update description
  • Enable running tests

2 new commits added

  • Merge branch 'master' of https://src.fedoraproject.org/forks/genodeftest/rpms/moodbar
  • Update to new stable release 1.0 from new upstream
a year ago

rebased onto 83be41c

a year ago

rebased onto ad505bc

a year ago

rebased onto 7a8e6e3

4 months ago

rebased onto 5163486

4 months ago

rebased onto 12c6c2e

2 months ago

Thanks for the review!

I don't see any ldconfig scriptlets. I only see %post and %postun scriptlets with ldconfig. From your link I don't see why these scriptlets should be removed. I don't see why they exist, though. As the package does not install any shared library nor modify /etc/ld.so.conf.d, it looks like this is safe to remove.

1 new commit added

  • Drop ldconfig scriptlets
2 months ago

According to the moodbar site 0.1.4 is a fork based on the old code

https://userbase.kde.org/Amarok/Manual/Various/Moodbar#Source_Downloads

@rdieter any thoughts on which fork is more valid?

I've contacted the other upstream at https://github.com/Mazhoon/moodbar and send an e-mail to both @leigh123linux , @rdieter in CC.