|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
6e11407 |
Talk about silly byte-shaving ... the "stock" value of STACK_MIN_SIZE
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
6e11407 |
does not work on s390x, and probably not on some other platforms either.
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
6e11407 |
Knock it up to twice the pre-5.0.33 value to have some margin for future
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
6e11407 |
changes in compiler, glibc, etc. Suspect this number if
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
6e11407 |
"execution_constants" regression test fails.
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
81f2dd6 |
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
0f4cc99 |
Note: STACK_MIN_SIZE has to be enough less than DEFAULT_THREAD_STACK / 8
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
0f4cc99 |
to provide some headroom, which means that its value can't be raised too much
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
0f4cc99 |
further without increasing the latter as well.
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
aec7501 |
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
c625e75 |
As of 5.1.33 the stock value is 16000, which might be enough ... or maybe
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
c625e75 |
not. For the moment, we keep this patch around for reference, but it's
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
c625e75 |
not being applied.
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
c625e75 |
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
aec7501 |
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
f5da580 |
diff -Naur mysql-5.1.30.orig/sql/mysql_priv.h mysql-5.1.30/sql/mysql_priv.h
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
f5da580 |
--- mysql-5.1.30.orig/sql/mysql_priv.h 2008-11-14 11:37:13.000000000 -0500
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
f5da580 |
+++ mysql-5.1.30/sql/mysql_priv.h 2009-01-13 11:07:35.000000000 -0500
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
f5da580 |
@@ -286,7 +286,7 @@
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
aec7501 |
Feel free to raise this by the smallest amount you can to get the
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
aec7501 |
"execution_constants" test to pass.
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
aec7501 |
*/
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
f5da580 |
-#define STACK_MIN_SIZE 12000 ///< Abort if less stack during eval.
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
f5da580 |
+#define STACK_MIN_SIZE 16384 ///< Abort if less stack during eval.
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
aec7501 |
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
aec7501 |
#define STACK_MIN_SIZE_FOR_OPEN 1024*80
|
|
![](https://seccdn.libravatar.org/avatar/6c1211feaa5e18692a12fe8e6828d399c6684a741f1ec4afcff9a614b1c9f86e?s=16&d=retro) |
f5da580 |
#define STACK_BUFF_ALLOC 352 ///< For stack overrun checks
|