PR#1: Update nodejs-http-errors to 1.7.3. - rpms/nodejs-http-errors

rpms / nodejs-http-errors

#1 Update nodejs-http-errors to 1.7.3.

Closed 3 years ago by sgallagh. Opened 3 years ago by tc01.

rpms/ tc01/nodejs-http-errors master into master

Ben Rosser • 3 years ago

7e7244d

.gitignore

file modified

		`@@ -1,3 +1,4 @@`
		`/1.3.1.tar.gz`
		`/1.4.0.tar.gz`
		`/1.6.2.tar.gz`
		`+ /1.7.3.tar.gz`

nodejs-http-errors.spec

file modified

+6 -2

		`@@ -4,8 +4,8 @@`
		`%global enable_tests 1`

		`Name: nodejs-http-errors`
		`- Version: 1.6.2`
		`- Release: 6%{?dist}`
		`+ Version: 1.7.3`
		`+ Release: 1%{?dist}`
		`Summary: Create HTTP errors for Express, Koa, Connect, etc. with ease`

		`License: MIT`
		`@@ -28,6 +28,7 @@`
		`BuildRequires: mocha`
		`BuildRequires: npm(depd)`
		`BuildRequires: npm(setprototypeof)`
		`+ BuildRequires: npm(toidentifier)`
		`%endif`

		`Requires: nodejs`
		`@@ -68,6 +69,9 @@`


		`%changelog`
		`+ * Wed Feb 19 2020 Ben Rosser <rosser.bjr@gmail.com> - 1.7.3-1`
		`+ - Update to latest upstream version, 1.7.3.`
		`+`
		`* Wed Jan 29 2020 Fedora Release Engineering <releng@fedoraproject.org> - 1.6.2-6`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild`

sources

file modified

		`@@ -1,1 +1,2 @@`
		`SHA512 (1.6.2.tar.gz) = 9f4ae8a73dd020e41993a569876c3f654376c17521b679062f3f20812602a7de8a8375a92c9ad721672c2e76024c1b8fea2cc52fda1bd425408f63476e6c4d90`
sgallagh commented 3 years ago Why are you still referencing the 1.6.2 tarball?
		`+ SHA512 (1.7.3.tar.gz) = 8be99b9bcade3873d3c3724af420e4bb516cf0cf3a74743bd6f6322201363165a1ec5279aa275216d5d81867a4c686ef6d58d58f0580b35ae74298924728fd89`

tc01 commented 3 years ago

This updates nodejs-http-errors to 1.7.3, now that nodejs-toidentifier has been built.

Can it be applied to Rawhide and F32? That will make the package installable for both of those, allowing dependent packages which are FTBFS to be fixed.

Thanks!

sgallagh commented on line 2 of sources 3 years ago

Why are you still referencing the 1.6.2 tarball?

sgallagh commented 3 years ago

Other than the extra tarball source, this looks fine. I'll merge it manually and drop the unnecessary entry in sources when I do.

sgallagh commented 3 years ago

Merged in ad2cfb2

Pull-Request has been closed by sgallagh

3 years ago

tc01 commented 3 years ago

Thanks @sgallagh! I guess I just ran fedpkg upload instead of fedpkg new-sources by mistake.

tc01 commented 3 years ago

Ah, crap. I was sure I did this, but apparently I forgot to check the other dependencies:

DEBUG util.py:596:   Problem 1: conflicting requests
DEBUG util.py:596:    - nothing provides (npm(depd) >= 1.1.2 with npm(depd) < 1.2) needed by nodejs-http-errors-1.7.3-1.fc33.noarch
DEBUG util.py:596:    - nothing provides (npm(setprototypeof) >= 1.1.1 with npm(setprototypeof) < 2) needed by nodejs-http-errors-1.7.3-1.fc33.noarch
DEBUG util.py:596:    - nothing provides (npm(statuses) >= 1.5.0 with npm(statuses) < 2) needed by nodejs-http-errors-1.7.3-1.fc33.noarch

All of these look like minor version bumps over what we currently have in Fedora (the first two, we ship 1.1.1 and 1.1.0 respectively), and none of these packages themselves have any dependencies. I can file PRs for those but it would probably be safe to nodejs_fixdep the problem here?