#2 Enable test suite run in %%check
Opened 2 months ago by defolos. Modified a month ago
rpms/ defolos/notmuch master  into  master

file modified
+1

@@ -33,3 +33,4 @@ 

  /notmuch-0.28.4.tar.gz

  /notmuch-0.29.tar.xz

  /notmuch-0.29.1.tar.xz

+ /database-v1.tar.xz

file modified
+24 -2

@@ -22,7 +22,8 @@ 

  Summary:        System for indexing, searching, and tagging email

  License:        GPLv3+

  URL:            https://notmuchmail.org/

- Source0:        https://notmuchmail.org/releases/notmuch-%{version}.tar.xz

+ Source0:        %{URL}/releases/notmuch-%{version}.tar.xz

+ Source1:        %{URL}/releases/test-databases/database-v1.tar.xz

  

  # These should be removed in Fedora 26

  Obsoletes:      notmuch-deliver < 0.19-5

@@ -34,6 +35,7 @@ 

  BuildRequires:  emacs-nox

  Buildrequires:  gcc gcc-c++

  BuildRequires:  glib libtool

+ BuildRequires:  texinfo

  %if 0%{?fedora} >= 27

  BuildRequires:  gmime30-devel

  %else

@@ -58,6 +60,13 @@ 

  BuildRequires:  python3-sphinx

  %endif

  

+ # test dependencies

+ BuildRequires:  dtach

+ BuildRequires:  valgrind-devel

+ BuildRequires:  gdb

+ # two tests need to parse the output of `man`

+ BuildRequires:  man

+ 

  %description

  Fast system for indexing, searching, and tagging email.  Even if you

  receive 12000 messages per month or have on the order of millions of

@@ -148,10 +157,14 @@ 

  %setup -q

  

  %build

+ export CFLAGS="%{optflags}"

+ export CXXFLAGS="%{optflags}"

  # The %%configure macro cannot be used because notmuch doesn't support

  # some arguments the macro adds to the ./configure call.

  ./configure --prefix=%{_prefix} --sysconfdir=%{_sysconfdir} \

     --libdir=%{_libdir} --mandir=%{_mandir} --includedir=%{_includedir} \

+    --datadir=%{_datadir} --libexecdir=%{_libexecdir} \

+    --localstatedir=%{_localstatedir} --infodir=%{_infodir} \

     --emacslispdir=%{_emacs_sitelispdir}

  make %{?_smp_mflags} CFLAGS="%{optflags} -fPIC"

  

@@ -203,8 +216,13 @@ 

  popd

  

  rm -f %{buildroot}/%{_datadir}/applications/mimeinfo.cache

+ # causes conflicts with the info package

+ rm -rf %{buildroot}/%{_infodir}/dir

+ 

+ %check

+ cp %{SOURCE1} test/test-databases

  

- ls -lR %{buildroot}%{_mandir}

+ make check V=1

  

  %ldconfig_scriptlets

  

@@ -239,6 +257,7 @@ 

  %{_mandir}/man1/notmuch-compact.1*

  %{_mandir}/man5/notmuch*.5*

  %{_mandir}/man7/notmuch*.7*

+ %{_infodir}/notmuch*.info*

  %{_libdir}/libnotmuch.so.5*

  

  %files devel

@@ -282,6 +301,9 @@ 

  %{_datadir}/vim/vimfiles/syntax/notmuch-show.vim

  

  %changelog

+ * Fri Jul 19 2019 Dan Čermák <dan.cermak@cgc-instruments.com> - 0.29.1-1

+ - Enable test suite run in %%check

+ 

  * Wed Jun 12 2019 Michael J Gruber <mjg@fedoraproject.org> - 0.29.1-1

  - Update to 0.29.1

  

file modified
+1

@@ -1,1 +1,2 @@ 

  SHA512 (notmuch-0.29.1.tar.xz) = 9b76a7c8c62cb67b64a0008f80a82eeecccd20267ddba67d4d96a768815466c305f154769947bb9526e02c7a1696faaf69e94b90007603b185589be0c7c2a5d8

+ SHA512 (database-v1.tar.xz) = e2d87373e00b65756d7fea40c54fb236d7a37ce839145c3afd99ab26efdc17796e540c021e2c24e521df2d0a01ccbf918994f87a0d83235ff9b109a51555b3d0

Apparantly this PR does two things:
- enable info pages
- enable test suite run in %check

Could you comment on the reasons for doing them?

  • enable info pages

These provide additional information about the usage of the notmuch commands and can be useful for users.

  • enable test suite run in %check

To verify that notmuch works as expected by upstream on Fedora (they only test on Debian/Ubuntu and not on anything RPM based).