PR#4: Rebuild for gdcm 2.8.9 - rpms/opencv

rpms / opencv

#4 Rebuild for gdcm 2.8.9

Merged 4 years ago by sergiomb. Opened 4 years ago by ankursinha.

rpms/ ankursinha/opencv f31 into f31

Rebuild for gdcm 2.8.9

Ankur Sinha (Ankur Sinha Gmail) • 4 years ago

1c95ab4

opencv.spec

file modified

+4 -1

		`@@ -59,7 +59,7 @@`

		`Name: opencv`
		`Version: 3.4.6`
		`- Release: 6%{?dist}`
		`+ Release: 7%{?dist}`
		`Summary: Collection of algorithms for computer vision`
		`# This is normal three clause BSD.`
		`License: BSD`
		`@@ -429,6 +429,9 @@`
		`%{_libdir}/libopencv_xphoto.so.%{abiver}*`

		`%changelog`
		`+ * Sat Sep 21 2019 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 3.4.6-7`
		`+ - Rebuild for GDCM 2.8.9`
		`+`
		`* Thu Jul 25 2019 Fedora Release Engineering <releng@fedoraproject.org> - 3.4.6-6`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild`

ankursinha commented 4 years ago

Could we please merge and build this---I'll then push a combined update with gdcm 2.8.9 and all deps including opencv. Please note that this will require a build-root override. One is active now: https://bodhi.fedoraproject.org/overrides/gdcm-2.8.9-2.fc31

kwizart commented 4 years ago

I prefer that we coordinate with the opencv upates to 4.1.1
Is this update as announced ?

ankursinha commented 4 years ago

I prefer that we coordinate with the opencv upates to 4.1.1

Sure---any ETA for this?

I've tested an opencv 3.4.6 build in F31 with the new gdcm 2.8.9 and it builds fine:

https://koji.fedoraproject.org/koji/taskinfo?taskID=37785233

So while the 4.1.1 update is prepared (we don't know if it'll work with gdcm 2.8.9), could we merge, build, and push this version of opencv in an update along with the others now? If 4.1.1 builds fine with 2.8.9 later, that can be pushed as a new enhancement update?

Is this update as announced ?

Not yet---at the moment it's mainly about fixing FTBFS bugs. The GDCM update only affects three packages---and opencv is the only one not maintained by the neuro-sig. The others have been rebuilt and are ready for bodhi:

ITK
octave-dicom (was a long standing FTBFS and is currently uninstallable in F31).

This is only a patch release update in GDCM. Ideally there shouldnt be a soname bump here at all but upstream uses the software version for the soname version :disappointed: , and that's why the version of shared objects has changed. I've e-mailed them to ask what their system for API/ABI changes is:

https://sourceforge.net/p/gdcm/mailman/gdcm-developers/thread/20190921162811.pg2lr6mpj2tty2ip%40ankur-pc/#msg36768376

Hopefully, we won't need to rebuild all packages each time there's a new patch release in the future.