d19ba93
diff -up openssh-8.0p1/cipher-ctr.c.fips openssh-8.0p1/cipher-ctr.c
d19ba93
--- openssh-8.0p1/cipher-ctr.c.fips	2019-07-23 14:55:45.326525641 +0200
d19ba93
+++ openssh-8.0p1/cipher-ctr.c	2019-07-23 14:55:45.401526401 +0200
535d341
@@ -179,7 +179,8 @@ evp_aes_128_ctr(void)
535d341
 	aes_ctr.do_cipher = ssh_aes_ctr;
535d341
 #ifndef SSH_OLD_EVP
535d341
 	aes_ctr.flags = EVP_CIPH_CBC_MODE | EVP_CIPH_VARIABLE_LENGTH |
535d341
-	    EVP_CIPH_ALWAYS_CALL_INIT | EVP_CIPH_CUSTOM_IV;
535d341
+	    EVP_CIPH_ALWAYS_CALL_INIT | EVP_CIPH_CUSTOM_IV |
535d341
+	    EVP_CIPH_FLAG_FIPS;
535d341
 #endif
535d341
 	return (&aes_ctr);
535d341
 }
d19ba93
diff -up openssh-8.0p1/dh.c.fips openssh-8.0p1/dh.c
d19ba93
--- openssh-8.0p1/dh.c.fips	2019-04-18 00:52:57.000000000 +0200
d19ba93
+++ openssh-8.0p1/dh.c	2019-07-23 14:55:45.401526401 +0200
81a703d
@@ -152,6 +152,12 @@ choose_dh(int min, int wantbits, int max
81a703d
 	int best, bestcount, which, linenum;
81a703d
 	struct dhgroup dhg;
81a703d
 
81a703d
+	if (FIPS_mode()) {
81a703d
+		logit("Using arbitrary primes is not allowed in FIPS mode."
81a703d
+		    " Falling back to known groups.");
81a703d
+		return (dh_new_group_fallback(max));
81a703d
+	}
81a703d
+
81a703d
 	if ((f = fopen(_PATH_DH_MODULI, "r")) == NULL) {
81a703d
 		logit("WARNING: could not open %s (%s), using fixed modulus",
81a703d
 		    _PATH_DH_MODULI, strerror(errno));
81a703d
@@ -489,4 +495,38 @@ dh_estimate(int bits)
81a703d
 	return 8192;
81a703d
 }
81a703d
 
81a703d
+/*
81a703d
+ * Compares the received DH parameters with known-good groups,
81a703d
+ * which might be either from group14, group16 or group18.
81a703d
+ */
81a703d
+int
81a703d
+dh_is_known_group(const DH *dh)
81a703d
+{
81a703d
+	const BIGNUM *p, *g;
81a703d
+	const BIGNUM *known_p, *known_g;
81a703d
+	DH *known = NULL;
81a703d
+	int bits = 0, rv = 0;
81a703d
+
81a703d
+	DH_get0_pqg(dh, &p, NULL, &g);
81a703d
+	bits = BN_num_bits(p);
81a703d
+
81a703d
+	if (bits <= 3072) {
81a703d
+		known = dh_new_group14();
81a703d
+	} else if (bits <= 6144) {
81a703d
+		known = dh_new_group16();
81a703d
+	} else {
81a703d
+		known = dh_new_group18();
81a703d
+	}
81a703d
+
81a703d
+	DH_get0_pqg(known, &known_p, NULL, &known_g);
81a703d
+
81a703d
+	if (BN_cmp(g, known_g) == 0 &&
81a703d
+	    BN_cmp(p, known_p) == 0) {
81a703d
+		rv = 1;
81a703d
+	}
81a703d
+
81a703d
+	DH_free(known);
81a703d
+	return rv;
81a703d
+}
81a703d
+
81a703d
 #endif /* WITH_OPENSSL */
d19ba93
diff -up openssh-8.0p1/dh.h.fips openssh-8.0p1/dh.h
d19ba93
--- openssh-8.0p1/dh.h.fips	2019-04-18 00:52:57.000000000 +0200
d19ba93
+++ openssh-8.0p1/dh.h	2019-07-23 14:55:45.401526401 +0200
81a703d
@@ -43,6 +43,7 @@ DH	*dh_new_group_fallback(int);
81a703d
 
81a703d
 int	 dh_gen_key(DH *, int);
81a703d
 int	 dh_pub_is_valid(const DH *, const BIGNUM *);
81a703d
+int	 dh_is_known_group(const DH *);
81a703d
 
81a703d
 u_int	 dh_estimate(int);
81a703d
 
d19ba93
diff -up openssh-8.0p1/kex.c.fips openssh-8.0p1/kex.c
d19ba93
--- openssh-8.0p1/kex.c.fips	2019-07-23 14:55:45.395526340 +0200
d19ba93
+++ openssh-8.0p1/kex.c	2019-07-23 14:55:45.402526411 +0200
d19ba93
@@ -199,7 +199,10 @@ kex_names_valid(const char *names)
8028159
 	for ((p = strsep(&cp, ",")); p && *p != '\0';
8028159
 	    (p = strsep(&cp, ","))) {
8028159
 		if (kex_alg_by_name(p) == NULL) {
8028159
-			error("Unsupported KEX algorithm \"%.100s\"", p);
8028159
+			if (FIPS_mode())
8028159
+				error("\"%.100s\" is not allowed in FIPS mode", p);
8028159
+			else
8028159
+				error("Unsupported KEX algorithm \"%.100s\"", p);
8028159
 			free(s);
8028159
 			return 0;
8028159
 		}
d19ba93
diff -up openssh-8.0p1/kexgexc.c.fips openssh-8.0p1/kexgexc.c
d19ba93
--- openssh-8.0p1/kexgexc.c.fips	2019-04-18 00:52:57.000000000 +0200
d19ba93
+++ openssh-8.0p1/kexgexc.c	2019-07-23 14:55:45.402526411 +0200
535d341
@@ -28,6 +28,7 @@
8028159
 
132f8f8
 #ifdef WITH_OPENSSL
8028159
 
cb35953
+#include <openssl/crypto.h>
8028159
 #include <sys/types.h>
8028159
 
6cf9b8e
 #include <openssl/dh.h>
d19ba93
@@ -113,6 +114,10 @@ input_kex_dh_gex_group(int type, u_int32
81a703d
 		r = SSH_ERR_ALLOC_FAIL;
81a703d
 		goto out;
81a703d
 	}
81a703d
+	if (FIPS_mode() && dh_is_known_group(kex->dh) == 0) {
81a703d
+		r = SSH_ERR_INVALID_ARGUMENT;
81a703d
+		goto out;
81a703d
+	}
81a703d
 	p = g = NULL; /* belong to kex->dh now */
81a703d
 
81a703d
 	/* generate and send 'e', client DH public key */
d19ba93
diff -up openssh-8.0p1/myproposal.h.fips openssh-8.0p1/myproposal.h
d19ba93
--- openssh-8.0p1/myproposal.h.fips	2019-04-18 00:52:57.000000000 +0200
d19ba93
+++ openssh-8.0p1/myproposal.h	2019-07-23 14:55:45.402526411 +0200
51f5c1c
@@ -111,6 +111,20 @@
9dbec70
 	"rsa-sha2-256," \
9dbec70
 	"ssh-rsa"
9dbec70
 
9dbec70
+#define	KEX_FIPS_PK_ALG	\
51f5c1c
+	"ecdsa-sha2-nistp256-cert-v01@openssh.com," \
51f5c1c
+	"ecdsa-sha2-nistp384-cert-v01@openssh.com," \
51f5c1c
+	"ecdsa-sha2-nistp521-cert-v01@openssh.com," \
5eb2d51
+	"rsa-sha2-512-cert-v01@openssh.com," \
5eb2d51
+	"rsa-sha2-256-cert-v01@openssh.com," \
9dbec70
+	"ssh-rsa-cert-v01@openssh.com," \
51f5c1c
+	"ecdsa-sha2-nistp256," \
51f5c1c
+	"ecdsa-sha2-nistp384," \
51f5c1c
+	"ecdsa-sha2-nistp521," \
9dbec70
+	"rsa-sha2-512," \
9dbec70
+	"rsa-sha2-256," \
9dbec70
+	"ssh-rsa"
9dbec70
+
51f5c1c
 #define	KEX_SERVER_ENCRYPT \
51f5c1c
 	"chacha20-poly1305@openssh.com," \
51f5c1c
 	"aes128-ctr,aes192-ctr,aes256-ctr," \
51f5c1c
@@ -134,6 +142,27 @@
13bf5be
 
13bf5be
 #define KEX_CLIENT_MAC KEX_SERVER_MAC
8028159
 
8028159
+#define	KEX_FIPS_ENCRYPT \
8028159
+	"aes128-ctr,aes192-ctr,aes256-ctr," \
8028159
+	"aes128-cbc,3des-cbc," \
51f5c1c
+	"aes192-cbc,aes256-cbc,rijndael-cbc@lysator.liu.se," \
51f5c1c
+	"aes128-gcm@openssh.com,aes256-gcm@openssh.com"
51f5c1c
+#define KEX_DEFAULT_KEX_FIPS		\
51f5c1c
+	"ecdh-sha2-nistp256," \
51f5c1c
+	"ecdh-sha2-nistp384," \
51f5c1c
+	"ecdh-sha2-nistp521," \
51f5c1c
+	"diffie-hellman-group-exchange-sha256," \
51f5c1c
+	"diffie-hellman-group16-sha512," \
51f5c1c
+	"diffie-hellman-group18-sha512," \
eb751fd
+	"diffie-hellman-group14-sha256"
51f5c1c
+#define KEX_FIPS_MAC \
8028159
+	"hmac-sha1," \
8028159
+	"hmac-sha2-256," \
8028159
+	"hmac-sha2-512," \
8028159
+	"hmac-sha1-etm@openssh.com," \
8028159
+	"hmac-sha2-256-etm@openssh.com," \
8028159
+	"hmac-sha2-512-etm@openssh.com"
1900351
+
eaa7af2
 /* Not a KEX value, but here so all the algorithm defaults are together */
eaa7af2
 #define	SSH_ALLOWED_CA_SIGALGS	\
51f5c1c
 	"ecdsa-sha2-nistp256," \
d19ba93
diff -up openssh-8.0p1/readconf.c.fips openssh-8.0p1/readconf.c
d19ba93
--- openssh-8.0p1/readconf.c.fips	2019-07-23 14:55:45.334525723 +0200
d19ba93
+++ openssh-8.0p1/readconf.c	2019-07-23 14:55:45.402526411 +0200
51f5c1c
@@ -2179,11 +2179,16 @@ fill_default_options(Options * options)
bbf61da
 	all_key = sshkey_alg_list(0, 0, 1, ',');
eaa7af2
 	all_sig = sshkey_alg_list(0, 1, 1, ',');
51f5c1c
 	/* remove unsupported algos from default lists */
51f5c1c
-	def_cipher = match_filter_whitelist(KEX_CLIENT_ENCRYPT, all_cipher);
51f5c1c
-	def_mac = match_filter_whitelist(KEX_CLIENT_MAC, all_mac);
51f5c1c
-	def_kex = match_filter_whitelist(KEX_CLIENT_KEX, all_kex);
51f5c1c
-	def_key = match_filter_whitelist(KEX_DEFAULT_PK_ALG, all_key);
51f5c1c
-	def_sig = match_filter_whitelist(SSH_ALLOWED_CA_SIGALGS, all_sig);
51f5c1c
+	def_cipher = match_filter_whitelist((FIPS_mode() ?
51f5c1c
+	    KEX_FIPS_ENCRYPT : KEX_CLIENT_ENCRYPT), all_cipher);
51f5c1c
+	def_mac = match_filter_whitelist((FIPS_mode() ?
51f5c1c
+	    KEX_FIPS_MAC : KEX_CLIENT_MAC), all_mac);
51f5c1c
+	def_kex = match_filter_whitelist((FIPS_mode() ?
51f5c1c
+	    KEX_DEFAULT_KEX_FIPS : KEX_CLIENT_KEX), all_kex);
51f5c1c
+	def_key = match_filter_whitelist((FIPS_mode() ?
51f5c1c
+	    KEX_FIPS_PK_ALG : KEX_DEFAULT_PK_ALG), all_key);
51f5c1c
+	def_sig = match_filter_whitelist((FIPS_mode() ?
51f5c1c
+	    KEX_FIPS_PK_ALG : SSH_ALLOWED_CA_SIGALGS), all_sig);
51f5c1c
 #define ASSEMBLE(what, defaults, all) \
bbf61da
 	do { \
bbf61da
 		if ((r = kex_assemble_names(&options->what, \
d19ba93
diff -up openssh-8.0p1/sandbox-seccomp-filter.c.fips openssh-8.0p1/sandbox-seccomp-filter.c
d19ba93
--- openssh-8.0p1/sandbox-seccomp-filter.c.fips	2019-07-23 14:55:45.373526117 +0200
d19ba93
+++ openssh-8.0p1/sandbox-seccomp-filter.c	2019-07-23 14:55:45.402526411 +0200
9dbec70
@@ -137,6 +137,9 @@ static const struct sock_filter preauth_
6cf9b8e
 #ifdef __NR_open
17b491b
 	SC_DENY(__NR_open, EACCES),
6cf9b8e
 #endif
6cf9b8e
+#ifdef __NR_socket
17b491b
+	SC_DENY(__NR_socket, EACCES),
6cf9b8e
+#endif
6cf9b8e
 #ifdef __NR_openat
17b491b
 	SC_DENY(__NR_openat, EACCES),
6cf9b8e
 #endif
d19ba93
diff -up openssh-8.0p1/servconf.c.fips openssh-8.0p1/servconf.c
d19ba93
--- openssh-8.0p1/servconf.c.fips	2019-07-23 14:55:45.361525996 +0200
d19ba93
+++ openssh-8.0p1/servconf.c	2019-07-23 14:55:45.403526421 +0200
51f5c1c
@@ -208,11 +208,16 @@ assemble_algorithms(ServerOptions *o)
bbf61da
 	all_key = sshkey_alg_list(0, 0, 1, ',');
eaa7af2
 	all_sig = sshkey_alg_list(0, 1, 1, ',');
51f5c1c
 	/* remove unsupported algos from default lists */
51f5c1c
-	def_cipher = match_filter_whitelist(KEX_SERVER_ENCRYPT, all_cipher);
51f5c1c
-	def_mac = match_filter_whitelist(KEX_SERVER_MAC, all_mac);
51f5c1c
-	def_kex = match_filter_whitelist(KEX_SERVER_KEX, all_kex);
51f5c1c
-	def_key = match_filter_whitelist(KEX_DEFAULT_PK_ALG, all_key);
51f5c1c
-	def_sig = match_filter_whitelist(SSH_ALLOWED_CA_SIGALGS, all_sig);
51f5c1c
+	def_cipher = match_filter_whitelist((FIPS_mode() ?
51f5c1c
+	    KEX_FIPS_ENCRYPT : KEX_SERVER_ENCRYPT), all_cipher);
51f5c1c
+	def_mac = match_filter_whitelist((FIPS_mode() ?
51f5c1c
+	    KEX_FIPS_MAC : KEX_SERVER_MAC), all_mac);
51f5c1c
+	def_kex = match_filter_whitelist((FIPS_mode() ?
51f5c1c
+	    KEX_DEFAULT_KEX_FIPS : KEX_SERVER_KEX), all_kex);
51f5c1c
+	def_key = match_filter_whitelist((FIPS_mode() ?
51f5c1c
+	    KEX_FIPS_PK_ALG : KEX_DEFAULT_PK_ALG), all_key);
51f5c1c
+	def_sig = match_filter_whitelist((FIPS_mode() ?
51f5c1c
+	    KEX_FIPS_PK_ALG : SSH_ALLOWED_CA_SIGALGS), all_sig);
51f5c1c
 #define ASSEMBLE(what, defaults, all) \
bbf61da
 	do { \
51f5c1c
 		if ((r = kex_assemble_names(&o->what, defaults, all)) != 0) \
d19ba93
diff -up openssh-8.0p1/ssh.c.fips openssh-8.0p1/ssh.c
d19ba93
--- openssh-8.0p1/ssh.c.fips	2019-07-23 14:55:45.378526168 +0200
d19ba93
+++ openssh-8.0p1/ssh.c	2019-07-23 14:55:45.403526421 +0200
eb546ec
@@ -76,6 +76,7 @@
8028159
 #include <openssl/evp.h>
8028159
 #include <openssl/err.h>
1900351
 #endif
cb35953
+#include <openssl/crypto.h>
8028159
 #include "openbsd-compat/openssl-compat.h"
8028159
 #include "openbsd-compat/sys-queue.h"
8028159
 
d19ba93
@@ -614,6 +626,10 @@ main(int ac, char **av)
fbd5f1b
 		dump_client_config(&options, host);
fbd5f1b
 		exit(0);
fbd5f1b
 	}
fbd5f1b
+
8028159
+	if (FIPS_mode()) {
ee9cb00
+		debug("FIPS mode initialized");
8028159
+	}
fbd5f1b
 
fbd5f1b
 	/* Expand SecurityKeyProvider if it refers to an environment variable */
fbd5f1b
 	if (options.sk_provider != NULL && *options.sk_provider == '$' &&
d19ba93
diff -up openssh-8.0p1/sshconnect2.c.fips openssh-8.0p1/sshconnect2.c
d19ba93
--- openssh-8.0p1/sshconnect2.c.fips	2019-07-23 14:55:45.336525743 +0200
d19ba93
+++ openssh-8.0p1/sshconnect2.c	2019-07-23 14:55:45.403526421 +0200
3f55133
@@ -44,6 +44,8 @@
8028159
 #include <vis.h>
8028159
 #endif
8028159
 
cb35953
+#include <openssl/crypto.h>
8028159
+
8028159
 #include "openbsd-compat/sys-queue.h"
8028159
 
8028159
 #include "xmalloc.h"
57ba1bd
@@ -198,36 +203,41 @@ ssh_kex2(struct ssh *ssh, char *host, st
8028159
 
def1deb
 #if defined(GSSAPI) && defined(WITH_OPENSSL)
8028159
 	if (options.gss_keyex) {
def1deb
-		/* Add the GSSAPI mechanisms currently supported on this
8028159
-		 * client to the key exchange algorithm proposal */
def1deb
-		orig = myproposal[PROPOSAL_KEX_ALGS];
132f8f8
-
57ba1bd
-		if (options.gss_server_identity) {
def1deb
-			gss_host = xstrdup(options.gss_server_identity);
57ba1bd
-		} else if (options.gss_trust_dns) {
def1deb
-			gss_host = remote_hostname(ssh);
57ba1bd
-			/* Fall back to specified host if we are using proxy command
57ba1bd
-			 * and can not use DNS on that socket */
57ba1bd
-			if (strcmp(gss_host, "UNKNOWN") == 0) {
57ba1bd
-				free(gss_host);
57ba1bd
-				gss_host = xstrdup(host);
57ba1bd
-			}
57ba1bd
-		} else {
def1deb
-			gss_host = xstrdup(host);
57ba1bd
-		}
132f8f8
-
bc4ef0f
-		gss = ssh_gssapi_client_mechanisms(gss_host,
bc4ef0f
-		    options.gss_client_identity, options.gss_kex_algorithms);
132f8f8
-		if (gss) {
132f8f8
-			debug("Offering GSSAPI proposal: %s", gss);
def1deb
-			xasprintf(&myproposal[PROPOSAL_KEX_ALGS],
132f8f8
-			    "%s,%s", gss, orig);
def1deb
-
def1deb
-			/* If we've got GSSAPI algorithms, then we also support the
def1deb
-			 * 'null' hostkey, as a last resort */
def1deb
-			orig = myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS];
def1deb
-			xasprintf(&myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS],
def1deb
-			    "%s,null", orig);
8028159
+		if (FIPS_mode()) {
8028159
+			logit("Disabling GSSAPIKeyExchange. Not usable in FIPS mode");
8028159
+			options.gss_keyex = 0;
8028159
+		} else {
8028159
+			/* Add the GSSAPI mechanisms currently supported on this
8028159
+			 * client to the key exchange algorithm proposal */
def1deb
+			orig = myproposal[PROPOSAL_KEX_ALGS];
132f8f8
+
57ba1bd
+			if (options.gss_server_identity) {
def1deb
+				gss_host = xstrdup(options.gss_server_identity);
57ba1bd
+			} else if (options.gss_trust_dns) {
def1deb
+				gss_host = remote_hostname(ssh);
57ba1bd
+				/* Fall back to specified host if we are using proxy command
57ba1bd
+				 * and can not use DNS on that socket */
57ba1bd
+				if (strcmp(gss_host, "UNKNOWN") == 0) {
57ba1bd
+					free(gss_host);
57ba1bd
+					gss_host = xstrdup(host);
57ba1bd
+				}
57ba1bd
+			} else {
def1deb
+				gss_host = xstrdup(host);
57ba1bd
+			}
132f8f8
+
bc4ef0f
+			gss = ssh_gssapi_client_mechanisms(gss_host,
bc4ef0f
+			    options.gss_client_identity, options.gss_kex_algorithms);
8028159
+			if (gss) {
8028159
+				debug("Offering GSSAPI proposal: %s", gss);
def1deb
+				xasprintf(&myproposal[PROPOSAL_KEX_ALGS],
8028159
+				    "%s,%s", gss, orig);
def1deb
+
def1deb
+				/* If we've got GSSAPI algorithms, then we also support the
def1deb
+				 * 'null' hostkey, as a last resort */
def1deb
+				orig = myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS];
def1deb
+				xasprintf(&myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS],
def1deb
+				    "%s,null", orig);
8028159
+			}
8028159
 		}
8028159
 	}
8028159
 #endif
d19ba93
diff -up openssh-8.0p1/sshd.c.fips openssh-8.0p1/sshd.c
d19ba93
--- openssh-8.0p1/sshd.c.fips	2019-07-23 14:55:45.398526371 +0200
d19ba93
+++ openssh-8.0p1/sshd.c	2019-07-23 14:55:45.403526421 +0200
1900351
@@ -66,6 +66,7 @@
1900351
 #include <grp.h>
1900351
 #include <pwd.h>
1900351
 #include <signal.h>
1900351
+#include <syslog.h>
1900351
 #include <stdarg.h>
1900351
 #include <stdio.h>
1900351
 #include <stdlib.h>
eb546ec
@@ -77,6 +78,7 @@
8028159
 #include <openssl/dh.h>
8028159
 #include <openssl/bn.h>
8028159
 #include <openssl/rand.h>
cb35953
+#include <openssl/crypto.h>
8028159
 #include "openbsd-compat/openssl-compat.h"
1900351
 #endif
8028159
 
eb546ec
@@ -1529,6 +1532,7 @@ main(int ac, char **av)
8028159
 #endif
8028159
 	__progname = ssh_get_progname(av[0]);
8028159
 
eaa7af2
+	OpenSSL_add_all_algorithms();
8028159
 	/* Save argv. Duplicate so setproctitle emulation doesn't clobber it */
8028159
 	saved_argc = ac;
8028159
 	rexec_argc = ac;
d19ba93
@@ -1992,6 +2007,10 @@ main(int ac, char **av)
8028159
 	/* Reinitialize the log (because of the fork above). */
8028159
 	log_init(__progname, options.log_level, options.log_facility, log_stderr);
8028159
 
8028159
+	if (FIPS_mode()) {
ee9cb00
+		debug("FIPS mode initialized");
8028159
+	}
8028159
+
8028159
 	/* Chdir to the root directory so that the current disk can be
8028159
 	   unmounted if desired. */
8028159
 	if (chdir("/") == -1)
d19ba93
@@ -2382,10 +2401,14 @@ do_ssh2_kex(struct ssh *ssh)
8028159
 	if (strlen(myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS]) == 0)
8028159
 		orig = NULL;
8028159
 
8028159
-	if (options.gss_keyex)
8028159
-		gss = ssh_gssapi_server_mechanisms();
8028159
-	else
8028159
-		gss = NULL;
8028159
+	if (options.gss_keyex) {
8028159
+		if (FIPS_mode()) {
8028159
+			logit("Disabling GSSAPIKeyExchange. Not usable in FIPS mode");
8028159
+			options.gss_keyex = 0;
8028159
+		} else {
8028159
+			gss = ssh_gssapi_server_mechanisms();
8028159
+		}
8028159
+	}
8028159
 
8028159
 	if (gss && orig)
8028159
 		xasprintf(&newstr, "%s,%s", gss, orig);
d19ba93
diff -up openssh-8.0p1/sshkey.c.fips openssh-8.0p1/sshkey.c
d19ba93
--- openssh-8.0p1/sshkey.c.fips	2019-07-23 14:55:45.398526371 +0200
d19ba93
+++ openssh-8.0p1/sshkey.c	2019-07-23 14:55:45.404526431 +0200
6cf9b8e
@@ -34,6 +34,7 @@
1900351
 #include <openssl/evp.h>
1900351
 #include <openssl/err.h>
1900351
 #include <openssl/pem.h>
cb35953
+#include <openssl/crypto.h>
132f8f8
 #endif
1900351
 
1900351
 #include "crypto_api.h"
44e2032
@@ -57,6 +58,7 @@
36fef56
 #define SSHKEY_INTERNAL
84d3989
 #include "sshkey.h"
84d3989
 #include "match.h"
9dbec70
+#include "log.h"
51f5c1c
 #include "ssh-sk.h"
84d3989
 
36fef56
 #ifdef WITH_XMSS
d19ba93
@@ -1591,6 +1593,8 @@ rsa_generate_private_key(u_int bits, RSA
1900351
 	}
1900351
 	if (!BN_set_word(f4, RSA_F4) ||
1900351
 	    !RSA_generate_key_ex(private, bits, f4, NULL)) {
1900351
+			if (FIPS_mode())
1900351
+				logit("%s: the key length might be unsupported by FIPS mode approved key generation method", __func__);
1900351
 		ret = SSH_ERR_LIBCRYPTO_ERROR;
1900351
 		goto out;
1900351
 	}
d19ba93
diff -up openssh-8.0p1/ssh-keygen.c.fips openssh-8.0p1/ssh-keygen.c
d19ba93
--- openssh-8.0p1/ssh-keygen.c.fips	2019-07-23 14:55:45.391526300 +0200
d19ba93
+++ openssh-8.0p1/ssh-keygen.c	2019-07-23 14:57:54.118830056 +0200
d19ba93
@@ -199,6 +199,12 @@ type_bits_valid(int type, const char *na
36fef56
 #endif
36fef56
 	}
36fef56
 #ifdef WITH_OPENSSL
9dbec70
+	if (FIPS_mode()) {
9dbec70
+		if (type == KEY_DSA)
9dbec70
+			fatal("DSA keys are not allowed in FIPS mode");
9dbec70
+		if (type == KEY_ED25519)
9dbec70
+			fatal("ED25519 keys are not allowed in FIPS mode");
9dbec70
+	}
5b55d09
 	switch (type) {
5b55d09
 	case KEY_DSA:
5b55d09
 		if (*bitsp != 1024)
d19ba93
@@ -1029,9 +1035,17 @@ do_gen_all_hostkeys(struct passwd *pw)
d19ba93
 			first = 1;
d19ba93
 			printf("%s: generating new host keys: ", __progname);
d19ba93
 		}
d19ba93
+		type = sshkey_type_from_name(key_types[i].key_type);
d19ba93
+
d19ba93
+		/* Skip the keys that are not supported in FIPS mode */
d19ba93
+		if (FIPS_mode() && (type == KEY_DSA || type == KEY_ED25519)) {
d19ba93
+			logit("Skipping %s key in FIPS mode",
d19ba93
+			    key_types[i].key_type_display);
d19ba93
+			goto next;
d19ba93
+		}
d19ba93
+
d19ba93
 		printf("%s ", key_types[i].key_type_display);
d19ba93
 		fflush(stdout);
d19ba93
-		type = sshkey_type_from_name(key_types[i].key_type);
d19ba93
 		if ((fd = mkstemp(prv_tmp)) == -1) {
5cd9552
 			error("Could not save your private key in %s: %s",
5cd9552
			    prv_tmp, strerror(errno));