#1 Extension Directory Ownership
Merged a month ago by carlwgeorge. Opened a month ago by bex.
rpms/ bex/pass extension_paths  into  master

file modified
+7

@@ -44,6 +44,8 @@ 

       MANDIR=%{_mandir} WITH_ALLCOMP="yes" \

       install

  install -D -p -m 0755 contrib/dmenu/passmenu %{buildroot}%{_bindir}/passmenu

+ # Used by extensions

+ mkdir -p %{buildroot}%{_prefix}/lib/password-store/extensions

  

  %check

  make test

@@ -55,12 +57,17 @@ 

  %{_datadir}/fish/vendor_completions.d/pass.fish

  %{_datadir}/zsh/site-functions/_pass

  %doc %{_mandir}/man1/*

+ %dir %{_prefix}/lib/password-store

+ %dir %{_prefix}/lib/password-store/extensions

  

  %files -n passmenu

  %doc contrib/dmenu/README.md

  %{_bindir}/passmenu

  

  %changelog

+ * Tue May 21 2019 Brian Exelbierd <bexelbie@redhat.com> - 1.7.3-2

+ - Add pass extension directories

+ 

  * Fri Feb 01 2019 Fedora Release Engineering <releng@fedoraproject.org> - 1.7.3-2

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild

  

Extensions, like pass-otp and pass-pwned need directories
to land in. Extensions require pass

We don't need this command, the next one will create the full path.

Can you prefix both of these with %dir just to be explicit that pass only owns the directories? I could see an upstream change that causes these to accidentally include a new file.

rebased onto 60d9f88

a month ago

rebased onto 109ef6a

a month ago

Great suggestion! Once you address the comments I made on the changes I'll be happy to merge.

@carlwgeorge thanks for catching my mkdir -p brain slip. I think this update addresses your comments.

Pull-Request has been merged by carlwgeorge

a month ago

Whoops, I can't build this because the NVR is the same. I'll bump the release in another commit.

Sorry about that - I am still a packaging novice in so many ways :)

No worries, I should have noticed before I hit the merge button. Already fixed. Here are the updates.