PR#2: Rebase to 8.45 - rpms/pcre - src.fedoraproject.org

rpms / pcre

#2 Rebase to 8.45

Merged 2 years ago by ljavorsk. Opened 2 years ago by c72578.

rpms/ c72578/pcre 2021-07-28_8.45_bump into rawhide

Wolfgang Stöggl • 2 years ago

c1d8847

.gitignore

file modified

		`@@ -36,3 +36,5 @@`
		`/pcre-8.43.tar.bz2`
		`/pcre-8.44.tar.bz2`
		`/pcre-8.44.tar.bz2.sig`
		`+ /pcre-8.45.tar.bz2`
		`+ /pcre-8.45.tar.bz2.sig`

pcre.spec

file modified

+5 -2

		`@@ -1,8 +1,8 @@`
		`# Is this a stable/testing release:`
		`#%%global rcversion RC1`
		`Name: pcre`
		`- Version: 8.44`
		`- Release: %{?rcversion:0.}3%{?rcversion:.%rcversion}%{?dist}.2`
		`+ Version: 8.45`
		`+ Release: %{?rcversion:0.}1%{?rcversion:.%rcversion}%{?dist}`
		`%global myversion %{version}%{?rcversion:-%rcversion}`
		`Summary: Perl-compatible regular expression library`
		`## Source package only:`
		`@@ -231,6 +231,9 @@`
		`%{_mandir}/man1/pcretest.*`

		`%changelog`
		`+ * Wed Jul 28 2021 Wolfgang Stöggl <c72578@yahoo.de> - 8.45-1`
		`+ - Rebase to 8.45`
		`+`
		`* Thu Jul 22 2021 Fedora Release Engineering <releng@fedoraproject.org> - 8.44-3.2`
		`- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild`

sources

file modified

+2 -2

		`@@ -1,2 +1,2 @@`
		`- SHA512 (pcre-8.44.tar.bz2) = f26d850aab5228799e58ac8c2306fb313889332c39e29b118ef1de57677c5c90f970d68d3f475cabc64f8b982a77f04eca990ff1057f3ccf5e19bd137997c4ac`
		`- SHA512 (pcre-8.44.tar.bz2.sig) = 252e33b3cffd3b0133618ea896a19c86c816323523ca445d7fd026f08fd31e7a129c25fa3f5e9584939354b86f26eb0db850e1ad4ac56640493f71db454d46ac`
		`+ SHA512 (pcre-8.45.tar.bz2) = 91bff52eed4a2dfc3f3bfdc9c672b88e7e2ffcf3c4b121540af8a4ae8c1ce05178430aa6b8000658b9bb7b4252239357250890e20ceb84b79cdfcde05154061a`
		`+ SHA512 (pcre-8.45.tar.bz2.sig) = 8dc7deb003f5454441f6b3f0c0d73bb1d1b32e518552fb80fb461c26ddddfcd68574549953e971e3f460b22f56dc6c65432dd67777adc90fb279501701e53f58`

no initial comment

ljavorsk commented 2 years ago

Hi Wolfgang,

Thank you for your contribution.

Could you just please change the changelog and the commit message to something like 'Rebase to 8.45'?
Also, reference the BZ which is tracking this rebase (BZ#1972322)

We use the word bump when we bump the Release for rebuild, so this could be misleading to us.

Thank you

Edited 2 years ago by ljavorsk

rebased onto 90dd64c

2 years ago

c72578 commented 2 years ago

Hi Lukas,

Thanks for your feedback.
I have just amended the changelog entry and the commit message to ' Rebase to 8.45'.

ljavorsk commented 2 years ago

Thank you and could you also please reference the BZ which is tracking this rebase (BZ#1972322).

Add it into the commit under the 'Rebase to 8.45'

rebased onto c1d8847

2 years ago

c72578 commented 2 years ago

OK, #1972322 has been added to the commit message.

mschorm commented 2 years ago

I confirm that:
* the PR LGTM
* the package builds
* I wasn't able to find any error messages in the build log

It still might be a good idea to do:
* API / ABI diff to check for suprises
* dnf upgrade testing and after-reboot testing of the packages depending on pcre

ljavorsk commented 2 years ago

I stuffed pkgdiff with the old and new tarballs and RPMs and these are the complete diffs (just select one and look at the changes_report.html file):
https://ljavorsk.fedorapeople.org/pkgdiff_reports/

I don't see anything that would raise a flag for me, please double check it if you can.

mschorm commented 2 years ago

Thank you for the pkgdiff report.
I too haven't found anything that would look suspicious.

Looks like the DNF tests & after-reboot tests are the last one we need to check :)

ljavorsk commented 2 years ago

I've tried to install and reboot the machine with a new PCRE package (SUCCESSFUL)

However, I can't imagine how to test all of the dependent packages (there are 263 packages depending on pcre)

mschorm commented 2 years ago

However, I can't imagine how to test all of the dependent packages (there are 263 packages depending on pcre)

Install all of the packages (or atleast most fo them in case of conflicts) that requires this package ono the system and reboot it.
Take a look at the systemd journal after the reboot for suspicious behaviour caused by pcre update.

That's the best we can do IMO.

ljavorsk commented 2 years ago

Install all of the packages (or atleast most fo them in case of conflicts) that requires this package ono the system and reboot it.
Take a look at the systemd journal after the reboot for suspicious behaviour caused by pcre update.

Tested. Journal doesn't complain about anything

This rebase is good to go by me