#1 Spec file cleanups: Use_make_build and make_install macros, use NO_PACKLIST=1
Merged 4 years ago by pghmcfc. Opened 4 years ago by tstellar.
rpms/ tstellar/perl-B-Hooks-OP-Check spec-cleanup  into  master

file modified
+10 -6
@@ -1,7 +1,7 @@ 

  Name:           perl-B-Hooks-OP-Check

  Summary:        Wrap OP check callbacks

  Version:        0.22

- Release:        9%{?dist}

+ Release:        10%{?dist}

  License:        GPL+ or Artistic

  URL:            https://metacpan.org/release/B-Hooks-OP-Check

  Source0:        https://cpan.metacpan.org/modules/by-module/B/B-Hooks-OP-Check-%{version}.tar.gz
@@ -14,7 +14,7 @@ 

  BuildRequires:  perl-generators

  BuildRequires:  perl-interpreter

  BuildRequires:  perl(ExtUtils::Depends) >= 0.302

- BuildRequires:  perl(ExtUtils::MakeMaker)

+ BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76

  # Module Runtime

  BuildRequires:  perl(DynaLoader)

  BuildRequires:  perl(parent)
@@ -39,12 +39,11 @@ 

  %setup -q -n B-Hooks-OP-Check-%{version}

  

  %build

- perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}"

- make %{?_smp_mflags}

+ perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}" NO_PACKLIST=1 NO_PERLLOCAL=1

+ %{make_build}

  

  %install

- make pure_install DESTDIR=%{buildroot}

- find %{buildroot} -type f -name .packlist -delete

+ %{make_install}

  find %{buildroot} -type f -name '*.bs' -empty -delete

  %{_fixperms} -c %{buildroot}

  
@@ -63,6 +62,11 @@ 

  %{_mandir}/man3/B::Hooks::OP::Check.3*

  

  %changelog

+ * Mon May 04 2020 Tom Stellard <tstellar@redhat.com> - 0.22-10

+ - Spec file cleanups: Use_make_build and make_install macros, use NO_PACKLIST=1

+ - https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make

+ - https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker

+ 

  * Wed Jan 29 2020 Fedora Release Engineering <releng@fedoraproject.org> - 0.22-9

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild

  

Hi Tom, the Perl Tips URL is missing an "r" at the end:

<<< https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMake
>>> https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker

Could you fix that before submitting your next batch of PRs?

rebased onto 17fc64a

4 years ago

I've fixed the typo, thanks for catching that.

Pull-Request has been merged by pghmcfc

4 years ago