#1 Spec file cleanups: Use make_build and make_install macros
Merged 4 years ago by ppisar. Opened 4 years ago by tstellar.
rpms/ tstellar/perl-Digest-SHA spec-cleanup  into  master

file modified
+10 -4
@@ -10,7 +10,7 @@ 

  Name:           perl-Digest-SHA

  Epoch:          1

  Version:        6.02

- Release:        441%{?dist}

+ Release:        442%{?dist}

  Summary:        Perl extension for SHA-1/224/256/384/512

  License:        GPL+ or Artistic

  URL:            https://metacpan.org/release/Digest-SHA
@@ -77,11 +77,12 @@ 

  perl -MExtUtils::MakeMaker -e 'ExtUtils::MM_Unix->fixin(q{examples/dups})'

  

  %build

- perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 OPTIMIZE='%{optflags}'

- make %{?_smp_mflags}

+ perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 OPTIMIZE='%{optflags}' \

+                  NO_PERLLOCAL=1

+ %make_build

  

  %install

- make pure_install DESTDIR='%{buildroot}'

+ %make_install

  find '%{buildroot}' -type f -name '*.bs' -empty -delete

  %{_fixperms} -c '%{buildroot}'

  
@@ -97,6 +98,11 @@ 

  %{_mandir}/man3/Digest::SHA.3*

  

  %changelog

+ * Tue Feb 04 2020 Tom Stellard <tstellar@redhat.com> - 1:6.02-442

+ - Spec file cleanups: Use make_build and make_install macros

+ - https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make

+ - https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMake

+ 

  * Wed Jan 29 2020 Fedora Release Engineering <releng@fedoraproject.org> - 1:6.02-441

  - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild

  

Pull-Request has been merged by ppisar

4 years ago

Next time, please write the NO_PACKLIST=1 and NO_PERLLOCAL=1 together.

Also I believe it's a good idea to spell the %make_* macros with parentheses like %{make_build}. If the macro definition changes into a macro function, it would start ignoring any additional arguments.

Metadata