rpms / perl-Font-AFM

Clone
Source Code
GIT

#1 Use NimbusSans-Bold font for afm font metrics testing
Closed 3 years ago by zdohnal. Opened 3 years ago by zdohnal.
Unknown source master  into  rawhide

NimbusSans-Bold font is widely used (ghostscript works with it during printing or in file managers), so AFM font metrics testing using NimbusSans-Bold profits in showing a result for currently used fonts instead of older fonts like phvr from a2ps package.

Would you mind merging the commit to the rawhide?

Wouldn't it be better to BR: the package providing the file rather than the file itself ?
BuildRequires: urw-base35-nimbus-sans-fonts
rather than
BuildRequires: %{_datadir}/fonts/urw-base35/NimbusSans-Bold.afm

File requires are most costly to resolve than package requires and I'm not sure why this was a file requires in the first place.

Hi @xavierb ,

yes, that can be done. I'll update the PR.

Or rather open a new - I can't find a way how to rebase a PR in pagure...

1 new commit added

  • Require the package instead of a file
3 years ago

By force pushing (git push -f)?

@ppisar actually I didn't clone my fork to my machine, just forked pagure project and made changes there via Web UI. It looked quicker.

rebased onto 8eeba5c
3 years ago

I do not agree with any of these patches and will not apply them

Rationale: I consider using package deps instead of file deps to be insane and not helpful.

About the file dependency, here's the guideline:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies
This is a SHOULD NOT, not a MUST NOT, but this guideline was the reason why I suggested to use a package dependency rather than a file dependency.
Could you explain why you consider this to be insane and not helpful ?

Also, I'm not sure why you are objecting to the removal of the dependency on a2ps. You seem to agree to this removal in https://bugzilla.redhat.com/show_bug.cgi?id=1581656#c2

@corsepiu I'm willing to use a file dependency if it is required.

Please let me know if I should change something else.

I understand you want the best for your package as its maintainer and I truly thinks Font-AFM benefits from using NimbusSans-Bold instead of phvr, assuring font metric from Font-AFM works with the current fonts.

Thank you for reviewing the merge request and your work as a packager so far, Ralf!

@corsepiu I'll wait with changing PR till you and Xavier finish the discussion.

In my humble opinion I prefer a package dependency too - it will clearly tell the spec file reader what package you bring into buildroot/system.

However, you are the package maintainer, I'm willing to change the PR as you see fit.

1 new commit added

  • Revert "Use NimbusSans-Bold font for afm font metrics testing"
3 years ago

Creating a new PR.

Pull-Request has been closed by zdohnal
3 years ago
Powered by Pagure 5.13.3
Documentation • File an Issue • About this Instance • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.