#9 Fix cycle dependencies
Merged 2 years ago by mspacek. Opened 2 years ago by mspacek.
rpms/ mspacek/perl-HTTP-Daemon rawhide  into  rawhide

file modified
+11 -3
@@ -1,6 +1,9 @@ 

+ # Perform optional tests

+ %{bcond_without perl_HTTP_Daemon_enables_optional_test}

+ 

  Name:           perl-HTTP-Daemon

  Version:        6.14

- Release:        1%{?dist}

+ Release:        2%{?dist}

  Summary:        Simple HTTP server class

  License:        GPL+ or Artistic

  URL:            https://metacpan.org/release/HTTP-Daemon
@@ -31,16 +34,18 @@ 

  BuildRequires:  perl(Config)

  BuildRequires:  perl(File::Spec)

  BuildRequires:  perl(HTTP::Tiny) >= 0.042

- BuildRequires:  perl(LWP::RobotUA)

- BuildRequires:  perl(LWP::UserAgent)

  BuildRequires:  perl(Module::Metadata)

  BuildRequires:  perl(Test)

  BuildRequires:  perl(Test::More) >= 0.98

  BuildRequires:  perl(Test::Needs)

  BuildRequires:  perl(URI)

  # Optional tests:

+ %if %{with perl_HTTP_Daemon_enables_optional_test} && !%{defined %perl_bootstrap}

+ BuildRequires:  perl(LWP::RobotUA)

+ BuildRequires:  perl(LWP::UserAgent)

  # CPAN::Meta not helpful

  # CPAN::Meta::Prereqs not helpful

+ %endif

  Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))

  Requires:       perl(HTTP::Date) >= 6

  Requires:       perl(HTTP::Request) >= 6
@@ -109,6 +114,9 @@ 

  %{_libexecdir}/%{name}

  

  %changelog

+ * Tue Mar 22 2022 Michal Josef Špaček <mspacek@redhat.com> - 6.14-2

+ - Fix cycle dependencies (bug #2063824)

+ 

  * Fri Mar 04 2022 Michal Josef Špaček <mspacek@redhat.com> - 6.14-1

  - 6.14 bump

  - Package unit tests

no initial comment

It indeed fix the problem. Just it would be stylistically better to move the block down to an already existing "Optional tests" comment:

# Tests only:
BuildRequires:  perl(Config)
BuildRequires:  perl(File::Spec)
BuildRequires:  perl(HTTP::Tiny) >= 0.042
BuildRequires:  perl(LWP::RobotUA)
BuildRequires:  perl(LWP::UserAgent)
BuildRequires:  perl(Module::Metadata)
BuildRequires:  perl(Test)
BuildRequires:  perl(Test::More) >= 0.98
BuildRequires:  perl(Test::Needs)
BuildRequires:  perl(URI)
# Optional tests: ←
# CPAN::Meta not helpful
# CPAN::Meta::Prereqs not helpful

rebased onto 8b554cc

2 years ago

@ppisar Thanks for review. I updated PR.

Better. The best would be move "%end" after "# CPAN::Meta::Prereqs not helpful".

rebased onto 0c5eb04

2 years ago

Pull-Request has been merged by mspacek

2 years ago
Metadata