Blame ORLite-1.98-sqlite-vacuum.patch
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
Description: Fix cleanup in tests.
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
Since SQLite 3.15, VACUUM either needs no arguments, or the name of an
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
attached database.
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
.
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
From https://sqlite.org/lang_vacuum.html :
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
Compatibility Warning: The ability to vacuum attached databases was added
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
in version 3.15.0 (2016-10-14). Prior to that, a schema-name added to the
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
VACUUM statement would be silently ignored and the "main" schema would be
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
vacuumed.
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
.
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
That means that 'VACUUM ANALYZE' never did what it was probably supposed to
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
do.
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
.
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
Maybe 'VACUUM; ANALYZE' works as well. -- And besides this change in the
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
testsuite, the documentation for cleanup() in the POD would need to be
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
updated as well.
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
.
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
Origin: vendor
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
Bug-Debian: https://bugs.debian.org/841545
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
Author: gregor herrmann <gregoa@debian.org>
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
Last-Update: 2016-10-21
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
--- a/t/10_cleanup.t
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
+++ b/t/10_cleanup.t
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
@@ -29,7 +29,7 @@
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
use strict;
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
use ORLite {
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
file => '$file',
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
- cleanup => 'VACUUM ANALYZE',
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
+ cleanup => 'VACUUM',
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
};
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
1;
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
--- a/t/11_cleanup.t
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
+++ b/t/11_cleanup.t
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
@@ -29,7 +29,7 @@
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
use strict;
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
use ORLite {
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
file => '$file',
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
- cleanup => 'VACUUM ANALYZE',
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
+ cleanup => 'VACUUM',
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
};
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
|
|
![](https://seccdn.libravatar.org/avatar/50e0792c20934216c33ee9571c57d14de6336f83bebfcc8b954e53b728ddaf27?s=16&d=retro) |
15fd5c3 |
1;
|