PR#1: Remove runtime depencendy for Digest::MD5 - rpms/perl-Path-Tiny

rpms / perl-Path-Tiny

#1 Remove runtime depencendy for Digest::MD5

Merged 2 years ago by pghmcfc. Opened 2 years ago by mspacek.

rpms/ mspacek/perl-Path-Tiny rawhide into rawhide

Remove runtime depencendy for Digest::MD5

Michal Josef Špaček • 2 years ago

49551af

perl-Path-Tiny.spec

file modified

+5 -3

		`@@ -7,7 +7,7 @@`

		`Name: perl-Path-Tiny`
		`Version: 0.118`
		`- Release: 2%{?dist}`
		`+ Release: 3%{?dist}`
		`Summary: File path utility`
		`License: ASL 2.0`
		`URL: https://metacpan.org/release/Path-Tiny`
		`@@ -26,7 +26,6 @@`
		`BuildRequires: perl(constant)`
		`BuildRequires: perl(Cwd)`
		`BuildRequires: perl(Digest) >= 1.03`
		`- BuildRequires: perl(Digest::MD5)`
		`BuildRequires: perl(Digest::SHA) >= 5.45`
		`BuildRequires: perl(Encode)`
		`BuildRequires: perl(Exporter) >= 5.57`
		`@@ -44,6 +43,7 @@`
		`BuildRequires: perl(warnings::register)`
		`# Test Suite`
		`BuildRequires: perl(blib)`
		`+ BuildRequires: perl(Digest::MD5)`
		`BuildRequires: perl(File::Basename)`
		`BuildRequires: perl(File::Spec::Functions)`
		`BuildRequires: perl(File::Spec::Unix)`
		`@@ -62,7 +62,6 @@`
		Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
		`Requires: perl(Cwd)`
		`Requires: perl(Digest) >= 1.03`
		`- Requires: perl(Digest::MD5)`
		`Requires: perl(Digest::SHA) >= 5.45`
		`Requires: perl(Encode)`
		`Requires: perl(Fcntl)`
		`@@ -122,6 +121,9 @@`
		`%{_mandir}/man3/Path::Tiny.3*`

		`%changelog`
		`+ * Wed Jun 23 2021 Michal Josef Spacek <mspacek@redhat.com> - 0.118-3`
		`+ - Remove runtime depencendy for Digest::MD5`
		`+`
		`* Fri May 21 2021 Jitka Plesnikova <jplesnik@redhat.com> - 0.118-2`
		`- Perl 5.34 rebuild`

mspacek commented 2 years ago

There is no relation to Digest::MD5.
Only one Digest module is required and it's Digest::SHA, because default algorithm for digest() method is SHA-256 from this module.

ppisar commented 2 years ago

I also recommend moving "BuildRequires: perl(Digest::MD5)" from "Module Runtime" to "Test Suite" section in the spec file. In the end, that's the reason for the explicit "use Digest:MD5" at t/digest.t:11.