From 55de1af1622def628e3655dcbdfed7569118983d Mon Sep 17 00:00:00 2001 From: Emmanuel Seyman Date: Dec 02 2018 10:33:15 +0000 Subject: [PATCH 1/3] remove the Group tag (no longer needed) --- diff --git a/perl-Proc-PID-File.spec b/perl-Proc-PID-File.spec index 156391f..59ed70e 100644 --- a/perl-Proc-PID-File.spec +++ b/perl-Proc-PID-File.spec @@ -3,7 +3,7 @@ Version: 1.29 Release: 1%{?dist} Summary: Module to manage process id files License: GPLv2+ -Group: Development/Libraries + URL: https://metacpan.org/release/Proc-PID-File Source0: https://cpan.metacpan.org/authors/id/D/DM/DMITRI/Proc-PID-File-%{version}.tar.gz From 53d5e3a990d15e1736fb52ad5419619c51c69d3c Mon Sep 17 00:00:00 2001 From: Emmanuel Seyman Date: Dec 02 2018 11:09:23 +0000 Subject: [PATCH 2/3] add rpmlintrc to filter out false positive errors --- diff --git a/perl-Proc-PID-File.rpmlintrc b/perl-Proc-PID-File.rpmlintrc new file mode 100644 index 0000000..167d2e7 --- /dev/null +++ b/perl-Proc-PID-File.rpmlintrc @@ -0,0 +1,2 @@ +from Config import * +addFilter("spelling-error .* pidfiles"); From 02f49c580493e541da09292ca755374e35f955a4 Mon Sep 17 00:00:00 2001 From: Emmanuel Seyman Date: Dec 02 2018 11:23:11 +0000 Subject: [PATCH 3/3] patch Proc-PID-File to not emit warnings --- diff --git a/perl-Proc-PID-File-1.29-undef.patch b/perl-Proc-PID-File-1.29-undef.patch new file mode 100644 index 0000000..327574e --- /dev/null +++ b/perl-Proc-PID-File-1.29-undef.patch @@ -0,0 +1,14 @@ +Description: fix for undef input into regex match +Author: Alexander Zangerl +--- a/File.pm ++++ b/File.pm +@@ -285,7 +285,8 @@ sub read { + || die qq/Cannot open pid file "$self->{path}": $!\n/; + flock($fh, LOCK_EX | LOCK_NB) + || die qq/pid "$self->{path}" already locked: $!\n/; +- my ($pid) = <$fh> =~ /^(\d+)/; ++ my $maybe = <$fh>; ++ my ($pid) = $maybe =~ /^(\d+)/ if (defined $maybe); + close $fh if @_ == 1; + + $self->debug("read(\"$self->{path}\") = " . ($pid || "")); diff --git a/perl-Proc-PID-File.spec b/perl-Proc-PID-File.spec index 59ed70e..2d5f58b 100644 --- a/perl-Proc-PID-File.spec +++ b/perl-Proc-PID-File.spec @@ -6,6 +6,7 @@ License: GPLv2+ URL: https://metacpan.org/release/Proc-PID-File Source0: https://cpan.metacpan.org/authors/id/D/DM/DMITRI/Proc-PID-File-%{version}.tar.gz +Patch0: perl-Proc-PID-File-1.29-undef.patch BuildArch: noarch @@ -41,6 +42,7 @@ which are files that store a process identifier. %prep %setup -q -n Proc-PID-File-%{version} +%patch0 -p1 %build