890552a
From 9ac12f1967e091b504ac426a70fb41af0d9d44c2 Mon Sep 17 00:00:00 2001
6153f2b
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
6153f2b
Date: Mon, 3 Jun 2019 15:43:31 +0200
6153f2b
Subject: [PATCH] Adapt tests to Perl 5.30
6153f2b
MIME-Version: 1.0
6153f2b
Content-Type: text/plain; charset=UTF-8
6153f2b
Content-Transfer-Encoding: 8bit
6153f2b
890552a
Perl started to understand a numerical value of hexadecimal strings
890552a
like '0xF'. This happens since Perl commit:
6153f2b
6153f2b
    commit ce6f496d720f6206455628425320badd95b07372 (HEAD, refs/bisect/bad)
6153f2b
    Author: sisyphus <sisyphus1@optusnet.com.au>
6153f2b
    Date:   Wed Aug 1 22:33:38 2018 +1000
6153f2b
6153f2b
	PATCH: [perl #41202] text->float gives wrong answer
6153f2b
6153f2b
	This changes to use Perl_strtod() when available, and that turns out to
6153f2b
	be the key to fixing this bug.
6153f2b
6153f2b
	S_mulexp10() is removed from embed.fnc to avoid repeating the
6153f2b
	complicated prerequisites for defining Perl_strtod().  This works
6153f2b
	because this static function already was defined before use in
6153f2b
	numeric.c, and always called in full form without using a macro.
6153f2b
6153f2b
	James Keenan fixed a file permissions problem originally introduced by
6153f2b
	this commit, but the fix has been squashed into it.
6153f2b
890552a
But it was recognized as a bug and the behavior was restored with:
890552a
890552a
    commit 14d26b44a1d7eee67837ec0ea8fb0368ac6fe33e
890552a
    Author: Tony Cook <tony@develop-help.com>
890552a
    Date:   Tue Aug 20 15:43:05 2019 +1000
890552a
890552a
	(perl #134230) don't interpret 0x, 0b when numifying strings
890552a
890552a
Petr Písař: And we ported it to 5.30.0.
890552a
6153f2b
---
6153f2b
 t/tlib/AssertTest.pm | 2 +-
6153f2b
 1 file changed, 1 insertion(+), 1 deletion(-)
6153f2b
6153f2b
diff --git a/t/tlib/AssertTest.pm b/t/tlib/AssertTest.pm
890552a
index 42fa860..d58890c 100644
6153f2b
--- a/t/tlib/AssertTest.pm
6153f2b
+++ b/t/tlib/AssertTest.pm
6153f2b
@@ -34,7 +34,7 @@ sub test_numericness {
6153f2b
     my %tests =
6153f2b
       ( 1	=> 't',
6153f2b
 	0	=> 't',
6153f2b
-  	'0xF00'	=> 'f', # controversial?  but if you +=10 then it's == 10
890552a
+	'0xF00'	=> ($] gt '5.029001' && $] lt '5.030000') ? 't' : 'f',
6153f2b
 	'15e7'	=> 't',
6153f2b
 	'15E7'	=> 't',
6153f2b
 	"not 0"	=> 'f',
6153f2b
-- 
890552a
2.21.0
6153f2b