From fd70e6a1783bb642e845bf579a5452b055f0950f Mon Sep 17 00:00:00 2001
From: Paul Howarth <paul@city-fan.org>
Date: Oct 16 2019 17:40:12 +0000
Subject: Spec tidy-up


- Use author-independent source URL
- Classify buildreqs by usage
- Drop redundant %{?perl_default_filter}
- Drop redundant specification of compiler flags for noarch package
- Use DESTDIR rather than PERL_INSTALL_ROOT
- Simplify find command using -delete
- Don't need to remove empty directories from the buildroot
- Fix permissions verbosely
- Package the Changes file

---

diff --git a/perl-Unicode-MapUTF8.spec b/perl-Unicode-MapUTF8.spec
index bee77ca..df39dc3 100644
--- a/perl-Unicode-MapUTF8.spec
+++ b/perl-Unicode-MapUTF8.spec
@@ -1,28 +1,45 @@
 Name:           perl-Unicode-MapUTF8
 Version:        1.11
-Release:        39%{?dist}
-
+Release:        40%{?dist}
 Summary:        Conversions to and from arbitrary character sets and UTF8
-
 License:        GPL+ or Artistic
 URL:            https://metacpan.org/release/Unicode-MapUTF8
-Source0:        https://cpan.metacpan.org/authors/id/S/SN/SNOWHARE/Unicode-MapUTF8-%{version}.tar.gz
-
+Source0:        https://cpan.metacpan.org/modules/by-module/Unicode/Unicode-MapUTF8-%{version}.tar.gz
 BuildArch:      noarch
+# Module Build
+BuildRequires:  coreutils
+BuildRequires:  findutils
+BuildRequires:  make
 BuildRequires:  perl-generators
-BuildRequires:  perl(ExtUtils::MakeMaker), perl(Jcode)
-BuildRequires:  perl(Unicode::Map), perl(Unicode::Map8), perl(Unicode::String)
-BuildRequires:  perl(Test::More), perl(Test::Pod), perl(Test::Pod::Coverage)
+BuildRequires:  perl-interpreter
+BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(File::Copy)
+BuildRequires:  perl(File::Spec)
+# Module Runtime
+BuildRequires:  perl(Carp)
+BuildRequires:  perl(Exporter)
+BuildRequires:  perl(Jcode)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(subs)
+BuildRequires:  perl(Unicode::Map)
+BuildRequires:  perl(Unicode::Map8)
+BuildRequires:  perl(Unicode::String)
+BuildRequires:  perl(vars)
+# Test Suite
+BuildRequires:  perl(lib)
+BuildRequires:  perl(Test::More)
+# Optional Tests
 BuildRequires:  perl(Test::Distribution)
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
-
-%{?perl_default_filter}
+BuildRequires:  perl(Test::Pod) >= 1.00
+BuildRequires:  perl(Test::Pod::Coverage) >= 1.06
+# Dependencies
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 Unicode::MapUTF8 Provides an adapter layer between core routines for
 converting to and from UTF8 and other encodings. In essence, a way to
 give multiple existing Unicode modules a single common interface so
-you don't have to know the underlaying implementations to do simple
+you don't have to know the underlying implementations to do simple
 UTF8 to-from other character set string conversions. As such, it wraps
 the Unicode::String, Unicode::Map8, Unicode::Map and Jcode modules in
 a standardized and simple API.
@@ -33,15 +50,14 @@ a standardized and simple API.
 
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 
 %install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';'
-chmod -R u+w $RPM_BUILD_ROOT/*
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -delete
+%{_fixperms} -c %{buildroot}
 
 
 %check
@@ -49,14 +65,26 @@ make test
 
 
 %files
-%doc README
+%doc Changes README
 %dir %{perl_vendorlib}/Unicode/
 %doc %{perl_vendorlib}/Unicode/MapUTF8.pod
 %{perl_vendorlib}/Unicode/MapUTF8.pm
-%{_mandir}/man3/Unicode::MapUTF8.3pm*
+%{_mandir}/man3/Unicode::MapUTF8.3*
 
 
 %changelog
+* Wed Oct 16 2019 Paul Howarth <paul@city-fan.org> - 1.11-40
+- Spec tidy-up
+  - Use author-independent source URL
+  - Classify buildreqs by usage
+  - Drop redundant %%{?perl_default_filter}
+  - Drop redundant specification of compiler flags for noarch package
+  - Use DESTDIR rather than PERL_INSTALL_ROOT
+  - Simplify find command using -delete
+  - Don't need to remove empty directories from the buildroot
+  - Fix permissions verbosely
+  - Package the Changes file
+
 * Fri Jul 26 2019 Fedora Release Engineering <releng@fedoraproject.org> - 1.11-39
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild