Blame perl-5.31.2-locale.c-Stop-Coverity-warning.patch
|
 |
a7ac384 |
From 21dce8f4eb9136875a886371016aa25788f5144f Mon Sep 17 00:00:00 2001
|
|
|
a7ac384 |
From: Karl Williamson <khw@cpan.org>
|
|
|
a7ac384 |
Date: Tue, 6 Aug 2019 21:29:22 -0600
|
|
|
a7ac384 |
Subject: [PATCH] locale.c: Stop Coverity warning
|
|
|
a7ac384 |
MIME-Version: 1.0
|
|
|
a7ac384 |
Content-Type: text/plain; charset=UTF-8
|
|
|
a7ac384 |
Content-Transfer-Encoding: 8bit
|
|
|
a7ac384 |
|
|
|
a7ac384 |
Coverity is right, so re-order these clauses. This code is executed
|
|
|
a7ac384 |
only if some very strange error occurs.
|
|
|
a7ac384 |
|
|
|
a7ac384 |
Signed-off-by: Petr Písař <ppisar@redhat.com>
|
|
|
a7ac384 |
---
|
|
|
a7ac384 |
locale.c | 11 ++++++-----
|
|
|
a7ac384 |
1 file changed, 6 insertions(+), 5 deletions(-)
|
|
|
a7ac384 |
|
|
|
a7ac384 |
diff --git a/locale.c b/locale.c
|
|
|
a7ac384 |
index db83d993de..af7af60038 100644
|
|
|
a7ac384 |
--- a/locale.c
|
|
|
a7ac384 |
+++ b/locale.c
|
|
|
a7ac384 |
@@ -4349,11 +4349,6 @@ Perl__mem_collxfrm(pTHX_ const char *input_string,
|
|
|
a7ac384 |
return xbuf;
|
|
|
a7ac384 |
|
|
|
a7ac384 |
bad:
|
|
|
a7ac384 |
- Safefree(xbuf);
|
|
|
a7ac384 |
- if (s != input_string) {
|
|
|
a7ac384 |
- Safefree(s);
|
|
|
a7ac384 |
- }
|
|
|
a7ac384 |
- *xlen = 0;
|
|
|
a7ac384 |
|
|
|
a7ac384 |
# ifdef DEBUGGING
|
|
|
a7ac384 |
|
|
|
a7ac384 |
@@ -4363,6 +4358,12 @@ Perl__mem_collxfrm(pTHX_ const char *input_string,
|
|
|
a7ac384 |
|
|
|
a7ac384 |
# endif
|
|
|
a7ac384 |
|
|
|
a7ac384 |
+ Safefree(xbuf);
|
|
|
a7ac384 |
+ if (s != input_string) {
|
|
|
a7ac384 |
+ Safefree(s);
|
|
|
a7ac384 |
+ }
|
|
|
a7ac384 |
+ *xlen = 0;
|
|
|
a7ac384 |
+
|
|
|
a7ac384 |
return NULL;
|
|
|
a7ac384 |
}
|
|
|
a7ac384 |
|
|
|
a7ac384 |
--
|
|
|
a7ac384 |
2.20.1
|
|
|
a7ac384 |
|