|
 |
366d7e0 |
From 7c3f362035dec9b7eaec388b1f7f1619c1bd96a3 Mon Sep 17 00:00:00 2001
|
|
|
366d7e0 |
From: Tony Cook <tony@develop-help.com>
|
|
|
366d7e0 |
Date: Mon, 4 Nov 2019 09:52:22 +1100
|
|
|
366d7e0 |
Subject: [PATCH] prevent a race between name-based stat and an open modifying
|
|
|
366d7e0 |
atime
|
|
|
366d7e0 |
MIME-Version: 1.0
|
|
|
366d7e0 |
Content-Type: text/plain; charset=UTF-8
|
|
|
366d7e0 |
Content-Transfer-Encoding: 8bit
|
|
|
366d7e0 |
|
|
|
366d7e0 |
Most linux systems rarely update atime, so it's very unlikely
|
|
|
366d7e0 |
for this issue to trigger there, but on a system with classic atime
|
|
|
366d7e0 |
behaviour this was a race between open modifying atime and time()
|
|
|
366d7e0 |
ticking over.
|
|
|
366d7e0 |
|
|
|
366d7e0 |
gh #17234
|
|
|
366d7e0 |
|
|
|
366d7e0 |
Signed-off-by: Petr Písař <ppisar@redhat.com>
|
|
|
366d7e0 |
---
|
|
|
366d7e0 |
lib/File/stat.t | 6 ++++--
|
|
|
366d7e0 |
1 file changed, 4 insertions(+), 2 deletions(-)
|
|
|
366d7e0 |
|
|
|
366d7e0 |
diff --git a/lib/File/stat.t b/lib/File/stat.t
|
|
|
366d7e0 |
index c403fc4498..fc9bb12cef 100644
|
|
|
366d7e0 |
--- a/lib/File/stat.t
|
|
|
366d7e0 |
+++ b/lib/File/stat.t
|
|
|
366d7e0 |
@@ -133,6 +133,9 @@ SKIP: {
|
|
|
366d7e0 |
test_X_ops($^X, "for $^X", qr/A/);
|
|
|
366d7e0 |
}
|
|
|
366d7e0 |
|
|
|
366d7e0 |
+# open early so atime is consistent with the name based call
|
|
|
366d7e0 |
+local *STAT;
|
|
|
366d7e0 |
+my $canopen = open(STAT, '<', $file);
|
|
|
366d7e0 |
|
|
|
366d7e0 |
my $stat = File::stat::stat($file);
|
|
|
366d7e0 |
isa_ok($stat, 'File::stat', 'should build a stat object');
|
|
|
366d7e0 |
@@ -143,8 +146,7 @@ for (split //, "tTB") {
|
|
|
366d7e0 |
}
|
|
|
366d7e0 |
|
|
|
366d7e0 |
SKIP: {
|
|
|
366d7e0 |
- local *STAT;
|
|
|
366d7e0 |
- skip("Could not open file: $!", 2) unless open(STAT, '<', $file);
|
|
|
366d7e0 |
+ skip("Could not open file: $!", 2) unless $canopen;
|
|
|
366d7e0 |
isa_ok(File::stat::stat('STAT'), 'File::stat',
|
|
|
366d7e0 |
'... should be able to find filehandle');
|
|
|
366d7e0 |
|
|
|
366d7e0 |
--
|
|
|
366d7e0 |
2.21.0
|
|
|
366d7e0 |
|