#2 Move -Wno-free-nonheap-object to gcc_cflags
Opened 3 years ago by tbaeder. Modified 3 months ago
rpms/ tbaeder/pesign master  into  rawhide

@@ -21,15 +21,15 @@ 

  index d4cd626..705cc3a 100644

  --- a/Make.defaults

  +++ b/Make.defaults

- @@ -40,7 +40,7 @@ gcc_cflags = -Wmaybe-uninitialized -grecord-gcc-switches -flto

+ @@ -36,7 +36,7 @@

+  

+  SOFLAGS	= -shared

+  clang_cflags =

+ -gcc_cflags = -Wmaybe-uninitialized -grecord-gcc-switches -flto

+ +gcc_cflags = -Wmaybe-uninitialized -grecord-gcc-switches -flto -Wno-free-nonheap-object

   cflags	= $(CFLAGS) $(ARCH3264) \

   	-Wall -Wextra -Wsign-compare -Wno-unused-result \

   	-Wno-unused-function -Wno-missing-field-initializers \

- -	-Werror -Wno-error=cpp \

- +	-Werror -Wno-error=cpp -Wno-free-nonheap-object \

-  	-std=gnu11 -fshort-wchar -fPIC -fno-strict-aliasing \

-  	-D_GNU_SOURCE -DCONFIG_$(ARCH) -I${TOPDIR}/include \

-  	$(if $(filter $(CC),clang),$(clang_cflags), ) \

  -- 

  2.28.0

  

file modified
+4 -1
@@ -3,7 +3,7 @@ 

  Name:    pesign

  Summary: Signing utility for UEFI binaries

  Version: 113

- Release: 14%{?dist}

+ Release: 15%{?dist}

  License: GPLv2

  URL:     https://github.com/vathpela/pesign

  
@@ -167,6 +167,9 @@ 

  %{python3_sitelib}/mockbuild/plugins/pesign.*

  

  %changelog

+ * Wed Dec 16 2020 Timm Bäder <tbaeder@redhat.com> - 113-15

+ - Move -Wno-free-nonheap-object to gcc_cflags

+ 

  * Mon Nov 16 2020 Jeff Law <law@redhat.com> - 113-14

  - Turn off -Wfree-nonheap-object

  

The project already has support for compiler-specific cflags and
-Wno-free-nonheap-object is gcc-only, so move it to gcc_cflags.

Hi @tbaeder, should we close this PR ?